From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CCBBA054A for ; Tue, 25 Oct 2022 17:08:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B6D142C59; Tue, 25 Oct 2022 17:08:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5DEFE42C3D for ; Tue, 25 Oct 2022 17:08:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5LeNE31KKodhUAtT940LAW0PIx97gxDPnlmMlsPuj8=; b=HZS0JMUzR8Vhq9sKecSQBbdIN18FhpxypxNGBHOC9282l5RlQ6DA0J0F7zgRNURF+FxLzZ SUsiHrX7O+fxtz8UlXCM0jz2ksSoJdtAU3jOfMXlEcyBFUxlQsSvQm0bEotJRDZUCtdVig ysjcqW4pWmokl1HD2qvwcQEF6Y/Jhws= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-ZtC_LGRXOum32n0Qpos9zg-1; Tue, 25 Oct 2022 11:08:49 -0400 X-MC-Unique: ZtC_LGRXOum32n0Qpos9zg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3ABB32A59553; Tue, 25 Oct 2022 15:08:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1875A49BB60; Tue, 25 Oct 2022 15:08:40 +0000 (UTC) From: Kevin Traynor To: Jeremy Spewock Cc: Owen Hilyard , Ruifeng Wang , dpdk stable Subject: patch 'test/ipsec: skip if no compatible device' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:26 +0100 Message-Id: <20221025150734.142189-31-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb Thanks. Kevin --- >From 6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb Mon Sep 17 00:00:00 2001 From: Jeremy Spewock Date: Tue, 12 Jul 2022 10:17:01 -0400 Subject: [PATCH] test/ipsec: skip if no compatible device [ upstream commit 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 ] ipsec_autotest is now skipped if no compatible crypto devices are found. Fixes issue where if at least one crypto device was found but no compatible crypto devices for the ipsec_autotest test case are present, the case would fail with no error message. Now, when this situation is encountered, the test case will be skipped with an explanation. Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Signed-off-by: Jeremy Spewock Signed-off-by: Owen Hilyard Reviewed-by: Ruifeng Wang --- app/test/test_ipsec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 3c6dcdc604..6d5431843f 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test_ipsec.c @@ -310,6 +310,8 @@ testsuite_setup(void) } - if (ts_params->valid_dev_found == 0) - return TEST_FAILED; + if (ts_params->valid_dev_found == 0) { + RTE_LOG(WARNING, USER1, "No compatible crypto device found.\n"); + return TEST_SKIPPED; + } ts_params->mbuf_pool = rte_pktmbuf_pool_create( -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.248242872 +0100 +++ 0031-test-ipsec-skip-if-no-compatible-device.patch 2022-10-25 14:18:58.385797998 +0100 @@ -1 +1 @@ -From 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 Mon Sep 17 00:00:00 2001 +From 6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 7047e17960..7c03a06785 100644 +index 3c6dcdc604..6d5431843f 100644 @@ -27 +28 @@ -@@ -321,6 +321,8 @@ testsuite_setup(void) +@@ -310,6 +310,8 @@ testsuite_setup(void)