From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83D5A054A for ; Tue, 25 Oct 2022 17:09:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3D4A42C3F; Tue, 25 Oct 2022 17:09:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0E88342C1D for ; Tue, 25 Oct 2022 17:08:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ph/w3c4d6gRrZWB3/Vpx6omK5Y/rnZPhn4hdiYzhDto=; b=ha9HzD5g0wj46Pz1cVzLz0kQR1bdkwQwxyKDw/xUabl9l+HDBNWzW8n/CPLicAk+CxXSOX j/rrvYeigbAQJ/IlvGtQL2fiErETFarxvHD2357PVTO16pi96KPppX/qMNg00LkS2tDcwM i/2TKWA9eT+gwNCifYo/ty91+MM093A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-aAJYilhPMsCF-hjkbJsOSQ-1; Tue, 25 Oct 2022 11:08:57 -0400 X-MC-Unique: aAJYilhPMsCF-hjkbJsOSQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E571A87A9EC; Tue, 25 Oct 2022 15:08:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C08647505E; Tue, 25 Oct 2022 15:08:53 +0000 (UTC) From: Kevin Traynor To: Ke Zhang Cc: Yuying Zhang , dpdk stable Subject: patch 'net/i40e: fix VF representor release' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:35 +0100 Message-Id: <20221025150734.142189-40-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/85821d6d952d886ae2567b6045101c74bea383c6 Thanks. Kevin --- >From 85821d6d952d886ae2567b6045101c74bea383c6 Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Thu, 4 Aug 2022 17:50:03 +0800 Subject: [PATCH] net/i40e: fix VF representor release [ upstream commit ba10df53e486ef7918c1236ef4d8da16ae3a32e1 ] A segmentation fault occurs when testpmd exit. This is due to fetching the device name from PF, PF is freed firstly and then VF representor is called later. This commit fixes the bug by fetching the device name from VF representor instead of PF. Fixes: e391a7b7f815 ("net/i40e: fix multi-process shared data") Signed-off-by: Ke Zhang Acked-by: Yuying Zhang --- drivers/net/i40e/i40e_vf_representor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c index 7f8e81858e..bcd445bcdd 100644 --- a/drivers/net/i40e/i40e_vf_representor.c +++ b/drivers/net/i40e/i40e_vf_representor.c @@ -30,6 +30,4 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, { struct i40e_vf_representor *representor = ethdev->data->dev_private; - struct rte_eth_dev_data *pf_dev_data = - representor->adapter->pf.dev_data; /* get dev info for the vdev */ @@ -105,5 +103,5 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, dev_info->switch_info.name = - rte_eth_devices[pf_dev_data->port_id].device->name; + rte_eth_devices[ethdev->data->port_id].device->name; dev_info->switch_info.domain_id = representor->switch_domain_id; dev_info->switch_info.port_id = representor->vf_id; -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.446254551 +0100 +++ 0040-net-i40e-fix-VF-representor-release.patch 2022-10-25 14:18:58.401798055 +0100 @@ -1 +1 @@ -From ba10df53e486ef7918c1236ef4d8da16ae3a32e1 Mon Sep 17 00:00:00 2001 +From 85821d6d952d886ae2567b6045101c74bea383c6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba10df53e486ef7918c1236ef4d8da16ae3a32e1 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index cc0f992453..c00ae832aa 100644 +index 7f8e81858e..bcd445bcdd 100644