From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BB81A054A for ; Tue, 25 Oct 2022 17:09:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6640D42C3F; Tue, 25 Oct 2022 17:09:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9C7F442C34 for ; Tue, 25 Oct 2022 17:09:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dZoqtX3CfLLdWVq1H+3rUvY6HWHvMiL0TbbGfd3Dzb8=; b=OqfyoA+f+olLqiisWJ62afZkXxSeEgTQNQbgkrNU3DVY+TybDTkobWmDkxLwfU9VcZA8bj 7vYe7aESNS73hw/OSVHrZlcFgVIsSB/aL8Nln91LnG7f1+GHMB/9czBaQu70JAfEaNNS2q Zzu7WHvL5ctMvWC6CfpAMKdTkReIGXk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-216-NZUsGAElP96bRQzTGHnZaA-1; Tue, 25 Oct 2022 11:09:05 -0400 X-MC-Unique: NZUsGAElP96bRQzTGHnZaA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D683823F91; Tue, 25 Oct 2022 15:09:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76FE14B400F; Tue, 25 Oct 2022 15:09:04 +0000 (UTC) From: Kevin Traynor To: Steven Zou Cc: Qi Zhang , dpdk stable Subject: patch 'common/iavf: avoid copy in async mode' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:06:43 +0100 Message-Id: <20221025150734.142189-48-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/85de6911de73e6d9ea59c44c44104ebef7d7b4c4 Thanks. Kevin --- >From 85de6911de73e6d9ea59c44c44104ebef7d7b4c4 Mon Sep 17 00:00:00 2001 From: Steven Zou Date: Mon, 5 Sep 2022 09:42:06 +0800 Subject: [PATCH] common/iavf: avoid copy in async mode [ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ] If cmd_details are defined or async flag is set, don't copy the desc/buff back to temp. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Signed-off-by: Steven Zou Acked-by: Qi Zhang --- drivers/common/iavf/iavf_adminq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/iavf/iavf_adminq.c b/drivers/common/iavf/iavf_adminq.c index 9c36e8908e..06644b02a1 100644 --- a/drivers/common/iavf/iavf_adminq.c +++ b/drivers/common/iavf/iavf_adminq.c @@ -789,5 +789,6 @@ enum iavf_status iavf_asq_send_command(struct iavf_hw *hw, /* if ready, copy the desc back to temp */ - if (iavf_asq_done(hw)) { + if (iavf_asq_done(hw) && + !details->async && !details->postpone) { iavf_memcpy(desc, desc_on_ring, sizeof(struct iavf_aq_desc), IAVF_DMA_TO_NONDMA); -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:18:59.619531319 +0100 +++ 0048-common-iavf-avoid-copy-in-async-mode.patch 2022-10-25 14:18:58.411798091 +0100 @@ -1 +1 @@ -From c60fad56266fef1f5f6e08c062806e137713e9da Mon Sep 17 00:00:00 2001 +From 85de6911de73e6d9ea59c44c44104ebef7d7b4c4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 8b305c0fe3..56c8a519be 100644 +index 9c36e8908e..06644b02a1 100644