From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02364A054A for ; Tue, 25 Oct 2022 17:09:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F290B42C42; Tue, 25 Oct 2022 17:09:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 124CF42C3F for ; Tue, 25 Oct 2022 17:09:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wXG+nU138c8M+Jn7iateKTdnkpPjKwBHs/ySpphW1Pg=; b=NUblnXSfAZbKYV/2Yx6y2TR5mt1SIVJnjpz+v2PyYJzHDhj92QFK7HcywWhZMhfr6dwDO3 0XkHRXn97b0R0tzTqtDH1boOmXZpgeZ/LvHobm/qzqzx//JqEGCEDORtGN4Cpgg/y6v6tg FxaNC6ZEw7Dw9g0RO/QuTjGICZGuVCo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-d_CYm2huMcu1VxTHDUuNzw-1; Tue, 25 Oct 2022 11:09:50 -0400 X-MC-Unique: d_CYm2huMcu1VxTHDUuNzw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0798E101AA46; Tue, 25 Oct 2022 15:09:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2AA9477F55; Tue, 25 Oct 2022 15:09:48 +0000 (UTC) From: Kevin Traynor To: Mao YingMing Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix null pointer dereference in LED config' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:16 +0100 Message-Id: <20221025150734.142189-81-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d4774717275b47c291f8da09da17aea4deedd822 Thanks. Kevin --- >From d4774717275b47c291f8da09da17aea4deedd822 Mon Sep 17 00:00:00 2001 From: Mao YingMing Date: Tue, 2 Aug 2022 12:08:17 +0800 Subject: [PATCH] net/bnxt: fix null pointer dereference in LED config [ upstream commit 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 ] For VFs, bp->leds is uninitialized, check bp->leds is not null before checking for bp->leds->num_leds. segfault backtrace in trex program when use VF: 11: bnxt_hwrm_port_led_cfg (bp=0x23ffb2140, led_on=true) 10: bnxt_dev_led_on_op (dev=0x22d7780 ) 9: rte_eth_led_on (port_id=0) 8: DpdkTRexPortAttr::set_led (this=0x23b6ce0, on=true) 7: DpdkTRexPortAttr::DpdkTRexPortAttr 6: CTRexExtendedDriverBnxt::create_port_attr 5: CPhyEthIF::Create 4: CGlobalTRex::device_start 3: CGlobalTRex::Create 2: main_test 1: main Fixes: d4d5a04 ("net/bnxt: fix unnecessary memory allocation") Signed-off-by: Mao YingMing Acked-by: Somnath Kotur Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 9c5257309a..51e1e2d6b3 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -4536,5 +4536,5 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on) int rc, i; - if (!bp->leds->num_leds || BNXT_VF(bp)) + if (BNXT_VF(bp) || !bp->leds || !bp->leds->num_leds) return -EOPNOTSUPP; -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.377396063 +0100 +++ 0081-net-bnxt-fix-null-pointer-dereference-in-LED-config.patch 2022-10-25 14:18:58.513798456 +0100 @@ -1 +1 @@ -From 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 Mon Sep 17 00:00:00 2001 +From d4774717275b47c291f8da09da17aea4deedd822 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org