From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BBF9A054A for ; Tue, 25 Oct 2022 17:09:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36E0942C4F; Tue, 25 Oct 2022 17:09:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 83F6B42C3C for ; Tue, 25 Oct 2022 17:09:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6YqkuIlJbaiAKu9wBxAWVZp8fTCzET05NRYf3i2FDLA=; b=OfA3RuJnUGLjs94ExtCSY7ZMXe53e1TzX0d4l2B+N+rzGPqF/+WEonbnk46LHKW1UELaD2 OaEkCFI7UDE+DUMlqqAzfPEO3GfX0h0wl8DMSCwcPYaMZkNGqTih4wCPbctG2vqjnYNzXT CH1ohgv9fEdjWSlhwWEwoqtWe55CZ8w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-in3rkxRmM36AYwbhE0TP6Q-1; Tue, 25 Oct 2022 11:09:52 -0400 X-MC-Unique: in3rkxRmM36AYwbhE0TP6Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58122185A7A3; Tue, 25 Oct 2022 15:09:51 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 689CB477F55; Tue, 25 Oct 2022 15:09:50 +0000 (UTC) From: Kevin Traynor To: Benjamin Le Berre Cc: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix error code during MTU change' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:17 +0100 Message-Id: <20221025150734.142189-82-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a12a1fcc0c38e8694d1abe3252c2e8b83605fec9 Thanks. Kevin --- >From a12a1fcc0c38e8694d1abe3252c2e8b83605fec9 Mon Sep 17 00:00:00 2001 From: Benjamin Le Berre Date: Thu, 15 Sep 2022 13:29:06 +0200 Subject: [PATCH] net/bnxt: fix error code during MTU change [ upstream commit 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 ] When the BNXT PMD was made to disallow MTU changes on active ports, the error code chosen for the case in bnxt_set_mtu_op() was -EPERM. The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h lists -EBUSY as the value to be used if the port must be stopped before applying an MTU change and does not list -EPERM as a possible return value. This patch makes bnxt_set_mtu_op() return -EBUSY instead of -EPERM so that rte_eth_dev_set_mtu() behaves as expected. Fixes: a42ab1eb33ff ("net/bnxt: disallow MTU change when device is started") Signed-off-by: Benjamin Le Berre Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 517e4b3898..5c9a260db5 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -3032,5 +3032,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu) if (eth_dev->data->dev_started) { PMD_DRV_LOG(ERR, "Stop port before changing MTU\n"); - return -EPERM; + return -EBUSY; } -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.401026048 +0100 +++ 0082-net-bnxt-fix-error-code-during-MTU-change.patch 2022-10-25 14:18:58.517798471 +0100 @@ -1 +1 @@ -From 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 Mon Sep 17 00:00:00 2001 +From a12a1fcc0c38e8694d1abe3252c2e8b83605fec9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 1460dce2ab..c4d863e3fe 100644 +index 517e4b3898..5c9a260db5 100644 @@ -30 +31 @@ -@@ -3031,5 +3031,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu) +@@ -3032,5 +3032,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)