From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 688C5A054A for ; Tue, 25 Oct 2022 17:09:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64E6042C48; Tue, 25 Oct 2022 17:09:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CF63A42C38 for ; Tue, 25 Oct 2022 17:09:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h86xKdDCAycKOB3t9Qe1X/0aLhAGRvsA6xA1hNwwWME=; b=V53REFgpeoD+6KgEMsn4HSI+vYoCLAqB+VnLOLfEdLjD3geoaO3dAL3F+TaFvaa+t+K5Mb uYdf0kbQ7ML8vZqom317fbhlBdCYO8jxcRTV0xWqahHYEmJ/seyT3TbGs/NJdfBo3RZKyD d1vSRSkn0PmqL4kuC0DefTHV5xhHbmc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-546-5PN83r7DNXWH7CM5YvlC2Q-1; Tue, 25 Oct 2022 11:09:54 -0400 X-MC-Unique: 5PN83r7DNXWH7CM5YvlC2Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50FB83C138A3; Tue, 25 Oct 2022 15:09:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 178AD492CA2; Tue, 25 Oct 2022 15:09:52 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix representor info freeing' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:19 +0100 Message-Id: <20221025150734.142189-84-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b673b37b9aaf889c05ed462d0890027023f576c6 Thanks. Kevin --- >From b673b37b9aaf889c05ed462d0890027023f576c6 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 27 Sep 2022 21:29:02 +0530 Subject: [PATCH] net/bnxt: fix representor info freeing [ upstream commit 5fdf25bd5531b3cb267201272c259ba4d0a32ca5 ] Driver allocates "bp->rep_info" inside bnxt_init_rep_info() which is invoked from bnxt_rep_port_probe(). But the memory is freed inside bnxt_uninit_resources(), which is wrong. As a result, after error recovery bp->rep_info will be NULL. The memory should have freed inside bnxt_drv_uninit() to maintain symmetry of calls. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 4da4030fce..f72740752a 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1656,4 +1656,5 @@ static void bnxt_drv_uninit(struct bnxt *bp) bnxt_free_parent_info(bp); bnxt_uninit_locks(bp); + bnxt_free_rep_info(bp); rte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone); @@ -5979,5 +5980,4 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev) bnxt_free_flow_stats_info(bp); bnxt_free_switch_domain(bp); - bnxt_free_rep_info(bp); rte_free(bp->ptp_cfg); bp->ptp_cfg = NULL; -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.446242626 +0100 +++ 0084-net-bnxt-fix-representor-info-freeing.patch 2022-10-25 14:18:58.524798496 +0100 @@ -1 +1 @@ -From 5fdf25bd5531b3cb267201272c259ba4d0a32ca5 Mon Sep 17 00:00:00 2001 +From b673b37b9aaf889c05ed462d0890027023f576c6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5fdf25bd5531b3cb267201272c259ba4d0a32ca5 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 2b5279f32c..3dfe9efc09 100644 +index 4da4030fce..f72740752a 100644 @@ -26 +27 @@ -@@ -1655,4 +1655,5 @@ static void bnxt_drv_uninit(struct bnxt *bp) +@@ -1656,4 +1656,5 @@ static void bnxt_drv_uninit(struct bnxt *bp)