From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AA67A054A for ; Tue, 25 Oct 2022 17:10:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9312442C3C; Tue, 25 Oct 2022 17:10:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E097742C34 for ; Tue, 25 Oct 2022 17:10:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HYb9SOJqxZP/pWubgcxduQoFxHAVe/qc/C2cYtBLZuY=; b=MxQNREQ2kuywQISJZRE0CSXu/TGTwtz2GdKQqzoK+4a85M6wGPQRmyh1GBa6VKTCdbYZQn UGxoBz6zmyuSqCdgNw6jcSjTZxmzqUI0NA/IkVkd1QJe/1CPvFxaMbb6VexubJKnu5wQlM AuzKb+FwOy7HiYumoM6bWVHXdcSeM7U= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-yYsDofDlOheqpVkzTYTTjQ-1; Tue, 25 Oct 2022 11:10:04 -0400 X-MC-Unique: yYsDofDlOheqpVkzTYTTjQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A6EF3826A4A; Tue, 25 Oct 2022 15:10:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31F4649BB60; Tue, 25 Oct 2022 15:10:01 +0000 (UTC) From: Kevin Traynor To: Amit Prakash Shukla Cc: Thomas Monjalon , dpdk stable Subject: patch 'net/i40e: fix build with MinGW GCC 12' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:25 +0100 Message-Id: <20221025150734.142189-90-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9ba87edbe69cac90bf8aff9714e3724519c633bf Thanks. Kevin --- >From 9ba87edbe69cac90bf8aff9714e3724519c633bf Mon Sep 17 00:00:00 2001 From: Amit Prakash Shukla Date: Wed, 24 Aug 2022 19:33:38 +0530 Subject: [PATCH] net/i40e: fix build with MinGW GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit eb440cea1e05245f362ec7fca932f2d977f12359 ] When compiling with MinGW GCC 12, the rte_flow_item array is seen as read out of bound: net/i40e/i40e_hash.c:389:47: error: array subscript 50 is above array bounds of ‘const uint64_t[50]’ {aka ‘const long long unsigned int[50]’} [-Werror=array-bounds] 389 | item_hdr = pattern_item_header[last_item_type]; | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ It seems the assert check done above this line has no impact. A real check is added to make the compiler happy. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Amit Prakash Shukla Acked-by: Thomas Monjalon --- drivers/net/i40e/i40e_hash.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index 8962e9d97a..a1ff85fceb 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -385,6 +385,8 @@ i40e_hash_get_pattern_type(const struct rte_flow_item pattern[], prev_item_type = last_item_type; - assert(last_item_type < (enum rte_flow_item_type) - RTE_DIM(pattern_item_header)); + if (last_item_type >= (enum rte_flow_item_type) + RTE_DIM(pattern_item_header)) + goto not_sup; + item_hdr = pattern_item_header[last_item_type]; assert(item_hdr); -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.575625743 +0100 +++ 0090-net-i40e-fix-build-with-MinGW-GCC-12.patch 2022-10-25 14:18:58.532798524 +0100 @@ -1 +1 @@ -From eb440cea1e05245f362ec7fca932f2d977f12359 Mon Sep 17 00:00:00 2001 +From 9ba87edbe69cac90bf8aff9714e3724519c633bf Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit eb440cea1e05245f362ec7fca932f2d977f12359 ] + @@ -22 +23,0 @@ -Cc: stable@dpdk.org