From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9A09A054A for ; Tue, 25 Oct 2022 17:10:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E510442C3C; Tue, 25 Oct 2022 17:10:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8638842C34 for ; Tue, 25 Oct 2022 17:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJdsS/qeJrNAVTc3D6Am+IKnOevUTE9swTGYQMsD5EA=; b=K0eYjo7AiFTh/O4eoBbK2GsT1jzhK460dPme5VbZ0tuYuzE5G4ysqJBuL8NyMuvTrt0pxe yUxM4teWOo5N/rytKY533+7a+WxiO7UedAaLX2A/RJm8tVw+kcMUqdWSACinZ7VhQWuF1/ VN5ZolxAZCvdqjXLFyJSWoAtilOyQtg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-443-EzgvCWEVPoWxHRkTpGqnjA-1; Tue, 25 Oct 2022 11:10:05 -0400 X-MC-Unique: EzgvCWEVPoWxHRkTpGqnjA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C19D101AA47; Tue, 25 Oct 2022 15:10:04 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B6C04A9254; Tue, 25 Oct 2022 15:10:03 +0000 (UTC) From: Kevin Traynor To: Amit Prakash Shukla Cc: Thomas Monjalon , dpdk stable Subject: patch 'net/qede/base: fix 32-bit build with GCC 12' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:26 +0100 Message-Id: <20221025150734.142189-91-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4d4b866a158e5079dcac3f6533c06c4acdf2dd69 Thanks. Kevin --- >From 4d4b866a158e5079dcac3f6533c06c4acdf2dd69 Mon Sep 17 00:00:00 2001 From: Amit Prakash Shukla Date: Wed, 24 Aug 2022 19:33:39 +0530 Subject: [PATCH] net/qede/base: fix 32-bit build with GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit acc0ed087cd1ce6464f63489ab17eca52b0c94b2 ] A pointer is passed to a macro and it seems mistakenly referenced. This issue is seen only when compiling with GCC 12 for 32-bit: drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25: error: array subscript 1 is outside array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] 1418 | ecore_wr(dev, ptt, ((addr) + (4 * i)), \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1419 | ((u32 *)&(arr))[i]); \ | ~~~~~~~~~~~~~~~~~~~ drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17: note: in expansion of macro ‘ARR_REG_WR’ 1465 | ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords); | ^~~~~~~~~~ drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35: note: at offset 4 into object ‘pData’ of size 4 1439 | u32 *pData, | ~~~~~^~~~~ Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0") Signed-off-by: Amit Prakash Shukla Acked-by: Thomas Monjalon --- drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c index 6a52f32cc9..4e4d1dc374 100644 --- a/drivers/net/qede/base/ecore_init_fw_funcs.c +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c @@ -1417,5 +1417,5 @@ void ecore_init_brb_ram(struct ecore_hwfn *p_hwfn, for (i = 0; i < (arr_size); i++) \ ecore_wr(dev, ptt, ((addr) + (4 * i)), \ - ((u32 *)&(arr))[i]); \ + ((u32 *)(arr))[i]); \ } while (0) -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.596504266 +0100 +++ 0091-net-qede-base-fix-32-bit-build-with-GCC-12.patch 2022-10-25 14:18:58.533798528 +0100 @@ -1 +1 @@ -From acc0ed087cd1ce6464f63489ab17eca52b0c94b2 Mon Sep 17 00:00:00 2001 +From 4d4b866a158e5079dcac3f6533c06c4acdf2dd69 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit acc0ed087cd1ce6464f63489ab17eca52b0c94b2 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org