From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6712EA054A for ; Tue, 25 Oct 2022 17:10:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60F3D42C51; Tue, 25 Oct 2022 17:10:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 667AB42C34 for ; Tue, 25 Oct 2022 17:10:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YF56fQ82GgTg/zh2tPV7nJReXorChNImTj3LKfO5ygA=; b=B5KQ4Xx7l+w8XLrSFEE6ManDbXIch/uAPmc8+jxNkYX5DMyPCXkzJLJAarw9Q/f9Ar+OXX l7hQeXzG8lFXt/9TS8Deyupx+wi/3GoH2avLDHoy2Jj3F8wfkmGXmIosKkjSTcYM5Y6sWw Cnj2g3YpTq86LleajalCf1Xey0K0GLk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-NPFJTvn7N86VY0ZOgGEsgg-1; Tue, 25 Oct 2022 11:10:08 -0400 X-MC-Unique: NPFJTvn7N86VY0ZOgGEsgg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 716C1101A528; Tue, 25 Oct 2022 15:10:08 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80C044A9254; Tue, 25 Oct 2022 15:10:07 +0000 (UTC) From: Kevin Traynor To: Abhimanyu Saini Cc: Andrew Rybchenko , dpdk stable Subject: patch 'common/sfc_efx/base: remove VQ index check during VQ start' has been queued to stable release 21.11.3 Date: Tue, 25 Oct 2022 16:07:29 +0100 Message-Id: <20221025150734.142189-94-ktraynor@redhat.com> In-Reply-To: <20221025150734.142189-1-ktraynor@redhat.com> References: <20221025150734.142189-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/84cc72849a59db523b69e322a84a4d879032ceb1 Thanks. Kevin --- >From 84cc72849a59db523b69e322a84a4d879032ceb1 Mon Sep 17 00:00:00 2001 From: Abhimanyu Saini Date: Thu, 14 Jul 2022 19:18:00 +0530 Subject: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start [ upstream commit 93211a52a65f3f9c4280155ce7bd12a11c48ffdb ] The used/avail queue indexes are not bound by queue size, because HW calculates descriptor entry index by performing a simple modulo between queue index and queue_size. So, do not check initial used and avail queue indexes against queue size because it is possible for these indexes to be greater than queue size in the following cases: 1) The queue is created to be migrated into, or 2) The client issues a qstop/qstart after running datapath Fixes: 4dda72dbdeab3 ("common/sfc_efx/base: add base virtio support for vDPA") Signed-off-by: Abhimanyu Saini Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/rhead_virtio.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/common/sfc_efx/base/rhead_virtio.c b/drivers/common/sfc_efx/base/rhead_virtio.c index 335cb747d1..7f087170fe 100644 --- a/drivers/common/sfc_efx/base/rhead_virtio.c +++ b/drivers/common/sfc_efx/base/rhead_virtio.c @@ -48,12 +48,4 @@ rhead_virtio_qstart( } - if (evvdp != NULL) { - if ((evvdp->evvd_vq_cidx > evvcp->evvc_vq_size) || - (evvdp->evvd_vq_pidx > evvcp->evvc_vq_size)) { - rc = EINVAL; - goto fail3; - } - } - req.emr_cmd = MC_CMD_VIRTIO_INIT_QUEUE; req.emr_in_buf = payload; @@ -117,5 +109,5 @@ rhead_virtio_qstart( if (req.emr_rc != 0) { rc = req.emr_rc; - goto fail4; + goto fail3; } @@ -124,6 +116,4 @@ rhead_virtio_qstart( return (0); -fail4: - EFSYS_PROBE(fail4); fail3: EFSYS_PROBE(fail3); -- 2.37.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-10-25 14:19:00.664254730 +0100 +++ 0094-common-sfc_efx-base-remove-VQ-index-check-during-VQ-.patch 2022-10-25 14:18:58.536798539 +0100 @@ -1 +1 @@ -From 93211a52a65f3f9c4280155ce7bd12a11c48ffdb Mon Sep 17 00:00:00 2001 +From 84cc72849a59db523b69e322a84a4d879032ceb1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 93211a52a65f3f9c4280155ce7bd12a11c48ffdb ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org