* [PATCH 21.11 v1] event/dlb2: handle enqueuing more than maximum depth
@ 2022-10-26 23:09 Abdullah Sevincer
2022-11-01 14:53 ` Kevin Traynor
0 siblings, 1 reply; 2+ messages in thread
From: Abdullah Sevincer @ 2022-10-26 23:09 UTC (permalink / raw)
To: stable; +Cc: ktraynor, Abdullah Sevincer
[ upstream commit 9c9e72326bd28cd456509d60bcbe38a15a0bb7d0 ]
This patch addresses an issue of enqueuing more than
max_enq_depth and not able to dequeuing events equal
to max_cq_depth in a single call of rte_event_enqueue_burst
and rte_event_dequeue_burst.
Apply fix for restricting enqueue of events to max_enq_depth
so that in a single rte_event_enqueue_burst() call at most
max_enq_depth events are enqueued.
Also set per port and domain history list sizes based on
cq_depth. This results in dequeuing correct number of
events as set by max_cq_depth.
Fixes: f3cad285bb88 ("event/dlb2: add infos get and configure")
Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
---
drivers/event/dlb2/dlb2.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 543f793ed1..2e0f617b9c 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -627,7 +627,7 @@ dlb2_hw_create_sched_domain(struct dlb2_hw_dev *handle,
cfg->num_ldb_queues;
cfg->num_hist_list_entries = resources_asked->num_ldb_ports *
- DLB2_NUM_HIST_LIST_ENTRIES_PER_LDB_PORT;
+ evdev_dlb2_default_info.max_event_port_dequeue_depth;
if (device_version == DLB2_HW_V2_5) {
DLB2_LOG_DBG("sched domain create - ldb_qs=%d, ldb_ports=%d, dir_ports=%d, atomic_inflights=%d, hist_list_entries=%d, credits=%d\n",
@@ -1350,7 +1350,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2,
cfg.cq_depth = rte_align32pow2(dequeue_depth);
cfg.cq_depth_threshold = 1;
- cfg.cq_history_list_size = DLB2_NUM_HIST_LIST_ENTRIES_PER_LDB_PORT;
+ cfg.cq_history_list_size = cfg.cq_depth;
if (handle->cos_id == DLB2_COS_DEFAULT)
cfg.cos_id = 0;
@@ -2937,6 +2937,7 @@ __dlb2_event_enqueue_burst(void *event_port,
struct dlb2_eventdev_port *ev_port = event_port;
struct dlb2_port *qm_port = &ev_port->qm_port;
struct process_local_port_data *port_data;
+ int num_tx;
int i;
RTE_ASSERT(ev_port->enq_configured);
@@ -2946,7 +2947,8 @@ __dlb2_event_enqueue_burst(void *event_port,
port_data = &dlb2_port[qm_port->id][PORT_TYPE(qm_port)];
- while (i < num) {
+ num_tx = RTE_MIN(num, ev_port->conf.enqueue_depth);
+ while (i < num_tx) {
uint8_t sched_types[DLB2_NUM_QES_PER_CACHE_LINE];
uint8_t queue_ids[DLB2_NUM_QES_PER_CACHE_LINE];
int pop_offs = 0;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 21.11 v1] event/dlb2: handle enqueuing more than maximum depth
2022-10-26 23:09 [PATCH 21.11 v1] event/dlb2: handle enqueuing more than maximum depth Abdullah Sevincer
@ 2022-11-01 14:53 ` Kevin Traynor
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Traynor @ 2022-11-01 14:53 UTC (permalink / raw)
To: Abdullah Sevincer, stable
On 27/10/2022 00:09, Abdullah Sevincer wrote:
> [ upstream commit 9c9e72326bd28cd456509d60bcbe38a15a0bb7d0 ]
>
> This patch addresses an issue of enqueuing more than
> max_enq_depth and not able to dequeuing events equal
> to max_cq_depth in a single call of rte_event_enqueue_burst
> and rte_event_dequeue_burst.
>
> Apply fix for restricting enqueue of events to max_enq_depth
> so that in a single rte_event_enqueue_burst() call at most
> max_enq_depth events are enqueued.
>
> Also set per port and domain history list sizes based on
> cq_depth. This results in dequeuing correct number of
> events as set by max_cq_depth.
>
> Fixes: f3cad285bb88 ("event/dlb2: add infos get and configure")
>
> Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
> ---
> drivers/event/dlb2/dlb2.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Thanks for rebasing, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 23:09 [PATCH 21.11 v1] event/dlb2: handle enqueuing more than maximum depth Abdullah Sevincer
2022-11-01 14:53 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).