From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 142A8A00C2 for ; Thu, 3 Nov 2022 10:29:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1031A40694; Thu, 3 Nov 2022 10:29:20 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id B01C440693 for ; Thu, 3 Nov 2022 10:29:18 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id n39-20020a05600c3ba700b003cf71011cddso3314569wms.1 for ; Thu, 03 Nov 2022 02:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZUpETQ4m30ZCuQyRVM0I09HieVWLu5ibBQjU8Lx8R2k=; b=nAmF1RNOyatLMqD1Dq5sV8VhNPpEa/3+ZttWw7P0NzxvpsdN05Zsh7uKWuyMLdNMSG /xfmJWqp0vASGYbHRpgLfb5G3pV5x+6lEj2nkaErfy/gT+hkSN/Bsr79Sx127TUwrVvJ igq86iY4goMkODpToN855tF9JfKN/l6/yMMq0duKZ9NKsAGQPNDS+z0XJ2AzMqklXm0p eIX2NXRlWQFRdEF769FbR3ouKjK+3OJGuWFrHOIVi6V5AtQs5EGOp8O2wzxMqsgWnBlG jQsQmckIMqblLH3NxBWuvihg1WP/tD2ZdvTpl3mgPAbbAVmi72eTEBOTuEr059j+JlaY hgrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZUpETQ4m30ZCuQyRVM0I09HieVWLu5ibBQjU8Lx8R2k=; b=A5Cqsquo5tl4HltlDwZqavIsSv7B0MnkR3QT1tmg/0G3Av5IE2xBPjcau7XowO7gUv 3UYpgssfWV/GnL6XsVXQjMGF7/AajNjQm24DkI2E1MTyhMf3gQyuXjX6LsXp6yhviC/k wqbndmSxeSyFcMOi16AwKoLlRsCk4E64xBhpQ/QppmF37PEPa0nYUalUmIEF9JC0yTTS QUzFfq/IzGZMKoWxmuZ1O+vljaTVx/8NIuhoY8tMJfOg+y2n73uEM4RlCGT+r+zGnQDW epxPopRjNaOZ3l6uNExuqWUA9K7/kVbUwtngukCs8IycovLsE/qBQM5+cGiHFh6sF25S Y0pg== X-Gm-Message-State: ACrzQf0i+Ta5UjuF8cmg3OaOAjIhBf6H7QGRFChm9uVD5UD60SRowAVR LNZORscPmRKFBjwdn/zrmDzfC6WA/3Ngag== X-Google-Smtp-Source: AMsMyM41Y7diApDdsOMS3atMjIFe8XZn/n/19li3V/aN8e5VL9X/yjUvF7wzk0auZNh5T8de0fFXpA== X-Received: by 2002:a1c:a4c5:0:b0:3cf:56dc:fd14 with SMTP id n188-20020a1ca4c5000000b003cf56dcfd14mr18010756wme.180.1667467758417; Thu, 03 Nov 2022 02:29:18 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003b4ff30e566sm5969115wmq.3.2022.11.03.02.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 02:29:17 -0700 (PDT) From: luca.boccassi@gmail.com To: Naga Harish K S V Cc: Jay Jayatheerthan , dpdk stable Subject: patch 'eventdev/eth_tx: fix adapter stop' has been queued to stable release 20.11.7 Date: Thu, 3 Nov 2022 09:26:39 +0000 Message-Id: <20221103092758.1099402-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/47e1c3c0e6b05ae3c0de3fd0f0cee3e9e3677d9b Thanks. Luca Boccassi --- >From 47e1c3c0e6b05ae3c0de3fd0f0cee3e9e3677d9b Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Mon, 25 Jul 2022 23:22:11 -0500 Subject: [PATCH] eventdev/eth_tx: fix adapter stop [ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] adapter_stop function is stopping the adapter service using rte_service_runstate_set() API and waiting until rte_service_may_be_active() API returns stopped state in an infinite loop. This results in hang issues if application calls rte_service_lcore_stop() before adapter stop. Remove the state check after setting the service state which avoids running into hang issues. This also makes Tx adapter stop inline with remaining adapters. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/librte_eventdev/rte_event_eth_tx_adapter.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c index c7048f8f36..20470d8a58 100644 --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c @@ -475,10 +475,6 @@ txa_service_ctrl(uint8_t id, int start) ret = rte_service_runstate_set(txa->service_id, start); rte_spinlock_unlock(&txa->tx_lock); - if (ret == 0 && !start) { - while (rte_service_may_be_active(txa->service_id)) - rte_pause(); - } return ret; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-03 09:27:26.728058380 +0000 +++ 0021-eventdev-eth_tx-fix-adapter-stop.patch 2022-11-03 09:27:25.329421589 +0000 @@ -1 +1 @@ -From fbb9f7e215c3394681ab1292f421c4e5c4880392 Mon Sep 17 00:00:00 2001 +From 47e1c3c0e6b05ae3c0de3fd0f0cee3e9e3677d9b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ - lib/eventdev/rte_event_eth_tx_adapter.c | 4 ---- + lib/librte_eventdev/rte_event_eth_tx_adapter.c | 4 ---- @@ -27,5 +28,5 @@ -diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c -index aa7713bfa1..7e82fe030c 100644 ---- a/lib/eventdev/rte_event_eth_tx_adapter.c -+++ b/lib/eventdev/rte_event_eth_tx_adapter.c -@@ -509,10 +509,6 @@ txa_service_ctrl(uint8_t id, int start) +diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c +index c7048f8f36..20470d8a58 100644 +--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c ++++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c +@@ -475,10 +475,6 @@ txa_service_ctrl(uint8_t id, int start)