From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3079DA00C2 for ; Thu, 3 Nov 2022 10:29:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C55040694; Thu, 3 Nov 2022 10:29:42 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id B924E40693 for ; Thu, 3 Nov 2022 10:29:40 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso2857899wme.5 for ; Thu, 03 Nov 2022 02:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VnSX00jH5K5PrARjUhq6jkWwU8X2IuyEORriGkTIuT8=; b=mMB0QWaIdY80ruppCZ+q8GzFLhqJDlsx0SH38dPKRTEZneYqmyvsJkrtaaGjYpm8bk T8C74i5Sha7H5XYLfMOnKjejNYZsl3AHkwAYtAI1DDU7Ik5X+h7pR1+yZeaqQwexI9fh gVQNNcvcrn73XuWCZVXQgF4Jo7jIvpNEn8drN4gFbwLANGYA0UMhp60deD96q+nQYy/u 2tcqlK6J0xaOS24R/CXpYlJaqF6SMxuyiofI979V6M1Bk/sHxIGF221VTY0Anods32wz 2QNKa3frjtDZW6z2Ey9e4z+DUJxykngMYfEx110xQTPQRMDQ7R0BYghTcfdBJfhAaidd J5PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VnSX00jH5K5PrARjUhq6jkWwU8X2IuyEORriGkTIuT8=; b=m2cq92S0u3O5Jl8+F8DESoCVqHuPQQDUAbOvOB79mOZulukNRDQVi/mCV4uaYTHXsC 0W9SjVhQkiHh5uaWwkPNlGojVhAz7a4vIfLvT3Us4xcMJyX/Kv+6SAj87mHR7ontyxqa YpNnqoKa4ONkMENnj+5vmfCENufyycoWxswIy0ocuikIxDZUeHvYaGI6SfTY/qTmhKwt ESbsqTeND4ok6tcGyZr41/+S+fWsJaptM8inQyC7P6EpVB/7PpbOFmBEfCJZfRfHB3Ax hcAz/tIEl0yBl/FggTSi7XHVjcpoJ6lClc6jQGrzgvHEVfZYrexvru9LbHG9KUgvhWvR 2CBA== X-Gm-Message-State: ACrzQf1yX2FPWJOXgzPt3/euQPWXjN6RG/dH+Vjk6WlTfYCjnOyXEOyc MxdeZThxTUuTFLUkkVTp7ELU2ZEiCqfrRBha X-Google-Smtp-Source: AMsMyM4Kv8aUAiFFIkfTzIw1jnUj38ZnK2vfXgmqRnV62yTUHmdTOdLmPmeaHWYSyNChbNm1pXQ88A== X-Received: by 2002:a05:600c:3d08:b0:3c6:fb56:ac9f with SMTP id bh8-20020a05600c3d0800b003c6fb56ac9fmr29362645wmb.193.1667467780455; Thu, 03 Nov 2022 02:29:40 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id q11-20020adfdfcb000000b002366e8eee11sm325169wrn.101.2022.11.03.02.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 02:29:39 -0700 (PDT) From: luca.boccassi@gmail.com To: Ke Zhang Cc: Yuying Zhang , dpdk stable Subject: patch 'net/i40e: fix VF representor release' has been queued to stable release 20.11.7 Date: Thu, 3 Nov 2022 09:26:47 +0000 Message-Id: <20221103092758.1099402-29-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2727671dc9f52bce9c4f70eabd7787073dafcbca Thanks. Luca Boccassi --- >From 2727671dc9f52bce9c4f70eabd7787073dafcbca Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Thu, 4 Aug 2022 17:50:03 +0800 Subject: [PATCH] net/i40e: fix VF representor release [ upstream commit ba10df53e486ef7918c1236ef4d8da16ae3a32e1 ] A segmentation fault occurs when testpmd exit. This is due to fetching the device name from PF, PF is freed firstly and then VF representor is called later. This commit fixes the bug by fetching the device name from VF representor instead of PF. Fixes: e391a7b7f815 ("net/i40e: fix multi-process shared data") Signed-off-by: Ke Zhang Acked-by: Yuying Zhang --- drivers/net/i40e/i40e_vf_representor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c index 5daa7ddcfd..4f59d80ac3 100644 --- a/drivers/net/i40e/i40e_vf_representor.c +++ b/drivers/net/i40e/i40e_vf_representor.c @@ -29,8 +29,6 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, struct rte_eth_dev_info *dev_info) { struct i40e_vf_representor *representor = ethdev->data->dev_private; - struct rte_eth_dev_data *pf_dev_data = - representor->adapter->pf.dev_data; /* get dev info for the vdev */ dev_info->device = ethdev->device; @@ -102,7 +100,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, }; dev_info->switch_info.name = - rte_eth_devices[pf_dev_data->port_id].device->name; + rte_eth_devices[ethdev->data->port_id].device->name; dev_info->switch_info.domain_id = representor->switch_domain_id; dev_info->switch_info.port_id = representor->vf_id; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-03 09:27:27.185455482 +0000 +++ 0029-net-i40e-fix-VF-representor-release.patch 2022-11-03 09:27:25.365422286 +0000 @@ -1 +1 @@ -From ba10df53e486ef7918c1236ef4d8da16ae3a32e1 Mon Sep 17 00:00:00 2001 +From 2727671dc9f52bce9c4f70eabd7787073dafcbca Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba10df53e486ef7918c1236ef4d8da16ae3a32e1 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index cc0f992453..c00ae832aa 100644 +index 5daa7ddcfd..4f59d80ac3 100644 @@ -37 +38 @@ -@@ -104,7 +102,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, +@@ -102,7 +100,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,