From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41ACCA00C2 for ; Thu, 3 Nov 2022 10:31:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C07F40694; Thu, 3 Nov 2022 10:31:36 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 819F640694 for ; Thu, 3 Nov 2022 10:31:34 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id o4so1723431wrq.6 for ; Thu, 03 Nov 2022 02:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lUPE+kMPiqhUfRzhME1Y9IUD2uz18oNO/KcniG685sw=; b=MdWSWGzMNPR0W0lkE/VR/w8VlOYgIhi2dnCcUOiQDIOhEdK+d5RYM7mjXuiawDTkNc U2L43mTr0kMVapfYRUPiCBYk3C9Lb9QI3gNmU7vQ8t1PyTdjQeiDcKT3CI1d7//URU/c U36kWMpYRAHWgPs3lbThdyuu4DQKwQOcM3WqqAGqbfTrVKVdo/hgRiqJ7OBS1XOTRSFY cOQq+ir0Tk4kBGn8e8sPkWuaFZ1BCdpKtTEGL9edaKOvTLW9e7+OWWTtZs67QRRopChj mZ66o5FUEe9cYal3MinH2iRYysc9V6Drq43Xyv6dOO9tzVzhfP9uCwZjwrgWFsqpSYfN HPSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lUPE+kMPiqhUfRzhME1Y9IUD2uz18oNO/KcniG685sw=; b=bXw/QYjI/8C5ouVd0sCwJ6cWVT6PRmXwjX2RKEel+6EiTkxHEJ/Zmwgyq2l8uWZvr0 i1eCgZvqgRmewZz+2K9DgPt5boii01VLmlQO0ySCeg2EPK2MjFnB8qI9A76y9AdnYGHQ LhzgduZ/WAZOx3AwFo/lIBW+8sKqXzwjuMgmA11EliEBIKUT09mIeOveu8+/nsjiVxDx LoAL/nkENEeDzAzK5ZGb+mVRTYMSgLfMRyFPj9TCSpJ7v+z0/cBSRdN1eO2sdXg9W2W8 bZLm1D8S81zyk6sRDa0ebyxfX4uiVNAuVZr61hvJnNjhgmoqTXtvDdM9Cao05KGWjQ0m 7GCg== X-Gm-Message-State: ACrzQf0lA8eladMMZOgmU0VOL1ZZnhGcOgi8cSp/SGhn6SK38FuXw8uN hhLiyeWTcNO/B/cd71GJZ3U= X-Google-Smtp-Source: AMsMyM7BgtZpKFm6cTnZewR27t5dhnJaFwVJPuGBO6lRXRqIikTbi+Dm6wqdHkUURH3k3uoO35luEQ== X-Received: by 2002:adf:d1ca:0:b0:236:737f:8dfa with SMTP id b10-20020adfd1ca000000b00236737f8dfamr18234382wrd.588.1667467894195; Thu, 03 Nov 2022 02:31:34 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id o38-20020a05600c512600b003cf4eac8e80sm879414wms.23.2022.11.03.02.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 02:31:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Olivier Matz Cc: Honnappa Nagarahalli , dpdk stable Subject: patch 'mem: fix API doc about allocation on secondary processes' has been queued to stable release 20.11.7 Date: Thu, 3 Nov 2022 09:27:20 +0000 Message-Id: <20221103092758.1099402-62-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5e0e9abbdbcb495983405ffeb70d4fa98e759615 Thanks. Luca Boccassi --- >From 5e0e9abbdbcb495983405ffeb70d4fa98e759615 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Thu, 29 Sep 2022 14:23:11 +0200 Subject: [PATCH] mem: fix API doc about allocation on secondary processes [ upstream commit d5262b521d096349e9e96b436f90eee6554ba595 ] Since 10 years, memzone allocation is allowed on secondary processes. Now it's time to update the documentation accordingly. At the same time, fix mempool, mbuf and ring documentation which rely on memzones internally. Bugzilla ID: 1074 Fixes: 916e4f4f4e45 ("memory: fix for multi process support") Signed-off-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/include/rte_memzone.h | 3 --- lib/librte_mbuf/rte_mbuf.h | 3 --- lib/librte_mempool/rte_mempool.h | 1 - lib/librte_ring/rte_ring.h | 1 - lib/librte_ring/rte_ring_elem.h | 1 - 5 files changed, 9 deletions(-) diff --git a/lib/librte_eal/include/rte_memzone.h b/lib/librte_eal/include/rte_memzone.h index 5db1210831..bb4223a056 100644 --- a/lib/librte_eal/include/rte_memzone.h +++ b/lib/librte_eal/include/rte_memzone.h @@ -118,7 +118,6 @@ struct rte_memzone { * on error. * On error case, rte_errno will be set appropriately: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists * - ENOMEM - no appropriate memory area found in which to create memzone @@ -184,7 +183,6 @@ const struct rte_memzone *rte_memzone_reserve(const char *name, * on error. * On error case, rte_errno will be set appropriately: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists * - ENOMEM - no appropriate memory area found in which to create memzone @@ -256,7 +254,6 @@ const struct rte_memzone *rte_memzone_reserve_aligned(const char *name, * on error. * On error case, rte_errno will be set appropriately: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists * - ENOMEM - no appropriate memory area found in which to create memzone diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index bcd8b743a7..d0794623c6 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -685,7 +685,6 @@ void rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg); * The pointer to the new allocated mempool, on success. NULL on error * with rte_errno set appropriately. Possible rte_errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - cache size provided is too large, or priv_size is not aligned. * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists @@ -727,7 +726,6 @@ rte_pktmbuf_pool_create(const char *name, unsigned n, * The pointer to the new allocated mempool, on success. NULL on error * with rte_errno set appropriately. Possible rte_errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - cache size provided is too large, or priv_size is not aligned. * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists @@ -781,7 +779,6 @@ struct rte_pktmbuf_extmem { * The pointer to the new allocated mempool, on success. NULL on error * with rte_errno set appropriately. Possible rte_errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - cache size provided is too large, or priv_size is not aligned. * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 9c990a5593..7516d90824 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/lib/librte_mempool/rte_mempool.h @@ -993,7 +993,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *); * The pointer to the new allocated mempool, on success. NULL on error * with rte_errno set appropriately. Possible rte_errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - cache size provided is too large * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index da17ed6d7c..937cfbb7a0 100644 --- a/lib/librte_ring/rte_ring.h +++ b/lib/librte_ring/rte_ring.h @@ -164,7 +164,6 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, * On success, the pointer to the new allocated ring. NULL on error with * rte_errno set appropriately. Possible errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - count provided is not a power of 2 * - ENOSPC - the maximum number of memzones has already been allocated * - EEXIST - a memzone with the same name already exists diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_elem.h index 0057da3597..b79ba5cb7f 100644 --- a/lib/librte_ring/rte_ring_elem.h +++ b/lib/librte_ring/rte_ring_elem.h @@ -95,7 +95,6 @@ ssize_t rte_ring_get_memsize_elem(unsigned int esize, unsigned int count); * On success, the pointer to the new allocated ring. NULL on error with * rte_errno set appropriately. Possible errno values include: * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure - * - E_RTE_SECONDARY - function was called from a secondary process instance * - EINVAL - esize is not a multiple of 4 or count provided is not a * power of 2. * - ENOSPC - the maximum number of memzones has already been allocated -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-03 09:27:29.141810098 +0000 +++ 0062-mem-fix-API-doc-about-allocation-on-secondary-proces.patch 2022-11-03 09:27:25.481424532 +0000 @@ -1 +1 @@ -From d5262b521d096349e9e96b436f90eee6554ba595 Mon Sep 17 00:00:00 2001 +From 5e0e9abbdbcb495983405ffeb70d4fa98e759615 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d5262b521d096349e9e96b436f90eee6554ba595 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19,5 +20,5 @@ - lib/eal/include/rte_memzone.h | 3 --- - lib/mbuf/rte_mbuf.h | 3 --- - lib/mempool/rte_mempool.h | 1 - - lib/ring/rte_ring.h | 1 - - lib/ring/rte_ring_elem.h | 1 - + lib/librte_eal/include/rte_memzone.h | 3 --- + lib/librte_mbuf/rte_mbuf.h | 3 --- + lib/librte_mempool/rte_mempool.h | 1 - + lib/librte_ring/rte_ring.h | 1 - + lib/librte_ring/rte_ring_elem.h | 1 - @@ -26 +27 @@ -diff --git a/lib/eal/include/rte_memzone.h b/lib/eal/include/rte_memzone.h +diff --git a/lib/librte_eal/include/rte_memzone.h b/lib/librte_eal/include/rte_memzone.h @@ -28,2 +29,2 @@ ---- a/lib/eal/include/rte_memzone.h -+++ b/lib/eal/include/rte_memzone.h +--- a/lib/librte_eal/include/rte_memzone.h ++++ b/lib/librte_eal/include/rte_memzone.h @@ -54,5 +55,5 @@ -diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h -index 9811e8c760..b6e23d98ce 100644 ---- a/lib/mbuf/rte_mbuf.h -+++ b/lib/mbuf/rte_mbuf.h -@@ -664,7 +664,6 @@ void rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg); +diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h +index bcd8b743a7..d0794623c6 100644 +--- a/lib/librte_mbuf/rte_mbuf.h ++++ b/lib/librte_mbuf/rte_mbuf.h +@@ -685,7 +685,6 @@ void rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg); @@ -66 +67 @@ -@@ -706,7 +705,6 @@ rte_pktmbuf_pool_create(const char *name, unsigned n, +@@ -727,7 +726,6 @@ rte_pktmbuf_pool_create(const char *name, unsigned n, @@ -74 +75 @@ -@@ -760,7 +758,6 @@ struct rte_pktmbuf_extmem { +@@ -781,7 +779,6 @@ struct rte_pktmbuf_extmem { @@ -82,5 +83,5 @@ -diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h -index a3c4ee351d..4c4af2a8ed 100644 ---- a/lib/mempool/rte_mempool.h -+++ b/lib/mempool/rte_mempool.h -@@ -1023,7 +1023,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *); +diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h +index 9c990a5593..7516d90824 100644 +--- a/lib/librte_mempool/rte_mempool.h ++++ b/lib/librte_mempool/rte_mempool.h +@@ -993,7 +993,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *); @@ -91 +92 @@ - * - EINVAL - cache size provided is too large or an unknown flag was passed + * - EINVAL - cache size provided is too large @@ -94,5 +95,5 @@ -diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h -index 980e92e594..7c48e35d27 100644 ---- a/lib/ring/rte_ring.h -+++ b/lib/ring/rte_ring.h -@@ -180,7 +180,6 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, +diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h +index da17ed6d7c..937cfbb7a0 100644 +--- a/lib/librte_ring/rte_ring.h ++++ b/lib/librte_ring/rte_ring.h +@@ -164,7 +164,6 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, @@ -106,5 +107,5 @@ -diff --git a/lib/ring/rte_ring_elem.h b/lib/ring/rte_ring_elem.h -index fb1edc9aad..7f7d4951d3 100644 ---- a/lib/ring/rte_ring_elem.h -+++ b/lib/ring/rte_ring_elem.h -@@ -96,7 +96,6 @@ ssize_t rte_ring_get_memsize_elem(unsigned int esize, unsigned int count); +diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_elem.h +index 0057da3597..b79ba5cb7f 100644 +--- a/lib/librte_ring/rte_ring_elem.h ++++ b/lib/librte_ring/rte_ring_elem.h +@@ -95,7 +95,6 @@ ssize_t rte_ring_get_memsize_elem(unsigned int esize, unsigned int count);