From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 387FDA00C2 for ; Thu, 3 Nov 2022 10:31:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 341B940694; Thu, 3 Nov 2022 10:31:53 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id 1729D40694 for ; Thu, 3 Nov 2022 10:31:51 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id w14so1711829wru.8 for ; Thu, 03 Nov 2022 02:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=obsokT+2aBIaUGEkGMOlPIN0v28uGoNNgmXCGMJZUI4=; b=bssivFPq/92uhHdfoVtfmzbmkIECuGCtibWGeSFkYj+uGt8u31mxdQ6VWVHjqNXYjq i38NKKJSb3WCFt6xHKmtcfWRD1PrykCn083hPC4gm3Nex4KluTE+YrL5yiSg/qL2Kc6j KMopukQ5z+A05aiF7FKGmKO/W+bjFu+eX7RTgsR7CObCRWtA8dx6xtOb/MpaN5jvNI3N QOrjLKKgKrhNAIbJnaTTAcuCBtUfUPoQ4/R8GaEw68FKSlpZBUFO9n3AzrMnBVwAv9PN /PaOkLhmsCzgpXlfbvmhXtEzKomklx970asw6J2UuG9zJq2S6qQ/iM2c4eo9o9qpo7tj wEzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=obsokT+2aBIaUGEkGMOlPIN0v28uGoNNgmXCGMJZUI4=; b=3qbx8SEaQDoOsnDrRCntdnyFMsEPir1VvetQ0h4S9A258cF3Q5Kj3EyHlIP8V8SCU3 MaM/foezLU2yzkmwGhGqTXue1LvSoPjDDzY6cH0B7jTBEDVE0KmXXGwjGj7wjAl1ru2C fWVjm9zqv9wI81DBnlNLGgCCkcoOvfnD9Pf309j/5qPGbOH7o+OnGrTKTFLrGwtj+P56 CcJKkEWzDN2BpIxBgRC2yZFRsJrCQNGiAKc/9bBh1k68bzhrH6NaeKywDrxwrzmGsKco lO3DD7niBKjH81vRy3i5/fWrFLxGi3rM5j1nAwguI2+44iBf6CVdRJf2QIqziA5kMT0M 6Gsw== X-Gm-Message-State: ACrzQf1nR0o5+TnL0XQPo5koc8GxuyZ41j2wlAJcEZO3krh6CncTrXgv FaKAicDcxUagsBJXoih56iYVI6HIk3EDKkjC X-Google-Smtp-Source: AMsMyM49SwRvozWZkedHm0mfdmB1uhoCAcC6Gk9LY4oM2LtePulIlsVt/oI/+Lb26aiVlrA6UDCW6g== X-Received: by 2002:adf:e84f:0:b0:235:d53a:2d7f with SMTP id d15-20020adfe84f000000b00235d53a2d7fmr18399041wrn.334.1667467910821; Thu, 03 Nov 2022 02:31:50 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id m4-20020adfe0c4000000b0022dc6e76bbdsm348437wri.46.2022.11.03.02.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 02:31:50 -0700 (PDT) From: luca.boccassi@gmail.com To: Amit Prakash Shukla Cc: Thomas Monjalon , dpdk stable Subject: patch 'net/qede/base: fix 32-bit build with GCC 12' has been queued to stable release 20.11.7 Date: Thu, 3 Nov 2022 09:27:25 +0000 Message-Id: <20221103092758.1099402-67-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/92baf3027ef00f49a994a068d39627b917996d37 Thanks. Luca Boccassi --- >From 92baf3027ef00f49a994a068d39627b917996d37 Mon Sep 17 00:00:00 2001 From: Amit Prakash Shukla Date: Wed, 24 Aug 2022 19:33:39 +0530 Subject: [PATCH] net/qede/base: fix 32-bit build with GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit acc0ed087cd1ce6464f63489ab17eca52b0c94b2 ] A pointer is passed to a macro and it seems mistakenly referenced. This issue is seen only when compiling with GCC 12 for 32-bit: drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25: error: array subscript 1 is outside array bounds of ‘u32[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] 1418 | ecore_wr(dev, ptt, ((addr) + (4 * i)), \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1419 | ((u32 *)&(arr))[i]); \ | ~~~~~~~~~~~~~~~~~~~ drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17: note: in expansion of macro ‘ARR_REG_WR’ 1465 | ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords); | ^~~~~~~~~~ drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35: note: at offset 4 into object ‘pData’ of size 4 1439 | u32 *pData, | ~~~~~^~~~~ Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0") Signed-off-by: Amit Prakash Shukla Acked-by: Thomas Monjalon --- drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c index 6a52f32cc9..4e4d1dc374 100644 --- a/drivers/net/qede/base/ecore_init_fw_funcs.c +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c @@ -1416,7 +1416,7 @@ void ecore_init_brb_ram(struct ecore_hwfn *p_hwfn, u32 i; \ for (i = 0; i < (arr_size); i++) \ ecore_wr(dev, ptt, ((addr) + (4 * i)), \ - ((u32 *)&(arr))[i]); \ + ((u32 *)(arr))[i]); \ } while (0) #ifndef DWORDS_TO_BYTES -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-03 09:27:29.417471004 +0000 +++ 0067-net-qede-base-fix-32-bit-build-with-GCC-12.patch 2022-11-03 09:27:25.489424686 +0000 @@ -1 +1 @@ -From acc0ed087cd1ce6464f63489ab17eca52b0c94b2 Mon Sep 17 00:00:00 2001 +From 92baf3027ef00f49a994a068d39627b917996d37 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit acc0ed087cd1ce6464f63489ab17eca52b0c94b2 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org