From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CD28A00C2 for ; Thu, 3 Nov 2022 10:33:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 299CA427EC; Thu, 3 Nov 2022 10:33:03 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id 1439A427EC for ; Thu, 3 Nov 2022 10:33:02 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id l14so1753358wrw.2 for ; Thu, 03 Nov 2022 02:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YER5NVHPMzs7pBPYzmC5fgBqB+lpPSchDbmuN4XO7ZM=; b=doZaTXBwldLVvWe52Z/BV5pa96IPV4yWWBtStSHTGziKEzmmmTv3TXn0YxNueP62Px EEdHqn/3wLcg4YfTFlHdWJX3Z2JeV+A3WkJfI3GYOIyubQVqxdSUuawooBBJESCbEBa9 +UfynfMUxZpJZgVqBIO4MZhHcyn5LPWEg3i6sV8qbPMT+GV05KR1o6u6Pw1Awv4Q6sAL IPXtZO4jvQxjOLWIIWsE6vAQsoAtGllCL9ueDFHL12X3xPiZAl36G35oJ6XmAycRzLG6 0JXfa4oETjTLNaXhMuEb0Zin/bUQ9MxFXfXTNN3+92ALg2r2VzokjbYuSD8HJBo35QeO bKEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YER5NVHPMzs7pBPYzmC5fgBqB+lpPSchDbmuN4XO7ZM=; b=QluU5yUrbyskHrU7gXtNMgaiIl5PRPNpFdfHI0v6FKSztCWO/YSv1G6Nbdecbh5YLz bUjnWwpjmUMuZG/l0GFk6CuepSzgQQf0SQmPowpS2481EWXbqjo3Kn4H4ZcvXYIh786P o9jZ5rRha97lI+i+/20KmrXjWqPvgUyum2nSWb/pAeEaZwLrQT0DDr5VImS+GZ2gQh/+ jXAO6IK4MwPH5uIeCLnquTIN1CtUc6ItAJaz65w6iuWmcMoNGP/oV8wTB29qvRKt+TsD Pds8IISHMMbSoT8TrHpbjPay/7LzaWoO9BjfLJ8iHPfGVmV7lQzqBTX4LVYqzbSeTXEy vt1w== X-Gm-Message-State: ACrzQf2qrJmecENQV7OGjiXFZvoQ3b9JhrAE5TOLrQOyqwbVu1W8Bj6E SqIjXms47V/ZwWbBTPJ/6ywfDjYRAUuX0YZY X-Google-Smtp-Source: AMsMyM4WI9F0GpPjKI4qXb6n5bBGhqBwY6A+jANQNz91c4KTLTMLiy36dI36viTfHlUoShuJwqGOCQ== X-Received: by 2002:adf:f14a:0:b0:238:d040:f707 with SMTP id y10-20020adff14a000000b00238d040f707mr647342wro.611.1667467981755; Thu, 03 Nov 2022 02:33:01 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id z18-20020a5d44d2000000b002365254ea42sm399989wrr.1.2022.11.03.02.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 02:33:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix VF mailbox message handling' has been queued to stable release 20.11.7 Date: Thu, 3 Nov 2022 09:27:48 +0000 Message-Id: <20221103092758.1099402-90-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c24c705ee88adc9bf573c01443a2d2f0818721c0 Thanks. Luca Boccassi --- >From c24c705ee88adc9bf573c01443a2d2f0818721c0 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 30 Sep 2022 15:22:19 +0800 Subject: [PATCH] net/hns3: fix VF mailbox message handling [ upstream commit bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a ] VF's command receive queue was mainly used to receive mailbox messages from PF. There are two type mailbox messages: request response message and message pushed by PF. There are two types of threads that can handle these messages: 1) the interrupt thread of the main process: it could handle both types of messages. 2) other threads: it could only handle request response messages. The collaboration mechanism between the two type threads is that other threads set the opcode of processed messages to zero so that the interrupt thread of the main process does not process these messages again. Unfortunately, the other threads mark the message pointed to by the crq->next-to-use variable which is fixed in the loop, not the message pointed to by the next-to-use variable. Fixes: dbbbad23e380 ("net/hns3: fix VF handling LSC event in secondary process") Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c index e8d336f516..63ec11b838 100644 --- a/drivers/net/hns3/hns3_mbx.c +++ b/drivers/net/hns3/hns3_mbx.c @@ -435,7 +435,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw) * Clear opcode to inform intr thread don't process * again. */ - crq->desc[crq->next_to_use].opcode = 0; + crq->desc[next_to_use].opcode = 0; } scan_next: -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-03 09:27:30.973946177 +0000 +++ 0090-net-hns3-fix-VF-mailbox-message-handling.patch 2022-11-03 09:27:25.549425848 +0000 @@ -1 +1 @@ -From bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a Mon Sep 17 00:00:00 2001 +From c24c705ee88adc9bf573c01443a2d2f0818721c0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 910a16c999..8e0a58aa02 100644 +index e8d336f516..63ec11b838 100644 @@ -37 +38 @@ -@@ -429,7 +429,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw) +@@ -435,7 +435,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)