From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 2/2] test/hash: fix coverity warning
Date: Thu, 3 Nov 2022 11:33:00 -0700 [thread overview]
Message-ID: <20221103113300.29d85c26@hermes.local> (raw)
In-Reply-To: <20221103181339.1135127-1-vladimir.medvedkin@intel.com>
On Thu, 3 Nov 2022 18:13:38 +0000
Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
> + if (ret != 0) {
> + printf("rte_hash_lookup_with_hash_bulk"
> + " failed with %d\n", ret);
> + return -1;
> + }
It makes it harder to search for error messages when they are split.
Ignore any checkpatch warnings about this.
Also, shouldn't test failures be printed on stderr rather than stdout?
next prev parent reply other threads:[~2022-11-03 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 18:13 Vladimir Medvedkin
2022-11-03 18:33 ` Stephen Hemminger [this message]
2022-11-03 18:52 ` Medvedkin, Vladimir
2022-11-03 18:52 ` [PATCH v2] " Vladimir Medvedkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103113300.29d85c26@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).