From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79AD6A0543 for ; Sat, 5 Nov 2022 18:11:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65AD54067C; Sat, 5 Nov 2022 18:11:51 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 93169400D5 for ; Sat, 5 Nov 2022 18:11:50 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso4872068wmp.5 for ; Sat, 05 Nov 2022 10:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KEBQF40BSB7vM1mUQpSpzkuMDMX694pg2BrqStwUVB8=; b=UfqKDQqIY7cGqBw5IyCSKi44D6pj1gpZNwGstYdT2w2/i1ARcw2pP/36vXcSFfZB/F 8XeXZElFoSEOsq4/2Gd+sAzbiq6zl0k5nbln+flNLtcAZt3ZySw7Y9cgLapOElJfYcs2 pqj2DKX4NaeLB7Z+c+TRllWixZ3NhhR+oTOssf40ZWU06OKBBupjE7OMmVbRixDonXXt qPT5fOpwvuHxwpVvpxXcK5sTtsbUoFwJ218z3VQfcr+SHhexpiLS2lXSRz0Yj/vpr43Z Y8EtQxCDg6b+mUkguveJt9hXFu4Q/C9vKiqyrcs6gkaIjUJU58X3ZPSvLQeze92F70+2 lNuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KEBQF40BSB7vM1mUQpSpzkuMDMX694pg2BrqStwUVB8=; b=KevrYfEeValkrGjXWhacTdclPqHiP8U/QU85g3M2N198taVKO2u26XJZDXr50IFdH3 EEeS40qNTAdrQn0sOq+j+lEua27G0a8DCsSXApDOfANy3wrOlt3HV/FQdA702jC+z7Wl OHTV92Iu4LUrnX0dwBHZgkamXIHNKj0Y5SqRgJ5ZKvu5QTTDsQphZVUF7Ha5vfVO/9tO 0xgqfXD0I43b3DPfqTdgXIL896J42TBVl9XFTB/j6HYNvCvH+Znz1rYGvz9m8vMuIOca qIDQODkdhrjJnAdpmFPvEI+yardq8umPcnGXHeAd/hXAyXe/LyIAH9y7x4fV9SfgdCoP ZVEQ== X-Gm-Message-State: ACrzQf1XV/YreJNXhQ7blFgAP8vJalc2w65wYkWOXsXvRx9uAHxtiG5X 1ieIZiVcCbRdVw+7zurgNV8SwrOCcM8= X-Google-Smtp-Source: AMsMyM5iqQ2VCwSS5zt07N2+EEGPnWnlY/cjVfY2pKjzFoT3RO8VP+bIxDaSIo1CtZfcnhuGyaNV/Q== X-Received: by 2002:a05:600c:35cb:b0:3c6:e382:62fb with SMTP id r11-20020a05600c35cb00b003c6e38262fbmr26955294wmq.22.1667668310128; Sat, 05 Nov 2022 10:11:50 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id l22-20020a05600c089600b003c6bbe910fdsm7398914wmp.9.2022.11.05.10.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 10:11:49 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Jerin Jacob , Sunil Kumar Kori , dpdk stable Subject: patch 'trace: fix mode for new trace point' has been queued to stable release 20.11.7 Date: Sat, 5 Nov 2022 17:11:00 +0000 Message-Id: <20221105171146.1520039-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221103092758.1099402-100-luca.boccassi@gmail.com> References: <20221103092758.1099402-100-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/07/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8ca66f87baadda422b67d9265a1cafa1ec7b4da4 Thanks. Luca Boccassi --- >From 8ca66f87baadda422b67d9265a1cafa1ec7b4da4 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 15 Sep 2022 10:13:23 +0200 Subject: [PATCH] trace: fix mode for new trace point [ upstream commit 12b627bf772eb122ae195c297b08adcb92c8ac93 ] If an application registers trace points later than rte_eal_init(), changes in the trace point mode were not applied. Fixes: 84c4fae4628f ("trace: implement operation APIs") Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c index 24e27387b1..080278333d 100644 --- a/lib/librte_eal/common/eal_common_trace.c +++ b/lib/librte_eal/common/eal_common_trace.c @@ -513,6 +513,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name, /* Form the trace handle */ *handle = sz; *handle |= trace.nb_trace_points << __RTE_TRACE_FIELD_ID_SHIFT; + trace_mode_set(handle, trace.mode); trace.nb_trace_points++; tp->handle = handle; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-05 17:11:08.917725984 +0000 +++ 0001-trace-fix-mode-for-new-trace-point.patch 2022-11-05 17:11:08.550939979 +0000 @@ -1 +1 @@ -From 12b627bf772eb122ae195c297b08adcb92c8ac93 Mon Sep 17 00:00:00 2001 +From 8ca66f87baadda422b67d9265a1cafa1ec7b4da4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 12b627bf772eb122ae195c297b08adcb92c8ac93 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - lib/eal/common/eal_common_trace.c | 1 + + lib/librte_eal/common/eal_common_trace.c | 1 + @@ -19,5 +20,5 @@ -diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c -index f9b187d15f..d5dbc7d667 100644 ---- a/lib/eal/common/eal_common_trace.c -+++ b/lib/eal/common/eal_common_trace.c -@@ -512,6 +512,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name, +diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c +index 24e27387b1..080278333d 100644 +--- a/lib/librte_eal/common/eal_common_trace.c ++++ b/lib/librte_eal/common/eal_common_trace.c +@@ -513,6 +513,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,