From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AFF4A0543 for ; Sat, 5 Nov 2022 18:14:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5615042D30; Sat, 5 Nov 2022 18:14:09 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id CD239400D5 for ; Sat, 5 Nov 2022 18:14:08 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id a14so10887509wru.5 for ; Sat, 05 Nov 2022 10:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fBM3MZI4JJeDUZnZVYZQUcnai1ZPeaJ6X/STSGuKUXg=; b=dVRL9jE+7hlZeWJkwFmfQS2Sa/BP9tCX1eG5LYRYeWmtLGXQyycFtTE/q1NUjWa2LJ XVgrMrgKt21tEauhvxd950tESqH4U5hm70NMir8fC5VxfgZ+6zGy2hhihjSIwx9MRo3y kXLEXzI7HC36eouZsgfN7SE1x1PddMHDSNlEj1M/unyJRPpeykPgdBrGWhogXBX0YU7o E9iTAHC710blS7ZKY/jb1YQtT2Ql3xKOiLum4TrjLMdwQ51mHQe4kY/35kR9JU/uqsKt U+enJsY4N4TV1V9w2KdVCxK1bXhcU8o6G9waggSYYtY/Gaah6a1gKgRGQF0Nn0wAGjTb Twpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBM3MZI4JJeDUZnZVYZQUcnai1ZPeaJ6X/STSGuKUXg=; b=SmZ95hBdnQKdgHWYHFowP6I+u42x+7gtZUARg+njk5mouikdRuDakNwmqlIErrz+S8 uJn8yP2DaIDJ0H6CGhHY+JgdnX30xf51L7HDUqCHT92sA4DUmR6W0xaEkRmow2Eensuz 0VuanGp5wzUVcm3tn41PfemI91Kzaxphea1Lv58p1FzxhNFUmnPETFGfgjO0iTOojmEo Sv74QnI/yHwaZ5JrCBUlfXclpZaNqdyWZ4UiHqe/YgipyKeg4TprPZ897jBTXcOWcxb9 JYBUtILcMSJku65khuH2eYFQmKwZlA8/yMlBJK0alPAXA0LA8u4toa1Lj3C6RIXe2tFB bmcA== X-Gm-Message-State: ACrzQf2fN9QCKkgawbmG5vVZoZkROYsUt4azP2tNdZ9KKDwSruQM4ihf KlofYSTwwk1CHKpWI+C4oyc= X-Google-Smtp-Source: AMsMyM4pGPjWdi7TUv0MshZS2cVwphQVDTZg99ayM4pjJ2Hptv8iuHh6uGCH5fyrhftBi7IjgkaTtQ== X-Received: by 2002:adf:df83:0:b0:236:6d5d:ff8b with SMTP id z3-20020adfdf83000000b002366d5dff8bmr25997475wrl.315.1667668448610; Sat, 05 Nov 2022 10:14:08 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id s12-20020adfeb0c000000b0023657e1b980sm2614953wrn.53.2022.11.05.10.14.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 10:14:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc100: fix clearing PF IR outside handler' has been queued to stable release 20.11.7 Date: Sat, 5 Nov 2022 17:11:41 +0000 Message-Id: <20221105171146.1520039-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221105171146.1520039-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-100-luca.boccassi@gmail.com> <20221105171146.1520039-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/07/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cbcb14c99c4a4774ccd98bcd2c1072ddc99b15dd Thanks. Luca Boccassi --- >From cbcb14c99c4a4774ccd98bcd2c1072ddc99b15dd Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 20 Oct 2022 22:20:43 -0700 Subject: [PATCH] baseband/acc100: fix clearing PF IR outside handler [ upstream commit 935745f56b9bf37ebece351170b47d3e6c215bc9 ] Clearing of PF info ring outside of handler may cause interrupt to be missed. A condition in the ACC100 PMD implementation may cause an interrupt functional handler call to be missed due to related bit being cleared when checking PF info ring status. Fixes: 06531464151 ("baseband/acc100: support interrupt") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index a5bfb417de..c0c75bdc25 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -423,11 +423,12 @@ acc100_check_ir(struct acc100_device *acc100_dev) while (ring_data->valid) { if ((ring_data->int_nb < ACC100_PF_INT_DMA_DL_DESC_IRQ) || ( ring_data->int_nb > - ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) + ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) { rte_bbdev_log(WARNING, "InfoRing: ITR:%d Info:0x%x", ring_data->int_nb, ring_data->detailed_info); - /* Initialize Info Ring entry and move forward */ - ring_data->val = 0; + /* Initialize Info Ring entry and move forward */ + ring_data->val = 0; + } info_ring_head++; ring_data = acc100_dev->info_ring + (info_ring_head & ACC100_INFO_RING_MASK); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-05 17:11:12.397892286 +0000 +++ 0042-baseband-acc100-fix-clearing-PF-IR-outside-handler.patch 2022-11-05 17:11:08.830945991 +0000 @@ -1 +1 @@ -From 935745f56b9bf37ebece351170b47d3e6c215bc9 Mon Sep 17 00:00:00 2001 +From cbcb14c99c4a4774ccd98bcd2c1072ddc99b15dd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 935745f56b9bf37ebece351170b47d3e6c215bc9 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 7 ++++--- + drivers/baseband/acc100/rte_acc100_pmd.c | 7 ++++--- @@ -21,5 +22,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index 7ec63dc470..3bb93a1e07 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -262,11 +262,12 @@ acc100_check_ir(struct acc_device *acc100_dev) +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index a5bfb417de..c0c75bdc25 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -423,11 +423,12 @@ acc100_check_ir(struct acc100_device *acc100_dev) @@ -40 +41 @@ - (info_ring_head & ACC_INFO_RING_MASK); + (info_ring_head & ACC100_INFO_RING_MASK);