From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96E9CA0543 for ; Sat, 5 Nov 2022 18:14:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9326042D2E; Sat, 5 Nov 2022 18:14:12 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 8A70F42D32 for ; Sat, 5 Nov 2022 18:14:11 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id a14so10887598wru.5 for ; Sat, 05 Nov 2022 10:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IjXW1nkgVIHgd16lM1jXQ6OHwDZGGrehqZAWdTa0Bdw=; b=A1TGYPKIkgUtWQdI1m/TDF85z9qnLS0BxLGYImYI23JSPKfOzHIUMpuaPL94J22mSV B3EAYI9C0WnUYHBG8qwyYlCrQb0L1K2HG7JpLUkizfwFutYKj0c+Y5lEmRL1MvJecTsz QwrIOpo0FcYzBXVS+S7/UvbMJ781GHGuiib/U5bYkeSplwg5i02ZkqRCD6m+V2BkcMFT DFa0XBemWvcuE9COPnLiWBhQOvm35yP7FGTaO9U5nGb0r+FMCTM7A5nqPpO8yCq4k7E6 7jwnXZRSZcbQQ5hudzgarcURz8rMsFXT3bE55eSZNxDM/f65jk0i2GEUf/i3cypLr/0w 1mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IjXW1nkgVIHgd16lM1jXQ6OHwDZGGrehqZAWdTa0Bdw=; b=O4tB254GGD95DMlvHYSLseKTf/50ptDhwt0bAMZ6k6PWg7QtNWxNOkl+lZZQlzljtJ XkU7rhfzzRy3Yuwl67LD+7M+jE47xk/IhBJpvjhAJpGdNg1pp6DZMa9DpNPex3W8m9HM dKYSCcpT0b01GoOqgygafvM+ITGpjyJxwgsdi2zs5SSeHaMUIKQHBeO+vreOKkmPk99w 7obvB3IQJj1KJcmxYvZo23CHMhECcmBBs1KEmmm6WwgVosb+xHr8Z4YfHTEhdw0V6zfx /pX59B9HyuHwAoeOc9hNir7Si4Jxs5s2Rq/p4HEQpUJD6CA4EFIF4o9kU18iudvVwcUG iw3A== X-Gm-Message-State: ACrzQf0Al2VdQjdGlZ/QY3PcvJGMOttZVGpdWK4RUU3MU018OZPhdwJ1 L9z5N/TCks0kY+z3zQTYHbk= X-Google-Smtp-Source: AMsMyM65C//2ggo558QgzdW45xFcn9SmX4M+Ul6R7Xy0suTKvaXxIQpmsDnL8HQisaIGXZERP7KFTQ== X-Received: by 2002:a5d:5503:0:b0:236:1722:845d with SMTP id b3-20020a5d5503000000b002361722845dmr26610612wrv.351.1667668451256; Sat, 05 Nov 2022 10:14:11 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id z3-20020adff1c3000000b00236e834f050sm2570295wro.35.2022.11.05.10.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 10:14:10 -0700 (PDT) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc100: fix close cleanup' has been queued to stable release 20.11.7 Date: Sat, 5 Nov 2022 17:11:43 +0000 Message-Id: <20221105171146.1520039-44-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221105171146.1520039-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-100-luca.boccassi@gmail.com> <20221105171146.1520039-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/07/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e9703e47a796aa10a239d4555c56d27f8db9bb09 Thanks. Luca Boccassi --- >From e9703e47a796aa10a239d4555c56d27f8db9bb09 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 20 Oct 2022 22:20:46 -0700 Subject: [PATCH] baseband/acc100: fix close cleanup [ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ] Set local pointer to NULL after rte_free. This needs to be set explicitly since logic may check for null pointers. Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index d4bf1a4e92..6d02fd12a8 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -779,6 +779,9 @@ acc100_dev_close(struct rte_bbdev *dev) rte_free(d->info_ring); rte_free(d->sw_rings_base); d->sw_rings_base = NULL; + d->tail_ptrs = NULL; + d->info_ring = NULL; + d->harq_layout = NULL; } /* Ensure all in flight HW transactions are completed */ usleep(ACC100_LONG_WAIT); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-05 17:11:12.583209468 +0000 +++ 0044-baseband-acc100-fix-close-cleanup.patch 2022-11-05 17:11:08.842946248 +0000 @@ -1 +1 @@ -From ba2262fe16cade81a18b353d580ec4229e1020a6 Mon Sep 17 00:00:00 2001 +From e9703e47a796aa10a239d4555c56d27f8db9bb09 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ + drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++ @@ -18,5 +19,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index a711862892..ad815ed76a 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -618,6 +618,9 @@ acc100_dev_close(struct rte_bbdev *dev) +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index d4bf1a4e92..6d02fd12a8 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -779,6 +779,9 @@ acc100_dev_close(struct rte_bbdev *dev) @@ -31 +32 @@ - usleep(ACC_LONG_WAIT); + usleep(ACC100_LONG_WAIT);