From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D57D6A0543 for ; Sat, 5 Nov 2022 18:12:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6EF942D1C; Sat, 5 Nov 2022 18:12:12 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 1EBA0400D5 for ; Sat, 5 Nov 2022 18:12:12 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id bk15so10830165wrb.13 for ; Sat, 05 Nov 2022 10:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=okbtPvwS4IWLuQwTbagYkW8RFaZJqnQ2zzxH9bfOy9E=; b=n7+ecBFmEz0M7pehtZs2qfqNyiE/YhrcYOT5T2FXrduYsYtGAFd7LmeyxKbxy+uxA0 M6oLEXMYwzaGjj+yux+L7hqBT1c+4YXIqUp79YtODGL7Wkmrl22l5siThMDAHVCxI+H8 hqFr8CqeRc4Vu9Gs9IubuK15GZnDwVRUJjaA0rLpe/I4c9xodSyYhKF264ShDzohmG+w /zzCdnkYmdfliSYRUhC5TIC4jd2YQBfYNrFsah7OsofhJR0BW2+1DOca/lXeNkG0eZ6Y AABN3qSu7ld5R5YZyytpgLt+871CgjMvq+IbrA4GZVILH5uSjaqzWj/KQobWLAPQCPoq Z5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=okbtPvwS4IWLuQwTbagYkW8RFaZJqnQ2zzxH9bfOy9E=; b=Li64LPB2GCm5EYnWJ2PRh6xyrBbtXw4+tF0sNVNZNCJvptveHCIBFRzlr2aO/OdeLJ arimc8RzMwq1OjCW5B/5SRKefkpT4CtxcSBOwb8L9wol5mMw3Qpfy3w6iApHVRd1klK3 Y9xZTp/5HiQhTZiedUoTC+qtu9Joh+i4ydQyDuqXRPUgPJ6e9i5wOV9e/D5yTvjkGKfm MgVFZCztsGRwAyhImBUVz6xKt3upiRom0Ze9IIAR+wMRDxlNcv4oyf+LW2kR/k6xamfQ aqMPncP2QsQvF0NDG9m5ZOs32AbfzuOnk/4Uk3yltHvNshHnXJHmmeAsVnqCV6OqFjBa /vPA== X-Gm-Message-State: ACrzQf0YgWRu3dn56iDaMfNg4ZbRITKxL3uW/N5kSK6cfSoahE1+43lq /R+l7x8GaENEwM7RxazzACk= X-Google-Smtp-Source: AMsMyM5hzbmU39PLXVDdnqURc+FJsAToZkggdF/z1Xv/BSZM7PeEZxxG6RrENGX2cGJmxo0GsNGsTA== X-Received: by 2002:a5d:64ee:0:b0:236:8f54:f180 with SMTP id g14-20020a5d64ee000000b002368f54f180mr25287608wri.559.1667668331791; Sat, 05 Nov 2022 10:12:11 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id k19-20020a05600c1c9300b003cf4c1e211fsm3160207wms.38.2022.11.05.10.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 10:12:11 -0700 (PDT) From: luca.boccassi@gmail.com To: Olivier Matz Cc: David Marchand , dpdk stable Subject: patch 'event/sw: fix flow ID init in self test' has been queued to stable release 20.11.7 Date: Sat, 5 Nov 2022 17:11:08 +0000 Message-Id: <20221105171146.1520039-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221105171146.1520039-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-100-luca.boccassi@gmail.com> <20221105171146.1520039-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/07/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/63ec6a27e780e8e8d0397ecaf8e736d2e31219fb Thanks. Luca Boccassi --- >From 63ec6a27e780e8e8d0397ecaf8e736d2e31219fb Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Fri, 14 Oct 2022 22:37:09 +0200 Subject: [PATCH] event/sw: fix flow ID init in self test [ upstream commit ab059e82e12f2a9dc7561960004819de68b37110 ] The issue is seen by unit tests: MALLOC_PERTURB_=204 \ DPDK_TEST=eventdev_selftest_sw \ /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff (...) *** Running XStats ID Reset test... 12: 1761: qid_0_port_2_pinned_flows value , expected 1 got 7 1778: qid_0_port_2_pinned_flows value incorrect, expected 1 got 7 ERROR - XStats ID Reset test FAILED. SW Eventdev Selftest Failed. Test Failed The flow ID is not set in the event, which results in an undefined flow, whose value depends on what was previously in stack. Having different flows for the packets makes the test to fail, since only one flow is expected. This only happens in -O3, where the same stack area is shared by the event object and the address of the mbuf allocated in rte_gen_arp(). Fix this by properly initializing the flow id. Bugzilla ID: 1101 Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests") Signed-off-by: Olivier Matz Reviewed-by: David Marchand --- drivers/event/sw/sw_evdev_selftest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c index 782e76db5b..c2e1b8fd14 100644 --- a/drivers/event/sw/sw_evdev_selftest.c +++ b/drivers/event/sw/sw_evdev_selftest.c @@ -1488,6 +1488,7 @@ xstats_id_reset_tests(struct test *t) goto fail; } ev.queue_id = t->qid[i]; + ev.flow_id = 0; ev.op = RTE_EVENT_OP_NEW; ev.mbuf = arp; *rte_event_pmd_selftest_seqn(arp) = i; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-05 17:11:09.505137376 +0000 +++ 0009-event-sw-fix-flow-ID-init-in-self-test.patch 2022-11-05 17:11:08.586940752 +0000 @@ -1 +1 @@ -From ab059e82e12f2a9dc7561960004819de68b37110 Mon Sep 17 00:00:00 2001 +From 63ec6a27e780e8e8d0397ecaf8e736d2e31219fb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ab059e82e12f2a9dc7561960004819de68b37110 ] + @@ -31 +32,0 @@ -Cc: stable@dpdk.org @@ -40 +41 @@ -index 62d66744f2..9f27d8a189 100644 +index 782e76db5b..c2e1b8fd14 100644 @@ -43 +44 @@ -@@ -1483,6 +1483,7 @@ xstats_id_reset_tests(struct test *t) +@@ -1488,6 +1488,7 @@ xstats_id_reset_tests(struct test *t)