From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FE0BA0542 for ; Fri, 11 Nov 2022 11:34:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B4E440150; Fri, 11 Nov 2022 11:34:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EED0C40150 for ; Fri, 11 Nov 2022 11:34:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668162851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F2igp48lvUcwpfL2RGra2Q4aCeW/MynLjcQom9hLtGQ=; b=TX5TNXPvHF8iyWXT+OdtieKfTZ/axYgsFwjlGwozMmVvJ66E4L/P+hnstRzbx/7ToMoylT DRy9AQYdo1TDEIgdFOuLWn5UZ4M3v6VJlo5CNh1U3nxRU9dKln1aXxDWBaWETvEY4DEFXS Z+iWmBJ3RKIaQTI7/dzUoPJSMkfoKS0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-paLUE64hO0a0H9JgPhS4dg-1; Fri, 11 Nov 2022 05:34:08 -0500 X-MC-Unique: paLUE64hO0a0H9JgPhS4dg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D4D6800B23; Fri, 11 Nov 2022 10:34:07 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id A30C8200E288; Fri, 11 Nov 2022 10:34:06 +0000 (UTC) From: Kevin Traynor To: Olivier Matz Cc: David Marchand , dpdk stable Subject: patch 'event/sw: fix flow ID init in self test' has been queued to stable release 21.11.3 Date: Fri, 11 Nov 2022 10:32:51 +0000 Message-Id: <20221111103337.307408-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/14a1303083df525068a2b38745d4d55ea1f3f105 Thanks. Kevin --- >From 14a1303083df525068a2b38745d4d55ea1f3f105 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Fri, 14 Oct 2022 22:37:09 +0200 Subject: [PATCH] event/sw: fix flow ID init in self test [ upstream commit ab059e82e12f2a9dc7561960004819de68b37110 ] The issue is seen by unit tests: MALLOC_PERTURB_=204 \ DPDK_TEST=eventdev_selftest_sw \ /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff (...) *** Running XStats ID Reset test... 12: 1761: qid_0_port_2_pinned_flows value , expected 1 got 7 1778: qid_0_port_2_pinned_flows value incorrect, expected 1 got 7 ERROR - XStats ID Reset test FAILED. SW Eventdev Selftest Failed. Test Failed The flow ID is not set in the event, which results in an undefined flow, whose value depends on what was previously in stack. Having different flows for the packets makes the test to fail, since only one flow is expected. This only happens in -O3, where the same stack area is shared by the event object and the address of the mbuf allocated in rte_gen_arp(). Fix this by properly initializing the flow id. Bugzilla ID: 1101 Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests") Signed-off-by: Olivier Matz Reviewed-by: David Marchand --- drivers/event/sw/sw_evdev_selftest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c index cb97a4d615..0992687275 100644 --- a/drivers/event/sw/sw_evdev_selftest.c +++ b/drivers/event/sw/sw_evdev_selftest.c @@ -1489,4 +1489,5 @@ xstats_id_reset_tests(struct test *t) } ev.queue_id = t->qid[i]; + ev.flow_id = 0; ev.op = RTE_EVENT_OP_NEW; ev.mbuf = arp; -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 10:32:17.149830857 +0000 +++ 0001-event-sw-fix-flow-ID-init-in-self-test.patch 2022-11-11 10:32:16.985300410 +0000 @@ -1 +1 @@ -From ab059e82e12f2a9dc7561960004819de68b37110 Mon Sep 17 00:00:00 2001 +From 14a1303083df525068a2b38745d4d55ea1f3f105 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ab059e82e12f2a9dc7561960004819de68b37110 ] + @@ -31 +32,0 @@ -Cc: stable@dpdk.org @@ -40 +41 @@ -index 62d66744f2..9f27d8a189 100644 +index cb97a4d615..0992687275 100644 @@ -43 +44 @@ -@@ -1484,4 +1484,5 @@ xstats_id_reset_tests(struct test *t) +@@ -1489,4 +1489,5 @@ xstats_id_reset_tests(struct test *t)