From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C4F7A0542 for ; Fri, 11 Nov 2022 11:35:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5890140150; Fri, 11 Nov 2022 11:35:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9956E4014F for ; Fri, 11 Nov 2022 11:34:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668162899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1cQ19T8wJdQmSANY+ScgReovd7JZ689sd+x5NmI+pXY=; b=Z5l/GV2+KKfYLMglCYIz7P7Ajxl8pAa1rdrsb6UMSL896RMHyrg9tFeAh5sXptragJPT9V JLfRDoM8INtU4Y3P3L0TJdlp9AKqdDm+ZQEKOn3WrOXsVTtolzNZ7/LdCd6kUd2h9zpAFG vKiBaRxmXaUIoSa1IJlyaBVOeK7uwkA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-484-E9yxJR5iOfGgW7iHLXBpNQ-1; Fri, 11 Nov 2022 05:34:58 -0500 X-MC-Unique: E9yxJR5iOfGgW7iHLXBpNQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DC4E1C05EAC; Fri, 11 Nov 2022 10:34:57 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 749E52022EA2; Fri, 11 Nov 2022 10:34:56 +0000 (UTC) From: Kevin Traynor To: Ciara Power Cc: Fan Zhang , Pablo de Lara , dpdk stable Subject: patch 'test/crypto: fix wireless auth digest segment' has been queued to stable release 21.11.3 Date: Fri, 11 Nov 2022 10:33:26 +0000 Message-Id: <20221111103337.307408-36-ktraynor@redhat.com> In-Reply-To: <20221111103337.307408-1-ktraynor@redhat.com> References: <20221111103337.307408-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/627efa19b562edc73df7ece42a075f3425102400 Thanks. Kevin --- >From 627efa19b562edc73df7ece42a075f3425102400 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 7 Oct 2022 13:46:50 +0000 Subject: [PATCH] test/crypto: fix wireless auth digest segment [ upstream commit dc3f6c5347b2b64899694c2f94a6af53c95d2b4d ] The segment size for some tests was too small to hold the auth digest. This caused issues when using op->sym->auth.digest.data for comparisons in AESNI_MB PMD after a subsequent patch enables SGL. For example, if segment size is 2, and digest size is 4, then 4 bytes are read from op->sym->auth.digest.data, which overflows into the memory after the segment, rather than using the second segment that contains the remaining half of the digest. Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") Signed-off-by: Ciara Power Acked-by: Fan Zhang Acked-by: Pablo de Lara --- app/test/test_cryptodev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index da5dc4baa8..3c848f094b 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -3039,4 +3039,14 @@ create_wireless_algo_auth_cipher_operation( sgl_buf = sgl_buf->next; } + + /* The last segment should be large enough to hold full digest */ + if (sgl_buf->data_len < auth_tag_len) { + rte_pktmbuf_free(sgl_buf->next); + sgl_buf->next = NULL; + TEST_ASSERT_NOT_NULL(rte_pktmbuf_append(sgl_buf, + auth_tag_len - sgl_buf->data_len), + "No room to append auth tag"); + } + sym_op->auth.digest.data = rte_pktmbuf_mtod_offset(sgl_buf, uint8_t *, remaining_off); -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 10:32:17.919680911 +0000 +++ 0036-test-crypto-fix-wireless-auth-digest-segment.patch 2022-11-11 10:32:17.104300889 +0000 @@ -1 +1 @@ -From dc3f6c5347b2b64899694c2f94a6af53c95d2b4d Mon Sep 17 00:00:00 2001 +From 627efa19b562edc73df7ece42a075f3425102400 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dc3f6c5347b2b64899694c2f94a6af53c95d2b4d ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index c6d47a035e..203b8b61fa 100644 +index da5dc4baa8..3c848f094b 100644 @@ -29 +30 @@ -@@ -2991,4 +2991,14 @@ create_wireless_algo_auth_cipher_operation( +@@ -3039,4 +3039,14 @@ create_wireless_algo_auth_cipher_operation(