From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B989A0542 for ; Fri, 11 Nov 2022 11:34:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 453B542D0C; Fri, 11 Nov 2022 11:34:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BB60840150 for ; Fri, 11 Nov 2022 11:34:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668162852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiBSIeghPxjqITTDGwB5X+maK9gj6/e8Hh0ZEyKgAS4=; b=WoW2i19xzDECTjSqe5iAOMY1F1NbT+HFcJJ+I+AMiLsNV04lEW7GV2DHeTIKtCl0TsJ0/F 8+G6vQyN6ybCiWAVoR41xRIrmw6GHEKkFjR3DvtBrBRhNkphclhhBLIHW6lpEZXMJ1E7er XdoKpWroH5sKpWdUDMhFyxXExNAZIeI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-321-MdOYixjWOP-0JLHnaxzlBQ-1; Fri, 11 Nov 2022 05:34:11 -0500 X-MC-Unique: MdOYixjWOP-0JLHnaxzlBQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C470185A794; Fri, 11 Nov 2022 10:34:11 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 932B4200E288; Fri, 11 Nov 2022 10:34:10 +0000 (UTC) From: Kevin Traynor To: Naga Harish K S V Cc: dpdk stable Subject: patch 'eventdev/eth_tx: fix queue delete' has been queued to stable release 21.11.3 Date: Fri, 11 Nov 2022 10:32:54 +0000 Message-Id: <20221111103337.307408-4-ktraynor@redhat.com> In-Reply-To: <20221111103337.307408-1-ktraynor@redhat.com> References: <20221111103337.307408-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ff547815301b2c2c2a76eff7564e43712f6d625a Thanks. Kevin --- >From ff547815301b2c2c2a76eff7564e43712f6d625a Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Fri, 21 Oct 2022 01:43:14 -0500 Subject: [PATCH] eventdev/eth_tx: fix queue delete [ upstream commit 75c5bfc320fdc41226cbeeb864161268fb344c49 ] To delete all the queues of an ethdev device associated with adapter instance the queue_id can be passed as -1 to the queue delete API. When a subset of queues of a ethdev device are associated, the queue delete logic is exiting without deleting the queues in some cases (higher numbered associated queues) for above scenario as the queue delete logic is not checking all the queue association status. This patch fixes this issue by checking the queue association status of all the queues of the ethernet device. Fixes: 741b499e6421 ("eventdev/eth_tx: fix queue delete logic") Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 78418744ca..72e58974a8 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -868,4 +868,6 @@ txa_service_queue_del(uint8_t id, int ret = 0; + if (txa->txa_ethdev == NULL) + return 0; nb_queues = txa->txa_ethdev[port_id].nb_queues; if (nb_queues == 0) @@ -880,8 +882,8 @@ txa_service_queue_del(uint8_t id, if (tqi[q].added) { ret = txa_service_queue_del(id, dev, q); + i++; if (ret != 0) break; } - i++; q++; } -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 10:32:17.213234306 +0000 +++ 0004-eventdev-eth_tx-fix-queue-delete.patch 2022-11-11 10:32:16.997300458 +0000 @@ -1 +1 @@ -From 75c5bfc320fdc41226cbeeb864161268fb344c49 Mon Sep 17 00:00:00 2001 +From ff547815301b2c2c2a76eff7564e43712f6d625a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 75c5bfc320fdc41226cbeeb864161268fb344c49 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index c2a848103b..88309d2aaa 100644 +index 78418744ca..72e58974a8 100644 @@ -31 +32 @@ -@@ -935,4 +935,6 @@ txa_service_queue_del(uint8_t id, +@@ -868,4 +868,6 @@ txa_service_queue_del(uint8_t id, @@ -38 +39 @@ -@@ -947,8 +949,8 @@ txa_service_queue_del(uint8_t id, +@@ -880,8 +882,8 @@ txa_service_queue_del(uint8_t id,