From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B438A0542 for ; Fri, 11 Nov 2022 11:35:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5350B40150; Fri, 11 Nov 2022 11:35:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 590BC42D16 for ; Fri, 11 Nov 2022 11:35:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668162909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pClNmS6GLhtpEBor0IhPEp33oYKzQhU2cnFJ/PT2fGc=; b=ZQ/syHWjphmv0lxb5SNqHGrblaKWUIAlWwe7ZZXfnFcBJQgbTcqdwgrIOJMZw9YdKHZswd 29L6/Em+U+Ks3xnMJ5/gFN9QkHcr2OS66MhNLVDvcoCpDEWe53gfIgx+x+bdxIocztgqhk 8zauHnXPSivEQnsLliYz83Uu8AJ/+fI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-OSlL5y_aORyCvnhDJHPHFA-1; Fri, 11 Nov 2022 05:35:08 -0500 X-MC-Unique: OSlL5y_aORyCvnhDJHPHFA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 784803C01DE3; Fri, 11 Nov 2022 10:35:08 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FA2D202322E; Fri, 11 Nov 2022 10:35:07 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc100: fix close cleanup' has been queued to stable release 21.11.3 Date: Fri, 11 Nov 2022 10:33:33 +0000 Message-Id: <20221111103337.307408-43-ktraynor@redhat.com> In-Reply-To: <20221111103337.307408-1-ktraynor@redhat.com> References: <20221111103337.307408-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a Thanks. Kevin --- >From c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 20 Oct 2022 22:20:46 -0700 Subject: [PATCH] baseband/acc100: fix close cleanup [ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ] Set local pointer to NULL after rte_free. This needs to be set explicitly since logic may check for null pointers. Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 00c31fe85b..b59548315f 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -770,4 +770,7 @@ acc100_dev_close(struct rte_bbdev *dev) rte_free(d->sw_rings_base); d->sw_rings_base = NULL; + d->tail_ptrs = NULL; + d->info_ring = NULL; + d->harq_layout = NULL; } /* Ensure all in flight HW transactions are completed */ -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 10:32:18.081362518 +0000 +++ 0043-baseband-acc100-fix-close-cleanup.patch 2022-11-11 10:32:17.124300970 +0000 @@ -1 +1 @@ -From ba2262fe16cade81a18b353d580ec4229e1020a6 Mon Sep 17 00:00:00 2001 +From c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ + drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++ @@ -18,5 +19,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index a711862892..ad815ed76a 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -619,4 +619,7 @@ acc100_dev_close(struct rte_bbdev *dev) +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index 00c31fe85b..b59548315f 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -770,4 +770,7 @@ acc100_dev_close(struct rte_bbdev *dev)