From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CC39A0544 for ; Fri, 11 Nov 2022 12:39:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8822B4014F; Fri, 11 Nov 2022 12:39:51 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 472D340141 for ; Fri, 11 Nov 2022 12:39:50 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1088A42240 for ; Fri, 11 Nov 2022 11:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668166790; bh=5Im5UYuPv6FWVfdEIr8IMmsXElAqVnXANG883v5U18M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CoridqcskO3+RKJ+bVEQGA5qZBcmufAWcipB22GiIMiuQ2GcUkv6JJ0GHTRO9fy2p wvQeb4F7qxyVCSvPcH83z4QX8wYwFAm1ibjBPhlETV+m2dHXwW7Na5tKDJul4Jg3g6 zllkEUJHIG3CuBJtjuAVplCp79PpUugqP1EhP3u0JRrggAOty9SOkJ/AaXPXCu175u IeKb4fEyWixBC0u9GSlzD7rAhguYTof2dypowfd5fgJ6S/6Vuyugg7gyCKpC+qs+Fz T/F52aPCLHX3mopuTFjYH17ocs+Ogmr9xDx2AlgCgQOupcXq/IVMz1zs1xb9O3e1Ic Og1pOMcoTQw9A== Received: by mail-ed1-f71.google.com with SMTP id r12-20020a05640251cc00b00463699c95aeso3451922edd.18 for ; Fri, 11 Nov 2022 03:39:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Im5UYuPv6FWVfdEIr8IMmsXElAqVnXANG883v5U18M=; b=xNor7A2xwvcKLnaCKxFfTkfe95fD7m1ooDtZtGpBtCly3CjEOBuhNVFiBYFJQhGCH1 x0mHyKBlmyjOZhcEY07MsR9QE6ixNhmAJvvi2mNBZMfLFLoShRZe+A8ubQOr4vmXGWGC 6u+Da7OSTA422fzJaS9gA8RaUgPMf6sE7VYKaFSsy23Ek3Flh8aYMichFg0N/2t/rTUH 9g80ciMaCaH8LE9dfkuOBF1ol5eAoPPLrwzW8+ubbvVWNjLSKq7di/M6VL4UPT4cDj0A 6IMEqRYSM3NLzQdoveT/SItC0QQ6y3u+qhykZEOo4CgGmVXrGaWF48nNbSd4hKpOm7uD SkqA== X-Gm-Message-State: ANoB5pm9W9oP/Aps85gyQuSwScuyoh0s4rkLqFM79pys8T8hbRxCW/q7 jLKorDqQZMNzIfCTu7zqaNz9VYXWdSJpViwOCdgnCNWCWFEqxPp75vMuFSGMxGFEsGgfxKkXZEy UvGFxlw87qal5ak3VdusW+Gbs X-Received: by 2002:a05:6402:22f2:b0:467:60fa:b629 with SMTP id dn18-20020a05640222f200b0046760fab629mr813484edb.281.1668166789815; Fri, 11 Nov 2022 03:39:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf4l1hFUovFo9chvNEy8IjQz4wbpMucojw7lJY98gjql5ojBbC+sSYOh2H84F/lFm+7MUfgmMw== X-Received: by 2002:a05:6402:22f2:b0:467:60fa:b629 with SMTP id dn18-20020a05640222f200b0046760fab629mr813471edb.281.1668166789623; Fri, 11 Nov 2022 03:39:49 -0800 (PST) Received: from localhost.localdomain ([2a02:6d40:39af:c100:1891:6c61:50fd:e567]) by smtp.gmail.com with ESMTPSA id v17-20020a1709067d9100b0074134543f82sm796944ejo.90.2022.11.11.03.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 03:39:49 -0800 (PST) From: christian.ehrhardt@canonical.com To: Naga Harish K S V Cc: Jay Jayatheerthan , dpdk stable Subject: patch 'eventdev/eth_tx: fix adapter stop' has been queued to stable release 19.11.14 Date: Fri, 11 Nov 2022 12:38:28 +0100 Message-Id: <20221111113904.1549618-11-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> References: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.14 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/18/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/e2b41c9aef52ac79e60c59db7c1e0149db02121d Thanks. Christian Ehrhardt --- >From e2b41c9aef52ac79e60c59db7c1e0149db02121d Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Mon, 25 Jul 2022 23:22:11 -0500 Subject: [PATCH] eventdev/eth_tx: fix adapter stop [ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] adapter_stop function is stopping the adapter service using rte_service_runstate_set() API and waiting until rte_service_may_be_active() API returns stopped state in an infinite loop. This results in hang issues if application calls rte_service_lcore_stop() before adapter stop. Remove the state check after setting the service state which avoids running into hang issues. This also makes Tx adapter stop inline with remaining adapters. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/librte_eventdev/rte_event_eth_tx_adapter.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c index 0166e000b4..fa685db42b 100644 --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c @@ -474,10 +474,6 @@ txa_service_ctrl(uint8_t id, int start) ret = rte_service_runstate_set(txa->service_id, start); rte_spinlock_unlock(&txa->tx_lock); - if (ret == 0 && !start) { - while (rte_service_may_be_active(txa->service_id)) - rte_pause(); - } return ret; } -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 12:35:05.172957456 +0100 +++ 0011-eventdev-eth_tx-fix-adapter-stop.patch 2022-11-11 12:35:04.721191776 +0100 @@ -1 +1 @@ -From fbb9f7e215c3394681ab1292f421c4e5c4880392 Mon Sep 17 00:00:00 2001 +From e2b41c9aef52ac79e60c59db7c1e0149db02121d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fbb9f7e215c3394681ab1292f421c4e5c4880392 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ - lib/eventdev/rte_event_eth_tx_adapter.c | 4 ---- + lib/librte_eventdev/rte_event_eth_tx_adapter.c | 4 ---- @@ -27,5 +28,5 @@ -diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c -index aa7713bfa1..7e82fe030c 100644 ---- a/lib/eventdev/rte_event_eth_tx_adapter.c -+++ b/lib/eventdev/rte_event_eth_tx_adapter.c -@@ -509,10 +509,6 @@ txa_service_ctrl(uint8_t id, int start) +diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c +index 0166e000b4..fa685db42b 100644 +--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c ++++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c +@@ -474,10 +474,6 @@ txa_service_ctrl(uint8_t id, int start)