From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3266DA00C4 for ; Fri, 18 Nov 2022 00:09:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E25E4067B; Fri, 18 Nov 2022 00:09:42 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id 41C5D4021F for ; Fri, 18 Nov 2022 00:09:41 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so2808815wmi.3 for ; Thu, 17 Nov 2022 15:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lb0HEG1uxXZZ7ICLUy0vA+bPriy3wo4DBrxil9rYp+A=; b=ONV12pCSjmfs5ikL2GafYHRtmq7exKNZ4BxoBq6rqPXOLOMwW1hYgFv0at4idJBWfn qx1ugspZI9S4St0EAhm8CM3rR/5kQ8Awj4uj8UOeuZCxIc+ExKMjg8YuP3p3Ikief2JR pjaxQfv5mKYysVTZs9EToeIR5Ij/2C9GvV5y+g6b/zE89Rn6WFbfd/uPRw65W8RaeNXf ys4oyRmFAyGLvjX+hdq+Mh/JX4ugiAB2CqkZnBpxl5E21klZYA5/2CeY7Vo3fun1EKlB dT5sCXFJeFwLl+mNTZFhgD6CC/HW+LBdK9BqcYi0vHfd49qXgGCPVL+Y0I4e63ntl8N4 60NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lb0HEG1uxXZZ7ICLUy0vA+bPriy3wo4DBrxil9rYp+A=; b=PheJji3kYOkw99zlFUgIE3XEC6e6n89JImYK0a27nYIVNcLc22iHLJzPYIxdOE44bM CpR19zEPF97wfBWQJQrAtEhkojaWFAfS2FhUv7COL2XdmopawJrvbm6RkRUDztZgKBuO MR5To31V/Z01CiJPioGh8LocYOQwGXBN/nt8MN0bCMB4vCYlPVCqOHgJFRxpQfIXLE3O cJRjcz4PMKN9Xh2/duj0EAUb3OyiZeShUhAmN+x0U1GW9iezUkgAeD9HNwx3pS4mAlmf 5M5UZShcGG559SDfTi6MjON8cu0UtvZbm2cz9nOgF2wpweyisga+1fMRZTq2BPRaw8H4 mmZg== X-Gm-Message-State: ANoB5pn/yhdxfyu+j3tSUXSOBhXh42i6A6W/xJYX34+9rXKAHooAyOS6 PzXyWnrgmf2T57nWxRv61fYM73Ryf38= X-Google-Smtp-Source: AA0mqf4PXorfumQLO1r1ceDhBkcUhh8T0P45pMwVP5nR0I5IouLVgZ4fCn9cWYFt+WPxmt/31lGL9w== X-Received: by 2002:a7b:c385:0:b0:3cf:87a8:ef00 with SMTP id s5-20020a7bc385000000b003cf87a8ef00mr3040377wmj.55.1668726580947; Thu, 17 Nov 2022 15:09:40 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id s18-20020adfdb12000000b00241727795c4sm2476850wri.63.2022.11.17.15.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 15:09:40 -0800 (PST) From: luca.boccassi@gmail.com To: Vladimir Medvedkin Cc: Bruce Richardson , dpdk stable Subject: patch 'test/hash: fix bulk lookup check' has been queued to stable release 20.11.7 Date: Thu, 17 Nov 2022 23:08:35 +0000 Message-Id: <20221117230859.611465-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117230859.611465-1-luca.boccassi@gmail.com> References: <20221105171146.1520039-47-luca.boccassi@gmail.com> <20221117230859.611465-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0053fb1fe8feb7be4f06f5097095f2cb4967938e Thanks. Luca Boccassi --- >From 0053fb1fe8feb7be4f06f5097095f2cb4967938e Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Thu, 3 Nov 2022 18:52:56 +0000 Subject: [PATCH] test/hash: fix bulk lookup check [ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ] Check return value after bulk lookup. Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson --- app/test/test_hash_perf.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5d53..199564bba3 100644 --- a/app/test/test_hash_perf.c +++ b/app/test/test_hash_perf.c @@ -480,6 +480,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, (const void **)keys_burst, &signatures[j * BURST_SIZE], BURST_SIZE, positions_burst); + if (ret != 0) { + printf("rte_hash_lookup_with_hash_bulk failed with %d\n", + ret); + return -1; + } for (k = 0; k < BURST_SIZE; k++) { if (positions_burst[k] != positions[j * @@ -492,10 +497,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, } } } else { - rte_hash_lookup_bulk(h[table_index], + ret = rte_hash_lookup_bulk(h[table_index], (const void **) keys_burst, BURST_SIZE, positions_burst); + if (ret != 0) { + printf("rte_hash_lookup_bulk failed with %d\n", ret); + return -1; + } for (k = 0; k < BURST_SIZE; k++) { if (positions_burst[k] != positions[j * BURST_SIZE + k]) { printf("Key looked up in %d, should be in %d\n", -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-17 23:07:55.972196221 +0000 +++ 0011-test-hash-fix-bulk-lookup-check.patch 2022-11-17 23:07:55.448329376 +0000 @@ -1 +1 @@ -From 521171cf2a3cbc108ec920874cfa3706e7f89c73 Mon Sep 17 00:00:00 2001 +From 0053fb1fe8feb7be4f06f5097095f2cb4967938e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5d36c0f454..14a1283aba 100644 +index 76cdac5d53..199564bba3 100644 @@ -22 +23 @@ -@@ -475,6 +475,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, +@@ -480,6 +480,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, @@ -34 +35 @@ -@@ -487,10 +492,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, +@@ -492,10 +497,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,