From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4D6AA00C4 for ; Fri, 18 Nov 2022 00:11:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C96094067B; Fri, 18 Nov 2022 00:11:11 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id D906B42D26 for ; Fri, 18 Nov 2022 00:11:08 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id j15so5747524wrq.3 for ; Thu, 17 Nov 2022 15:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J/4OxsToGGAOV9iT1PAq6QbqA+0Z6nqbIFvMKOH6jQU=; b=lLOl0TYjAO8cp/y/9LXLiNQTFntuLq0xpWyi2r6+XTrYPeggZszbV72qRK92MxM6q/ cIbZxAG/wd86PCBH8OuvVikwePzlWlJ5N6MhpHvtLkuQWEExk22OHiOlUXc0BvySS75h UFDZmvuGk75IuX64Cm7/D/ZDn2oDrAk1MkX5rGaENqijcgm+KqsrViNUIqZ70iW/vP/F XVI+QMUJRtEbjzSwChXpQ60qK9TESJ2Sgpa1EtspYU7RrK7CobKxG3GxxfMHMVH/c/0G 4rBhA9xFYvwL9RjLrrJoppsOqe5dEcFy2TBX0XJNCuMUUe4XvCR7eSuCDSgwmYHNJKEz oqnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J/4OxsToGGAOV9iT1PAq6QbqA+0Z6nqbIFvMKOH6jQU=; b=p+1AUOCVnICXTa8ASM8KkPSuAVv4LQhWM9z8ytCT2+PW8p6ziZ3bfo8nyLSoOXrh1M 7PrEUa0FJj0zSfVRYNlUYJBOr5okzrVutleDO5Qdg/D51NCLaoyHzqahlZn6+/NLiwR3 GXbbL3TG5l0fJ+aNmBqb5BN1Z19Qadzom8rV29gTPGOVC6YcoLwvOEc+rLHou/ruBi3O c/qop8iuPWWfFt92pM+FeH5VsggOEgVQ2hdIOu7LaTkCJ6U0RmL1pKRw6eU+t3N0CnaN ldE04beC4R2aZwi9V5AesTnIq6F+S6OPTkS6gefBRKn8qMNtdLHCs4TPSndSqIu0TUZz aIVQ== X-Gm-Message-State: ANoB5pmQJSaW4Gh892d3b/J3VDfGrghL3d4yavAv3JRKsmy34QdhWQ1i xB9mST8C2kKwdfYzyAx5hqrhctaw1ME= X-Google-Smtp-Source: AA0mqf6pU2P8ZauzV96ID3QgAh2shHg1rxt/MTz38wlnwJmviUYbf+3d105hE1TMkoLTKZdAUvEj3Q== X-Received: by 2002:a05:6000:11c7:b0:236:7040:61c4 with SMTP id i7-20020a05600011c700b00236704061c4mr2690356wrx.313.1668726668556; Thu, 17 Nov 2022 15:11:08 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id b6-20020a5d45c6000000b0022e3538d305sm2515150wrs.117.2022.11.17.15.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 15:11:07 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Subject: patch 'ring: remove leftover comment about watermark' has been queued to stable release 20.11.7 Date: Thu, 17 Nov 2022 23:08:58 +0000 Message-Id: <20221117230859.611465-34-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117230859.611465-1-luca.boccassi@gmail.com> References: <20221105171146.1520039-47-luca.boccassi@gmail.com> <20221117230859.611465-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/93e9188a15569bab40c8254e1528d1aac95d7b65 Thanks. Luca Boccassi --- >From 93e9188a15569bab40c8254e1528d1aac95d7b65 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 May 2022 10:20:41 -0700 Subject: [PATCH] ring: remove leftover comment about watermark [ upstream commit 21dc24b746a7135dd799b462d9a6479dfd54a92f ] The watermark support was removed from rte_ring since version 17.02 but there is leftover in comments. Fixes: 77dd3064270c ("ring: remove watermark support") Signed-off-by: Stephen Hemminger --- lib/librte_ring/rte_ring.h | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index 937cfbb7a0..6f040dba55 100644 --- a/lib/librte_ring/rte_ring.h +++ b/lib/librte_ring/rte_ring.h @@ -66,10 +66,9 @@ ssize_t rte_ring_get_memsize(unsigned int count); * object table. It is advised to use rte_ring_get_memsize() to get the * appropriate size. * - * The ring size is set to *count*, which must be a power of two. Water - * marking is disabled by default. The real usable ring size is - * *count-1* instead of *count* to differentiate a free ring from an - * empty ring. + * The ring size is set to *count*, which must be a power of two. + * The real usable ring size is *count-1* instead of *count* to + * differentiate a full ring from an empty ring. * * The ring is not added in RTE_TAILQ_RING global list. Indeed, the * memory given by the caller may not be shareable among dpdk @@ -119,10 +118,9 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, * This function uses ``memzone_reserve()`` to allocate memory. Then it * calls rte_ring_init() to initialize an empty ring. * - * The new ring size is set to *count*, which must be a power of - * two. Water marking is disabled by default. The real usable ring size - * is *count-1* instead of *count* to differentiate a free ring from an - * empty ring. + * The new ring size is set to *count*, which must be a power of two. + * The real usable ring size is *count-1* instead of *count* to + * differentiate a full ring from an empty ring. * * The ring is added in RTE_TAILQ_RING list. * -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-17 23:07:56.904237065 +0000 +++ 0034-ring-remove-leftover-comment-about-watermark.patch 2022-11-17 23:07:55.560331899 +0000 @@ -1 +1 @@ -From 21dc24b746a7135dd799b462d9a6479dfd54a92f Mon Sep 17 00:00:00 2001 +From 93e9188a15569bab40c8254e1528d1aac95d7b65 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21dc24b746a7135dd799b462d9a6479dfd54a92f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -14 +15 @@ - lib/ring/rte_ring.h | 14 ++++++-------- + lib/librte_ring/rte_ring.h | 14 ++++++-------- @@ -17,4 +18,4 @@ -diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h -index 7c48e35d27..7e4cd60650 100644 ---- a/lib/ring/rte_ring.h -+++ b/lib/ring/rte_ring.h +diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h +index 937cfbb7a0..6f040dba55 100644 +--- a/lib/librte_ring/rte_ring.h ++++ b/lib/librte_ring/rte_ring.h @@ -27 +28 @@ -- * *count-1* instead of *count* to differentiate a full ring from an +- * *count-1* instead of *count* to differentiate a free ring from an @@ -35 +36 @@ -@@ -127,10 +126,9 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, +@@ -119,10 +118,9 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, @@ -41 +42 @@ -- * is *count-1* instead of *count* to differentiate a full ring from an +- * is *count-1* instead of *count* to differentiate a free ring from an