From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E5C1A00C4 for ; Fri, 18 Nov 2022 00:09:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 561D742D18; Fri, 18 Nov 2022 00:09:11 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 9BDE04021F for ; Fri, 18 Nov 2022 00:09:10 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id p16so2436699wmc.3 for ; Thu, 17 Nov 2022 15:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5OjO4kktUp3GyfBGennliVjEi28+73W1T669qo8IOMI=; b=ZjuQUCFGN9zSF3ZyclTRJp+JRwRUDXjhKbelRaTPMyqSiAbXMikvGb3ZzJ8hYMBZ3A B4YObHQ+DLNGSEgX79nocJrYzdWZ2TptLLRdXHjboQAuIDBkPh/f6h+/wiJilWTehYpi 9KWoSCBRsRtah2cNuiI3xIhX7Vb5cMZTEQvMyz09vW9A1P0dk842sqIfCA0wzWQ6jjW1 Epy3U8qy7wLeN+RDzVMbh0zyCTghIn4buN5QT4gljxtbphK+zOkk1ej7NQJKPtJnEmKA XL2l/90mvyZdFJoi/ruM5OQnqHzdSEv3AnlqL2UAVqYZK1v/Xen2chDePooxrLA05VJi Qjcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5OjO4kktUp3GyfBGennliVjEi28+73W1T669qo8IOMI=; b=u6GWh2LWJ94sTaZnVSSP2FEGx0woGlOKM6si8KiU3lGOmoVT/ahL+V4M6iBTqbheDV Q2za7z4uFS3BIUcgDMOvDJIk3uaOCq8InNXnus+zLziF+nt6gDE1vCD2b2EdpSaWgDJg 6Pi+F9GOILTqUELtWPOqL+NwbMBZHAnzr32vx10TKlLDMsH1S8TuLj8nX+S8QTKeYlP0 fPoMYElhLbs3zEsvEmO1pUyFJUBeYnCfeLNFGvMqCbfngod+910GSAEBNIBvdeF/SeJw CfISkaez/IDu4R2Kfe2XZownLHdRdfXzEb7Gvlm+e0xySyFTpKtT8tSIQ2QpBOcrqyyE bhxw== X-Gm-Message-State: ANoB5plI18RHNlV+e2W2OnFxjS44fOXTjfvqp81Nl9J98o2jZ/Iu/oMP NRdux1qPWL+xBlKfpguUyN0ZXloXQ5c= X-Google-Smtp-Source: AA0mqf7akP48Q1jOGsbhyx99iCugzdYen/aFQQCSvagezF+dTdpHMeRkLwFg+yvR42OIvCNggE8Xnw== X-Received: by 2002:a7b:cb83:0:b0:3cf:96da:3846 with SMTP id m3-20020a7bcb83000000b003cf96da3846mr6534102wmi.10.1668726550365; Thu, 17 Nov 2022 15:09:10 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id y7-20020adff6c7000000b002368f6b56desm2412282wrp.18.2022.11.17.15.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 15:09:09 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Ruifeng Wang , dpdk stable Subject: patch 'app/testpmd: make quit flag volatile' has been queued to stable release 20.11.7 Date: Thu, 17 Nov 2022 23:08:29 +0000 Message-Id: <20221117230859.611465-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117230859.611465-1-luca.boccassi@gmail.com> References: <20221105171146.1520039-47-luca.boccassi@gmail.com> <20221117230859.611465-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4716a35952589c702ba625af7fbba9c289ac0c68 Thanks. Luca Boccassi --- >From 4716a35952589c702ba625af7fbba9c289ac0c68 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Nov 2022 10:07:43 -0800 Subject: [PATCH] app/testpmd: make quit flag volatile [ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] Since f_quit is set in a signal handler it needs to be marked volatile. Otherwise, compiler is allowed to optimize the loop because it can assume the value never changes. The flag can also be made local to the file it is used in. Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") Signed-off-by: Stephen Hemminger Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d0cd11fe4e..13d8c1c72a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -216,7 +216,7 @@ uint16_t stats_period; /**< Period to show statistics (disabled by default) */ * In container, it cannot terminate the process which running with 'stats-period' * option. Set flag to exit stats period loop after received SIGINT/SIGTERM. */ -uint8_t f_quit; +static volatile uint8_t f_quit; uint8_t cl_quit; /* Quit testpmd from cmdline. */ /* -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-17 23:07:55.748054017 +0000 +++ 0005-app-testpmd-make-quit-flag-volatile.patch 2022-11-17 23:07:55.436329106 +0000 @@ -1 +1 @@ -From 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 Mon Sep 17 00:00:00 2001 +From 4716a35952589c702ba625af7fbba9c289ac0c68 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7381dfd9e5..295856f1a8 100644 +index d0cd11fe4e..13d8c1c72a 100644 @@ -24 +25 @@ -@@ -231,7 +231,7 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */ +@@ -216,7 +216,7 @@ uint16_t stats_period; /**< Period to show statistics (disabled by default) */