From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Olga Shern <olgas@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Ori Kam <orika@nvidia.com>, Andrey Vesnovaty <andreyv@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>
Subject: [PATCH 08/11] app/testpmd: fix build with clang 15 in flow code
Date: Fri, 18 Nov 2022 09:53:10 +0100 [thread overview]
Message-ID: <20221118085313.2118977-9-david.marchand@redhat.com> (raw)
In-Reply-To: <20221118085313.2118977-1-david.marchand@redhat.com>
This variable is not used and has been copy/pasted in a lot of other
code.
Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
Fixes: 55509e3a49fb ("app/testpmd: support shared flow action")
Fixes: 04cc665fab38 ("app/testpmd: add flow template management")
Fixes: c4b38873346b ("app/testpmd: add flow table management")
Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
Fixes: d906fff51878 ("app/testpmd: add async indirect actions operations")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test-pmd/config.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 982549ffed..9103ba6c77 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1787,7 +1787,6 @@ port_action_handle_destroy(portid_t port_id,
{
struct rte_port *port;
struct port_indirect_action **tmp;
- uint32_t c = 0;
int ret = 0;
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -1822,7 +1821,6 @@ port_action_handle_destroy(portid_t port_id,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -2251,7 +2249,6 @@ port_flow_pattern_template_destroy(portid_t port_id, uint32_t n,
{
struct rte_port *port;
struct port_template **tmp;
- uint32_t c = 0;
int ret = 0;
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -2288,7 +2285,6 @@ port_flow_pattern_template_destroy(portid_t port_id, uint32_t n,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -2368,7 +2364,6 @@ port_flow_actions_template_destroy(portid_t port_id, uint32_t n,
{
struct rte_port *port;
struct port_template **tmp;
- uint32_t c = 0;
int ret = 0;
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -2404,7 +2399,6 @@ port_flow_actions_template_destroy(portid_t port_id, uint32_t n,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -2534,7 +2528,6 @@ port_flow_template_table_destroy(portid_t port_id,
{
struct rte_port *port;
struct port_table **tmp;
- uint32_t c = 0;
int ret = 0;
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -2571,7 +2564,6 @@ port_flow_template_table_destroy(portid_t port_id,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -2719,7 +2711,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,
struct rte_flow_op_attr op_attr = { .postpone = postpone };
struct rte_port *port;
struct port_flow **tmp;
- uint32_t c = 0;
int ret = 0;
struct queue_job *job;
@@ -2768,7 +2759,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -2836,7 +2826,6 @@ port_queue_action_handle_destroy(portid_t port_id,
const struct rte_flow_op_attr attr = { .postpone = postpone};
struct rte_port *port;
struct port_indirect_action **tmp;
- uint32_t c = 0;
int ret = 0;
struct queue_job *job;
@@ -2886,7 +2875,6 @@ port_queue_action_handle_destroy(portid_t port_id,
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
@@ -3304,7 +3292,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
{
struct rte_port *port;
struct port_flow **tmp;
- uint32_t c = 0;
int ret = 0;
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -3337,7 +3324,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
}
if (i == n)
tmp = &(*tmp)->next;
- ++c;
}
return ret;
}
--
2.38.1
next prev parent reply other threads:[~2022-11-18 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221118085313.2118977-1-david.marchand@redhat.com>
2022-11-18 8:53 ` [PATCH 01/11] service: fix build with clang 15 David Marchand
2022-11-18 14:47 ` Van Haaren, Harry
2022-11-18 8:53 ` [PATCH 02/11] vhost: " David Marchand
2022-11-18 10:23 ` Maxime Coquelin
2022-11-18 8:53 ` [PATCH 03/11] bus/dpaa: " David Marchand
2022-11-18 8:53 ` [PATCH 04/11] net/atlantic: " David Marchand
2022-11-18 8:53 ` [PATCH 05/11] net/dpaa2: " David Marchand
2022-11-18 8:53 ` [PATCH 06/11] net/ice: " David Marchand
2022-11-18 8:53 ` [PATCH 07/11] app/testpmd: " David Marchand
2022-11-18 8:53 ` David Marchand [this message]
2022-11-18 8:53 ` [PATCH 09/11] test/efd: " David Marchand
2022-11-18 8:53 ` [PATCH 10/11] test/member: " David Marchand
2022-11-18 8:53 ` [PATCH 11/11] test/event: " David Marchand
2022-11-21 1:51 ` Gao, DaxueX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118085313.2118977-9-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akozyrev@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andreyv@nvidia.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).