From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF91CA0542 for ; Fri, 18 Nov 2022 13:48:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D4F04021F; Fri, 18 Nov 2022 13:48:34 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by mails.dpdk.org (Postfix) with ESMTP id 5DC0E4003F for ; Fri, 18 Nov 2022 13:48:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NCY1m2gMrjgfx2FhsggEPCDYkzOBxMorWbPYchs/PrIYYqnpDrAPH7ebxeaVYn5g6UF1IxHwJBw79e14pgUgthWlEePeRiGZ9uPbwj6i2SU9CjgUxcGxj419zYAjJXHz0I611BrD4K/nn9NflXP3lu6+7xC3Z6TzZr6Vz0Q8q+RJW+Q9qxt4/HaeSX6+jksjl8oc34b9p2J5t9cobAGojJKN1EPPk0vOh1CKoo9BgBtq0yxh9Can2PvMXaiP6PF6ZZee0wUZlS9+6E3GKd0WMkbXgdxUbgX946tsTxW1Vpj0Vdr5XwhQ74zXUVimRzQszI7JfhprPYqfinhpR9TeJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnbTBXbYqMtHQytjsFhp9F47H6L5+n5VrTf/8SoJ/nA=; b=PxujLarTI6F4Wcya1pRM6hMEqVcySgbP1HfkWzNnSq0AwHEb3FdQcnnfzdX04ObGX18RoYA2MYgs2PMF2W+iFlXunWDDA4ot2N+ak91B5X2ouX7wieGsFOXJRdgtF7wqHrcxiHItuH5TE3cCABJD+y92wtEUIevcQwStRhGBV3MdMRbXkM5gaw9kxkvBViE6LJUQpdfpteZQIYVQUuaxBKNI11VTZMuDhWUlCcYCVDV6UKI5WYPgNHA/uNhjf5HfISuj2eOeDy7TUdw8EeCFBeaP2+ZlODVYwAkyUozDcLkHBgUxI/hsVU4pWB469h3XLggAIwXCZSfEc78FEcLCHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnbTBXbYqMtHQytjsFhp9F47H6L5+n5VrTf/8SoJ/nA=; b=mvIUqkSeOjsR+ckXAeoPzU/jPoz/yAWMuj2SuL4vneYyEpoDpyBRBIJCgAa3di1sBK/SS0GlfF+jma34UjDBaBn9PDychLUbSkTl2MgmqnfCS3G0/bfXxoYxG6Ssu+prr9A75Yj7fVNfU6Bh5sZA4OZsBXAtJ/R4Kcu+XEN07/nRTPEOEvJQanE4GNZnBXbHgRdViIT/cb/q0k+Y+pT7nW3u2QmWO7G98MEpJD2MVGoanrSLYP4s31oLqYQO3mQut687BGfi7SknkECWmzE/V770VXuC2k6dcM1K4y9B0mFUYHeM1jOkNpBkY93BKx8c1M8U3d7Cvao+FZJ9DbqLZw== Received: from DS7PR06CA0037.namprd06.prod.outlook.com (2603:10b6:8:54::12) by MN2PR12MB4439.namprd12.prod.outlook.com (2603:10b6:208:262::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Fri, 18 Nov 2022 12:48:31 +0000 Received: from DS1PEPF0000B075.namprd05.prod.outlook.com (2603:10b6:8:54:cafe::32) by DS7PR06CA0037.outlook.office365.com (2603:10b6:8:54::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 12:48:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS1PEPF0000B075.mail.protection.outlook.com (10.167.17.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Fri, 18 Nov 2022 12:48:31 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 18 Nov 2022 04:48:31 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 18 Nov 2022 04:48:30 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend Transport; Fri, 18 Nov 2022 04:48:29 -0800 From: Michael Baum To: CC: Matan Azrad , Viacheslav Ovsiienko , Luca Boccassi , Subject: [PATCH 20.11] net/mlx5: fix invalid memory access in port closing Date: Fri, 18 Nov 2022 14:48:24 +0200 Message-ID: <20221118124824.1436257-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B075:EE_|MN2PR12MB4439:EE_ X-MS-Office365-Filtering-Correlation-Id: f8b6f4c5-205e-43d8-a855-08dac96332bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HM6JbOoxkcBWa0uf945fe81vvImkTHUNGMEjIOLVeYHnFJvYlSG72Y3360AKzd3/Nf+DXqvTeOKRytJe8jzIWlt1JhLfYJBATXvbWyz4Dj8XKg/CP9P/+jZqV0J6O5318LX+oZ5KwvlH/XbVGHVVDg0E7G1jM6Kt68zSMEDRx2D0IH/kcZY/zzCmw89y4btGkNOWOVJdsqIWXsPWEj2jrkngD1htmw3MaY+yN8kwWrsTCiNvpq4zJLgbeYtH8oSLkH/q6Jc/dd58rvMy3jQrY5ixRSLsSL6mX+y9ZejCdp9Lvk9NRbNg2LCFWEZ+8BhqFi9TwlScB9/gphBmtrSph6W8uKF8ewd6jJXNTG2Bn/GHSz5aLgJ9GbCBvkMJpEifsGcxUrQYdL1BqMFk734QBsTrA/1PAmzrUnYxyDjb/e2VQRhhRQibuepe4PGPZ0OqqvxEGOC/Yd9JWxA348USpojHGx7FmoocdCcXgjvSNByFtBXYs7MAmaRzxPKaDfeJVivyS5KQyRUL6xVyzHO9dgqPt8BEIsXtgvu2ruFdvspjtuK75vE1qLY22chzEqhmp44IiyqX2Ig+ZX7TmLeoRNN7Cmpj/13FB3/EPYy8DGB9Uo7a7ZEnup3NzkZD6/ItRSiMKFRrZGFRi8N1DaEaqf3JxmLh51HO1kvj5PClzkZpiVAilfah4XVeuk8l25T6fVsQ7YXlnLVonZXJ7BW2Rg== X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(86362001)(36756003)(8936002)(107886003)(356005)(36860700001)(40460700003)(2616005)(1076003)(83380400001)(54906003)(47076005)(426003)(336012)(70206006)(7636003)(6916009)(316002)(478600001)(186003)(82310400005)(55016003)(82740400003)(5660300002)(40480700001)(70586007)(6286002)(6666004)(8676002)(2906002)(4326008)(41300700001)(26005)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:48:31.5044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8b6f4c5-205e-43d8-a855-08dac96332bb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B075.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4439 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The shared IB device (sh) has per port data updated in port creation. In port closing this port data is updated even when the SH still exist. However, this updating is happened after SH has been released and for last port it actually accesses to freed memory. This patch updates the port data before SH releasing. Fixes: 79c37d65d2ff ("net/mlx5: fix port event cleaning order") Cc: michaelba@nvidia.com Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 22d3ecace2..10aeccb695 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1428,6 +1428,12 @@ mlx5_dev_close(struct rte_eth_dev *dev) DRV_LOG(WARNING, "port %u some flows still remain", dev->data->port_id); mlx5_cache_list_destroy(&priv->hrxqs); + priv->sh->port[priv->dev_port - 1].nl_ih_port_id = RTE_MAX_ETHPORTS; + /* + * The interrupt handler port id must be reset before priv is reset + * since 'mlx5_dev_interrupt_nl_cb' uses priv. + */ + rte_io_wmb(); /* * Free the shared context in last turn, because the cleanup * routines above may use some shared fields, like @@ -1453,12 +1459,6 @@ mlx5_dev_close(struct rte_eth_dev *dev) if (!c) claim_zero(rte_eth_switch_domain_free(priv->domain_id)); } - priv->sh->port[priv->dev_port - 1].nl_ih_port_id = RTE_MAX_ETHPORTS; - /* - * The interrupt handler port id must be reset before priv is reset - * since 'mlx5_dev_interrupt_nl_cb' uses priv. - */ - rte_io_wmb(); memset(priv, 0, sizeof(*priv)); priv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID; /* -- 2.25.1