From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25412A06CB for ; Tue, 22 Nov 2022 23:03:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 213A542D79; Tue, 22 Nov 2022 23:03:26 +0100 (CET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id F27D842D84 for ; Tue, 22 Nov 2022 23:03:23 +0100 (CET) Received: by mail-wr1-f42.google.com with SMTP id i12so23013330wrb.0 for ; Tue, 22 Nov 2022 14:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IaHsA92tdroTBw2TeI6e0DnIZWeRgMfACibC6bkPIXQ=; b=It3SsaEu+xyNZONJpR9bB7yhazGj+vEdvNfrnfHq2v1qojfNVT+sLNULPVEbICtQRU shr8vXm/JsFooJGfs6E+6C5/AHClcsBUSxr9RIfSxgDelFOurB3y1qDFr4kE+Iadgr71 nGZzQ0TxcjIi60G2lS6/ynQUfEUe46dJ2l9E+kDVMNN+snJdRKFpVCW4nmjeWqkYo6LF QzZE6JiNiUsVczT6s7AGxPhR6aV9Ovt7kMfEPssERPykAGeSbdVTtz8WyXfZDuOmGNLh KfeXhV8JVKeBzjKt2QQqU+vKIt1SwohZE5Mz+QDJ0/VoSxdaCRf75s24DwWImPWvQ4/K Xk0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IaHsA92tdroTBw2TeI6e0DnIZWeRgMfACibC6bkPIXQ=; b=yRPpr15hg1XMSmjyO36Oyre0zDer/dQS7EgJ+9h93jkdWX7p4LoCG8ngJ91uahfE+W 2aa96JTkbFX4FgwuWKP7ng2G0XsNHHT8c40tiqhVJhU61TU3wiV+xI8rkHh7Wvyjp0xc cp0fsh93KlL/ai7vEm4kaG8Z1Ar+PJfm7E2WrBqBmdiGLOEgYkWCQV10IWb2geLbBj5L TcEcTjAMlB/pVOwDl/8n1YXr4kUcLz1TUoyFyPMUmz7Pmv+HKamKkynGqoBjXwcBDkhb Qw7AJmGQWrYld8CXez5pKrDWMWVM4r6niFhCHA0XEITF8+m20c3unzpVKr3SutDwlBup ogbw== X-Gm-Message-State: ANoB5pnlPdzFtGDxXCtJwHJYRLasMk1zWiqQ5PocWbBUkT9GtVmTBiQB /ZdGqz1G9V6gXYQEWDICRHROTUPjoQYiCQ== X-Google-Smtp-Source: AA0mqf6LnVryv418VIqkhYY8LMfvyPBD26iiYmlDDLFU4GqUIPP7gm4XdWm0dCBd+C71x2tQnws/6g== X-Received: by 2002:a5d:4ac4:0:b0:22c:f296:1120 with SMTP id y4-20020a5d4ac4000000b0022cf2961120mr14748778wrs.369.1669154603707; Tue, 22 Nov 2022 14:03:23 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id v14-20020a5d4b0e000000b002416e383e1csm15147812wrq.25.2022.11.22.14.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:03:23 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Matan Azrad , dpdk stable Subject: patch 'doc: add LRO size limitation in mlx5 guide' has been queued to stable release 20.11.7 Date: Tue, 22 Nov 2022 22:02:36 +0000 Message-Id: <20221122220241.926784-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221122220241.926784-1-luca.boccassi@gmail.com> References: <20221117230859.611465-34-luca.boccassi@gmail.com> <20221122220241.926784-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aaa746b08d0f6d03475701001a126be48079119c Thanks. Luca Boccassi --- >From aaa746b08d0f6d03475701001a126be48079119c Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Thu, 17 Nov 2022 16:39:01 +0200 Subject: [PATCH] doc: add LRO size limitation in mlx5 guide [ upstream commit ea75808941c8020c568e47d1ef9b25223258c131 ] Maximal LRO message size must be multiply of 256. Otherwise, TCP payload may not fit into a single WQE. Fixes: 1c7e57f9bd33 ("net/mlx5: set maximum LRO packet size") Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 9322c5327a..6df0bb7e62 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -306,6 +306,8 @@ Limitations TCP header (122B). - Rx queue with LRO offload enabled, receiving a non-LRO packet, can forward it with size limited to max LRO size, not to max RX packet length. + - The driver rounds down the port configuration value ``max_lro_pkt_size`` + (from ``rte_eth_rxmode``) to a multiple of 256 due to hardware limitation. - LRO can be used with outer header of TCP packets of the standard format: eth (with or without vlan) / ipv4 or ipv6 / tcp / payload -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-22 22:01:32.331111532 +0000 +++ 0012-doc-add-LRO-size-limitation-in-mlx5-guide.patch 2022-11-22 22:01:31.519524881 +0000 @@ -1 +1 @@ -From ea75808941c8020c568e47d1ef9b25223258c131 Mon Sep 17 00:00:00 2001 +From aaa746b08d0f6d03475701001a126be48079119c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ea75808941c8020c568e47d1ef9b25223258c131 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 4f0db21dde..ab9498a91e 100644 +index 9322c5327a..6df0bb7e62 100644 @@ -22 +23 @@ -@@ -404,6 +404,8 @@ Limitations +@@ -306,6 +306,8 @@ Limitations