From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F77EA00C2 for ; Wed, 23 Nov 2022 19:04:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C02642DA4; Wed, 23 Nov 2022 19:04:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7AA4B42DB7 for ; Wed, 23 Nov 2022 19:04:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QykdbYudPW63+h3lJX3CHqeT4h32m33SH/Ok63IW4o0=; b=SDOuSYPqx6x27poYLiJSSzVsFmgHjIayAfVxBC/nL8p09D6dlnu9YG5b58DK1e+6GYoKdg gcFyULKDeMkMNaLjxfQLVCnXjtuFLSQTydJl9R9oubX5I4y37f2C/59Rd0pcicZv6vfH1a +Hut8AporkPHG4xUCcd/dncRmKpu9ww= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-492-IfJS8J_sPI6lAl4VWioZRA-1; Wed, 23 Nov 2022 13:04:38 -0500 X-MC-Unique: IfJS8J_sPI6lAl4VWioZRA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78D04848535; Wed, 23 Nov 2022 18:04:38 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD44D492B07; Wed, 23 Nov 2022 18:04:37 +0000 (UTC) From: Kevin Traynor To: Vladimir Medvedkin Cc: Bruce Richardson , dpdk stable Subject: patch 'test/hash: fix bulk lookup check' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:23 +0000 Message-Id: <20221123180413.733554-10-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e2413f64278495fcadf61a8dd127b6f0bcc9d127 Thanks. Kevin --- >From e2413f64278495fcadf61a8dd127b6f0bcc9d127 Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Thu, 3 Nov 2022 18:52:56 +0000 Subject: [PATCH] test/hash: fix bulk lookup check [ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ] Check return value after bulk lookup. Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson --- app/test/test_hash_perf.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5d53..199564bba3 100644 --- a/app/test/test_hash_perf.c +++ b/app/test/test_hash_perf.c @@ -481,4 +481,9 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, &signatures[j * BURST_SIZE], BURST_SIZE, positions_burst); + if (ret != 0) { + printf("rte_hash_lookup_with_hash_bulk failed with %d\n", + ret); + return -1; + } for (k = 0; k < BURST_SIZE; k++) { if (positions_burst[k] != @@ -493,8 +498,12 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, } } else { - rte_hash_lookup_bulk(h[table_index], + ret = rte_hash_lookup_bulk(h[table_index], (const void **) keys_burst, BURST_SIZE, positions_burst); + if (ret != 0) { + printf("rte_hash_lookup_bulk failed with %d\n", ret); + return -1; + } for (k = 0; k < BURST_SIZE; k++) { if (positions_burst[k] != positions[j * BURST_SIZE + k]) { -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:57.350770858 +0000 +++ 0010-test-hash-fix-bulk-lookup-check.patch 2022-11-23 09:55:57.015149171 +0000 @@ -1 +1 @@ -From 521171cf2a3cbc108ec920874cfa3706e7f89c73 Mon Sep 17 00:00:00 2001 +From e2413f64278495fcadf61a8dd127b6f0bcc9d127 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5d36c0f454..14a1283aba 100644 +index 76cdac5d53..199564bba3 100644 @@ -22 +23 @@ -@@ -476,4 +476,9 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, +@@ -481,4 +481,9 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, @@ -32 +33 @@ -@@ -488,8 +493,12 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data, +@@ -493,8 +498,12 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,