patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Shun Hao <shunh@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/mlx5: fix action flag data type' has been queued to stable release 21.11.3
Date: Wed, 23 Nov 2022 18:03:25 +0000	[thread overview]
Message-ID: <20221123180413.733554-12-ktraynor@redhat.com> (raw)
In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/28/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/97b4706f1e9d10d414cda20aec6f5b4b79e9da32

Thanks.

Kevin

---
From 97b4706f1e9d10d414cda20aec6f5b4b79e9da32 Mon Sep 17 00:00:00 2001
From: Shun Hao <shunh@nvidia.com>
Date: Tue, 1 Nov 2022 12:07:24 +0200
Subject: [PATCH] net/mlx5: fix action flag data type

[ upstream commit e5517406963b07fa117e499a0474869dc236a1a6 ]

MLX5_FLOW_ACTION flags are used as uint64_t now, but some old flags
are not defined as 64 bits. So if they are type casted to uint64 after
bitwise operations, the high 32-bit data might be incorrect.

E.g. Currently MLX5_FLOW_ACTION_DROP is defined as 0x1u, when it is used
like:
	(action_flags & ~MLX5_FLOW_ACTION_DROP)
action_flags is uint64_t so (~MLX5_FLOW_ACTION_DROP) will be casted to
uint64_t as well, but its high 32 bits will be all 0s. This will make the
result not as expected.

This patch fixes this by making all action flags definition as 64-bit
data type.

Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy validation")

Signed-off-by: Shun Hao <shunh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.h | 56 ++++++++++++++++++------------------
 1 file changed, 28 insertions(+), 28 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 29ccb98351..094e483325 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -225,32 +225,32 @@ enum mlx5_feature_name {
 
 /* Actions */
-#define MLX5_FLOW_ACTION_DROP (1u << 0)
-#define MLX5_FLOW_ACTION_QUEUE (1u << 1)
-#define MLX5_FLOW_ACTION_RSS (1u << 2)
-#define MLX5_FLOW_ACTION_FLAG (1u << 3)
-#define MLX5_FLOW_ACTION_MARK (1u << 4)
-#define MLX5_FLOW_ACTION_COUNT (1u << 5)
-#define MLX5_FLOW_ACTION_PORT_ID (1u << 6)
-#define MLX5_FLOW_ACTION_OF_POP_VLAN (1u << 7)
-#define MLX5_FLOW_ACTION_OF_PUSH_VLAN (1u << 8)
-#define MLX5_FLOW_ACTION_OF_SET_VLAN_VID (1u << 9)
-#define MLX5_FLOW_ACTION_OF_SET_VLAN_PCP (1u << 10)
-#define MLX5_FLOW_ACTION_SET_IPV4_SRC (1u << 11)
-#define MLX5_FLOW_ACTION_SET_IPV4_DST (1u << 12)
-#define MLX5_FLOW_ACTION_SET_IPV6_SRC (1u << 13)
-#define MLX5_FLOW_ACTION_SET_IPV6_DST (1u << 14)
-#define MLX5_FLOW_ACTION_SET_TP_SRC (1u << 15)
-#define MLX5_FLOW_ACTION_SET_TP_DST (1u << 16)
-#define MLX5_FLOW_ACTION_JUMP (1u << 17)
-#define MLX5_FLOW_ACTION_SET_TTL (1u << 18)
-#define MLX5_FLOW_ACTION_DEC_TTL (1u << 19)
-#define MLX5_FLOW_ACTION_SET_MAC_SRC (1u << 20)
-#define MLX5_FLOW_ACTION_SET_MAC_DST (1u << 21)
-#define MLX5_FLOW_ACTION_ENCAP (1u << 22)
-#define MLX5_FLOW_ACTION_DECAP (1u << 23)
-#define MLX5_FLOW_ACTION_INC_TCP_SEQ (1u << 24)
-#define MLX5_FLOW_ACTION_DEC_TCP_SEQ (1u << 25)
-#define MLX5_FLOW_ACTION_INC_TCP_ACK (1u << 26)
-#define MLX5_FLOW_ACTION_DEC_TCP_ACK (1u << 27)
+#define MLX5_FLOW_ACTION_DROP (1ull << 0)
+#define MLX5_FLOW_ACTION_QUEUE (1ull << 1)
+#define MLX5_FLOW_ACTION_RSS (1ull << 2)
+#define MLX5_FLOW_ACTION_FLAG (1ull << 3)
+#define MLX5_FLOW_ACTION_MARK (1ull << 4)
+#define MLX5_FLOW_ACTION_COUNT (1ull << 5)
+#define MLX5_FLOW_ACTION_PORT_ID (1ull << 6)
+#define MLX5_FLOW_ACTION_OF_POP_VLAN (1ull << 7)
+#define MLX5_FLOW_ACTION_OF_PUSH_VLAN (1ull << 8)
+#define MLX5_FLOW_ACTION_OF_SET_VLAN_VID (1ull << 9)
+#define MLX5_FLOW_ACTION_OF_SET_VLAN_PCP (1ull << 10)
+#define MLX5_FLOW_ACTION_SET_IPV4_SRC (1ull << 11)
+#define MLX5_FLOW_ACTION_SET_IPV4_DST (1ull << 12)
+#define MLX5_FLOW_ACTION_SET_IPV6_SRC (1ull << 13)
+#define MLX5_FLOW_ACTION_SET_IPV6_DST (1ull << 14)
+#define MLX5_FLOW_ACTION_SET_TP_SRC (1ull << 15)
+#define MLX5_FLOW_ACTION_SET_TP_DST (1ull << 16)
+#define MLX5_FLOW_ACTION_JUMP (1ull << 17)
+#define MLX5_FLOW_ACTION_SET_TTL (1ull << 18)
+#define MLX5_FLOW_ACTION_DEC_TTL (1ull << 19)
+#define MLX5_FLOW_ACTION_SET_MAC_SRC (1ull << 20)
+#define MLX5_FLOW_ACTION_SET_MAC_DST (1ull << 21)
+#define MLX5_FLOW_ACTION_ENCAP (1ull << 22)
+#define MLX5_FLOW_ACTION_DECAP (1ull << 23)
+#define MLX5_FLOW_ACTION_INC_TCP_SEQ (1ull << 24)
+#define MLX5_FLOW_ACTION_DEC_TCP_SEQ (1ull << 25)
+#define MLX5_FLOW_ACTION_INC_TCP_ACK (1ull << 26)
+#define MLX5_FLOW_ACTION_DEC_TCP_ACK (1ull << 27)
 #define MLX5_FLOW_ACTION_SET_TAG (1ull << 28)
 #define MLX5_FLOW_ACTION_MARK_EXT (1ull << 29)
-- 
2.38.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-23 09:55:57.391397221 +0000
+++ 0012-net-mlx5-fix-action-flag-data-type.patch	2022-11-23 09:55:57.017149176 +0000
@@ -1 +1 @@
-From e5517406963b07fa117e499a0474869dc236a1a6 Mon Sep 17 00:00:00 2001
+From 97b4706f1e9d10d414cda20aec6f5b4b79e9da32 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e5517406963b07fa117e499a0474869dc236a1a6 ]
+
@@ -21 +22,0 @@
-Cc: stable@dpdk.org
@@ -30 +31 @@
-index da9b65d8fe..91691806ad 100644
+index 29ccb98351..094e483325 100644
@@ -33 +34 @@
-@@ -259,32 +259,32 @@ enum mlx5_feature_name {
+@@ -225,32 +225,32 @@ enum mlx5_feature_name {


  parent reply	other threads:[~2022-11-23 18:04 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 18:03 patch 'net/bonding: fix slave device Rx/Tx offload configuration' " Kevin Traynor
2022-11-23 18:03 ` patch 'app/testpmd: fix MAC header in checksum forward engine' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/bonding: fix dropping valid MAC packets' " Kevin Traynor
2022-11-23 18:03 ` patch 'app/testpmd: make quit flag volatile' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/bonding: fix mbuf fast free handling' " Kevin Traynor
2022-11-23 18:03 ` patch 'eal: fix doxygen comments for UUID' " Kevin Traynor
2022-11-23 18:03 ` patch 'power: fix some doxygen comments' " Kevin Traynor
2022-11-23 18:03 ` patch 'hash: fix RCU configuration memory leak' " Kevin Traynor
2022-11-23 18:03 ` patch 'test/hash: remove dead code in extendable bucket test' " Kevin Traynor
2022-11-23 18:03 ` patch 'test/hash: fix bulk lookup check' " Kevin Traynor
2022-11-23 18:03 ` patch 'bus/auxiliary: prevent device from being probed again' " Kevin Traynor
2022-11-23 18:03 ` Kevin Traynor [this message]
2022-11-23 18:03 ` patch 'common/mlx5: fix shared mempool subscription' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix shared Rx queue config reuse' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix hairpin split with set VLAN VID action' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix first segment inline length' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix indexed pool local cache crash' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix port initialization with small LRO' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix drop action validation' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice/base: fix duplicate flow rules' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/iavf: fix VLAN offload' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/i40e: fix pctype configuration for X722' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix scalar Rx path segment' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix scalar Tx " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix interrupt handler unregister' " Kevin Traynor
2022-11-23 18:03 ` patch 'ci: bump versions of actions in GHA' " Kevin Traynor
2022-11-23 18:03 ` patch 'ci: update to new API for step outputs " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix event timer adapter guide' " Kevin Traynor
2022-11-23 18:03 ` patch 'event/cnxk: fix mbuf offset calculation' " Kevin Traynor
2022-11-23 18:03 ` patch 'app/eventdev: fix limits in error message' " Kevin Traynor
2022-11-23 18:03 ` patch 'event/cnxk: fix missing mempool cookie marking' " Kevin Traynor
2022-11-23 18:03 ` patch 'examples/fips_validation: fix typo in error log' " Kevin Traynor
2022-11-23 18:03 ` patch 'mempool/cnxk: fix destroying empty pool' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix application name in procinfo guide' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: document device dump " Kevin Traynor
2022-11-23 18:03 ` patch 'test/crypto: fix bitwise operator in a SNOW3G case' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix typo depreciated instead of deprecated' " Kevin Traynor
2022-11-23 18:03 ` patch 'drivers: fix typos found by Lintian' " Kevin Traynor
2022-11-23 18:03 ` patch 'ring: fix description' " Kevin Traynor
2022-11-23 18:03 ` patch 'ring: remove leftover comment about watermark' " Kevin Traynor
2022-11-23 18:03 ` patch 'vdpa/ifc: handle data path update failure' " Kevin Traynor
2022-11-23 18:03 ` patch 'service: fix build with clang 15' " Kevin Traynor
2022-11-23 18:03 ` patch 'vhost: " Kevin Traynor
2022-11-23 18:03 ` patch 'bus/dpaa: " Kevin Traynor
2022-11-23 18:03 ` patch 'net/atlantic: " Kevin Traynor
2022-11-23 18:03 ` patch 'net/dpaa2: " Kevin Traynor
2022-11-23 18:04 ` patch 'app/testpmd: " Kevin Traynor
2022-11-23 18:04 ` patch 'app/testpmd: fix build with clang 15 in flow code' " Kevin Traynor
2022-11-23 18:04 ` patch 'test/efd: fix build with clang 15' " Kevin Traynor
2022-11-23 18:04 ` patch 'test/member: " Kevin Traynor
2022-11-23 18:04 ` patch 'test/event: " Kevin Traynor
2022-11-23 18:04 ` patch 'net/ixgbevf: fix promiscuous and allmulti' " Kevin Traynor
2022-11-23 18:04 ` patch 'net/mlx5: fix maximum LRO message size' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: add LRO size limitation in mlx5 guide' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix underlines in testpmd " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix colons in testpmd aged flow rules' " Kevin Traynor
2022-11-23 18:04 ` patch 'net/nfp: fix Rx descriptor DMA address' " Kevin Traynor
2022-11-23 18:04 ` patch 'drivers: remove unused build variable' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix maximum packet size of virtio driver' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: avoid meson deprecation in setup' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123180413.733554-12-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=matan@nvidia.com \
    --cc=shunh@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).