From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54907A04FD for ; Wed, 23 Nov 2022 19:04:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44CA442DB9; Wed, 23 Nov 2022 19:04:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 532CA42DB4 for ; Wed, 23 Nov 2022 19:04:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JC4FYyXSerCk3l0ogm/oZKs/PTBFP7Qj0NIGE3JZPFc=; b=Te8Y9nyWeSAMYUrToVn7FpZY2kpvU70PO1zUyaO9yKbmgd49PYA3okZY0Pz8x/WA6c+CUS 1YRyYfFtEro8YofL3PNj14s48ES+0w3R5JmUv6yw8OsF8UdSnOnfi9rPSt3YgUuGqiaAr+ xmQzYIAy10wH8VB8fo5mVh2AK9ot64U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-Idx1GFkYPr6HljMTEcYQtg-1; Wed, 23 Nov 2022 13:04:45 -0500 X-MC-Unique: Idx1GFkYPr6HljMTEcYQtg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F19F1101A54E; Wed, 23 Nov 2022 18:04:44 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E7EC492B07; Wed, 23 Nov 2022 18:04:44 +0000 (UTC) From: Kevin Traynor To: Alexander Kozyrev Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix first segment inline length' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:29 +0000 Message-Id: <20221123180413.733554-16-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4cce54a549ecfb02c1939097b36622ed9b4dbfda Thanks. Kevin --- >From 4cce54a549ecfb02c1939097b36622ed9b4dbfda Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Tue, 8 Nov 2022 15:45:00 +0200 Subject: [PATCH] net/mlx5: fix first segment inline length [ upstream commit da4470cb178b87c9637cb575719e022182ea38da ] Packets can be split into several mbufs with various data sizes. There is no limitation on how small these segments can be. But there is a limitation on Tx side for inline configuration: send WQEs with inline headers less than the required are dropped. The very first segment must be more than minimal inline eth segment. Enforce this requirement by merging a few segments in this case. Fixes: ec837ad0fc7c ("net/mlx5: fix multi-segment inline for the first segments") Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_tx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h index 13d6d434d7..9e097944cd 100644 --- a/drivers/net/mlx5/mlx5_tx.h +++ b/drivers/net/mlx5/mlx5_tx.h @@ -1942,4 +1942,6 @@ mlx5_tx_packet_multi_inline(struct mlx5_txq_data *__rte_restrict txq, nxlen > txq->inlen_send) { return mlx5_tx_packet_multi_send(txq, loc, olx); + } else if (nxlen <= MLX5_ESEG_MIN_INLINE_SIZE) { + inlen = MLX5_ESEG_MIN_INLINE_SIZE; } else { goto do_first; -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:57.483863865 +0000 +++ 0016-net-mlx5-fix-first-segment-inline-length.patch 2022-11-23 09:55:57.031149211 +0000 @@ -1 +1 @@ -From da4470cb178b87c9637cb575719e022182ea38da Mon Sep 17 00:00:00 2001 +From 4cce54a549ecfb02c1939097b36622ed9b4dbfda Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit da4470cb178b87c9637cb575719e022182ea38da ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 6471ebf59f..a44050a1ce 100644 +index 13d6d434d7..9e097944cd 100644 @@ -26 +27 @@ -@@ -1995,4 +1995,6 @@ mlx5_tx_packet_multi_inline(struct mlx5_txq_data *__rte_restrict txq, +@@ -1942,4 +1942,6 @@ mlx5_tx_packet_multi_inline(struct mlx5_txq_data *__rte_restrict txq,