From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8A8FA00C2 for ; Wed, 23 Nov 2022 19:04:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF2B142DA3; Wed, 23 Nov 2022 19:04:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 81BBB40E5A for ; Wed, 23 Nov 2022 19:04:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tI0l6tGYveL0CcV9zyNbY3+I/bGcltQU+Ui3WwssjX0=; b=WgtZ4HyRtleXICqseRvdZMQQWJjaa/dB/OUsSB4CPQeasXwO2kwtyBQvLoGr2P9r3ly7Kn DpBAFyyp3cO7EAY28kljzLR1u0mkmyKzJK5zWcA7XSjLus5wg8uZblu+3ZmGoD5rT7WP6p dL23SUt2OEL/QpDE2btwzjSftCr+S4A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-0V76oM85PAusudqWnXeQgQ-1; Wed, 23 Nov 2022 13:04:46 -0500 X-MC-Unique: 0V76oM85PAusudqWnXeQgQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3A9E185A78B; Wed, 23 Nov 2022 18:04:45 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BF9A492B07; Wed, 23 Nov 2022 18:04:45 +0000 (UTC) From: Kevin Traynor To: Alexander Kozyrev Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix indexed pool local cache crash' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:30 +0000 Message-Id: <20221123180413.733554-17-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/815d59452a8ac311bfdf0ea1858d64ddd482a859 Thanks. Kevin --- >From 815d59452a8ac311bfdf0ea1858d64ddd482a859 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Wed, 9 Nov 2022 14:58:19 +0200 Subject: [PATCH] net/mlx5: fix indexed pool local cache crash [ upstream commit 7869d603807c447f357ec3b35c193a1019e6e1b2 ] Local cache for an indexed pool is not initialized in the situation when all the indices are allocated on one CPU core and freed on another one. That leads to a crash once we try to check its reference counter. Check that the local cache is initialized before accessing this counter. Fixes: d15c0946beea ("net/mlx5: add indexed pool local cache") Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index 4115a2ad77..b295702fd4 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -480,5 +480,5 @@ _mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, int cidx, uint32_t idx) gc = pool->gc; if (ilc->lc != gc) { - if (!(--ilc->lc->ref_cnt)) + if (ilc->lc && !(--ilc->lc->ref_cnt)) olc = ilc->lc; gc->ref_cnt++; -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:57.506144177 +0000 +++ 0017-net-mlx5-fix-indexed-pool-local-cache-crash.patch 2022-11-23 09:55:57.032149214 +0000 @@ -1 +1 @@ -From 7869d603807c447f357ec3b35c193a1019e6e1b2 Mon Sep 17 00:00:00 2001 +From 815d59452a8ac311bfdf0ea1858d64ddd482a859 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7869d603807c447f357ec3b35c193a1019e6e1b2 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org