From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C23C0A00C2 for ; Wed, 23 Nov 2022 19:05:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE81842DB3; Wed, 23 Nov 2022 19:05:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 821B840E5A for ; Wed, 23 Nov 2022 19:05:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BX9gvlP9wK1e5/3HSjwT1KUmZSWENcjQH1QGdYRqgVs=; b=OgY/ZrsqSJUYCCL2Eig8FeIdO25/UTeFhBIuQVwLxYebIXZA8KrmjsDx3B3pQyCgjIYIZx c15RusJB3Sk4ucHPK9/L1lEzKZ+G4vQrlwlHfVgQsqQ6yVke0E41cNU5cKKotHBCtormJq QXHtUHhfpMwAkgYf5gwDudbkceJQcAI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-SZOkEyxMPAy8rBU_jh28iw-1; Wed, 23 Nov 2022 13:05:07 -0500 X-MC-Unique: SZOkEyxMPAy8rBU_jh28iw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5CF23C0E463; Wed, 23 Nov 2022 18:05:07 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19732492B07; Wed, 23 Nov 2022 18:05:06 +0000 (UTC) From: Kevin Traynor To: Haiyue Wang Cc: dpdk stable Subject: patch 'ring: fix description' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:52 +0000 Message-Id: <20221123180413.733554-39-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ecfdc8089d8e9d0c8946220860c5dcbacf8b9409 Thanks. Kevin --- >From ecfdc8089d8e9d0c8946220860c5dcbacf8b9409 Mon Sep 17 00:00:00 2001 From: Haiyue Wang Date: Fri, 8 Apr 2022 20:40:42 +0800 Subject: [PATCH] ring: fix description [ upstream commit a2248c87e2ba9aa0b455e8b4b90ec713aa212749 ] The index description isn't right, correct it as the Programmer's guide said. Also correct the guide's figure description about 'Dequeue First Step'. Fixes: 4a22e6ee3d2f ("doc: refactor figure numbers into references") Fixes: af75078fece3 ("first public release") Signed-off-by: Haiyue Wang --- doc/guides/prog_guide/ring_lib.rst | 2 +- lib/ring/rte_ring_core.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/ring_lib.rst b/doc/guides/prog_guide/ring_lib.rst index 54e0bb4b68..515a715266 100644 --- a/doc/guides/prog_guide/ring_lib.rst +++ b/doc/guides/prog_guide/ring_lib.rst @@ -173,5 +173,5 @@ If there are not enough objects in the ring (this is detected by checking prod_t .. figure:: img/ring-dequeue1.* - Dequeue last step + Dequeue first step diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index 1252ca9546..82b237091b 100644 --- a/lib/ring/rte_ring_core.h +++ b/lib/ring/rte_ring_core.h @@ -112,6 +112,6 @@ struct rte_ring_hts_headtail { * * The producer and the consumer have a head and a tail index. The particularity - * of these index is that they are not between 0 and size(ring). These indexes - * are between 0 and 2^32, and we mask their value when we access the ring[] + * of these index is that they are not between 0 and size(ring)-1. These indexes + * are between 0 and 2^32 -1, and we mask their value when we access the ring[] * field. Thanks to this assumption, we can do subtractions between 2 index * values in a modulo-32bit base: that's why the overflow of the indexes is not -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:57.998157049 +0000 +++ 0039-ring-fix-description.patch 2022-11-23 09:55:57.090149360 +0000 @@ -1 +1 @@ -From a2248c87e2ba9aa0b455e8b4b90ec713aa212749 Mon Sep 17 00:00:00 2001 +From ecfdc8089d8e9d0c8946220860c5dcbacf8b9409 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a2248c87e2ba9aa0b455e8b4b90ec713aa212749 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org