patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'app/testpmd: make quit flag volatile' has been queued to stable release 21.11.3
Date: Wed, 23 Nov 2022 18:03:17 +0000	[thread overview]
Message-ID: <20221123180413.733554-4-ktraynor@redhat.com> (raw)
In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/28/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a0521c13c14063d9d8179935280ea789b85fa07b

Thanks.

Kevin

---
From a0521c13c14063d9d8179935280ea789b85fa07b Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 8 Nov 2022 10:07:43 -0800
Subject: [PATCH] app/testpmd: make quit flag volatile

[ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ]

Since f_quit is set in a signal handler it needs to be marked
volatile.  Otherwise, compiler is allowed to optimize the loop because
it can assume the value never changes. The flag can also be made local
to the file it is used in.

Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test-pmd/testpmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b8b311f982..ce8fd3d7d3 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -229,5 +229,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */
  * option. Set flag to exit stats period loop after received SIGINT/SIGTERM.
  */
-uint8_t f_quit;
+static volatile uint8_t f_quit;
 uint8_t cl_quit; /* Quit testpmd from cmdline. */
 
-- 
2.38.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-23 09:55:57.221424573 +0000
+++ 0004-app-testpmd-make-quit-flag-volatile.patch	2022-11-23 09:55:57.009149156 +0000
@@ -1 +1 @@
-From 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 Mon Sep 17 00:00:00 2001
+From a0521c13c14063d9d8179935280ea789b85fa07b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -21 +22 @@
-index 7381dfd9e5..295856f1a8 100644
+index b8b311f982..ce8fd3d7d3 100644
@@ -24 +25 @@
-@@ -232,5 +232,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */
+@@ -229,5 +229,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */


  parent reply	other threads:[~2022-11-23 18:04 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 18:03 patch 'net/bonding: fix slave device Rx/Tx offload configuration' " Kevin Traynor
2022-11-23 18:03 ` patch 'app/testpmd: fix MAC header in checksum forward engine' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/bonding: fix dropping valid MAC packets' " Kevin Traynor
2022-11-23 18:03 ` Kevin Traynor [this message]
2022-11-23 18:03 ` patch 'net/bonding: fix mbuf fast free handling' " Kevin Traynor
2022-11-23 18:03 ` patch 'eal: fix doxygen comments for UUID' " Kevin Traynor
2022-11-23 18:03 ` patch 'power: fix some doxygen comments' " Kevin Traynor
2022-11-23 18:03 ` patch 'hash: fix RCU configuration memory leak' " Kevin Traynor
2022-11-23 18:03 ` patch 'test/hash: remove dead code in extendable bucket test' " Kevin Traynor
2022-11-23 18:03 ` patch 'test/hash: fix bulk lookup check' " Kevin Traynor
2022-11-23 18:03 ` patch 'bus/auxiliary: prevent device from being probed again' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix action flag data type' " Kevin Traynor
2022-11-23 18:03 ` patch 'common/mlx5: fix shared mempool subscription' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix shared Rx queue config reuse' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix hairpin split with set VLAN VID action' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix first segment inline length' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix indexed pool local cache crash' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix port initialization with small LRO' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/mlx5: fix drop action validation' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice/base: fix duplicate flow rules' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/iavf: fix VLAN offload' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/i40e: fix pctype configuration for X722' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix scalar Rx path segment' " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix scalar Tx " Kevin Traynor
2022-11-23 18:03 ` patch 'net/ice: fix interrupt handler unregister' " Kevin Traynor
2022-11-23 18:03 ` patch 'ci: bump versions of actions in GHA' " Kevin Traynor
2022-11-23 18:03 ` patch 'ci: update to new API for step outputs " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix event timer adapter guide' " Kevin Traynor
2022-11-23 18:03 ` patch 'event/cnxk: fix mbuf offset calculation' " Kevin Traynor
2022-11-23 18:03 ` patch 'app/eventdev: fix limits in error message' " Kevin Traynor
2022-11-23 18:03 ` patch 'event/cnxk: fix missing mempool cookie marking' " Kevin Traynor
2022-11-23 18:03 ` patch 'examples/fips_validation: fix typo in error log' " Kevin Traynor
2022-11-23 18:03 ` patch 'mempool/cnxk: fix destroying empty pool' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix application name in procinfo guide' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: document device dump " Kevin Traynor
2022-11-23 18:03 ` patch 'test/crypto: fix bitwise operator in a SNOW3G case' " Kevin Traynor
2022-11-23 18:03 ` patch 'doc: fix typo depreciated instead of deprecated' " Kevin Traynor
2022-11-23 18:03 ` patch 'drivers: fix typos found by Lintian' " Kevin Traynor
2022-11-23 18:03 ` patch 'ring: fix description' " Kevin Traynor
2022-11-23 18:03 ` patch 'ring: remove leftover comment about watermark' " Kevin Traynor
2022-11-23 18:03 ` patch 'vdpa/ifc: handle data path update failure' " Kevin Traynor
2022-11-23 18:03 ` patch 'service: fix build with clang 15' " Kevin Traynor
2022-11-23 18:03 ` patch 'vhost: " Kevin Traynor
2022-11-23 18:03 ` patch 'bus/dpaa: " Kevin Traynor
2022-11-23 18:03 ` patch 'net/atlantic: " Kevin Traynor
2022-11-23 18:03 ` patch 'net/dpaa2: " Kevin Traynor
2022-11-23 18:04 ` patch 'app/testpmd: " Kevin Traynor
2022-11-23 18:04 ` patch 'app/testpmd: fix build with clang 15 in flow code' " Kevin Traynor
2022-11-23 18:04 ` patch 'test/efd: fix build with clang 15' " Kevin Traynor
2022-11-23 18:04 ` patch 'test/member: " Kevin Traynor
2022-11-23 18:04 ` patch 'test/event: " Kevin Traynor
2022-11-23 18:04 ` patch 'net/ixgbevf: fix promiscuous and allmulti' " Kevin Traynor
2022-11-23 18:04 ` patch 'net/mlx5: fix maximum LRO message size' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: add LRO size limitation in mlx5 guide' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix underlines in testpmd " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix colons in testpmd aged flow rules' " Kevin Traynor
2022-11-23 18:04 ` patch 'net/nfp: fix Rx descriptor DMA address' " Kevin Traynor
2022-11-23 18:04 ` patch 'drivers: remove unused build variable' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: fix maximum packet size of virtio driver' " Kevin Traynor
2022-11-23 18:04 ` patch 'doc: avoid meson deprecation in setup' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123180413.733554-4-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=ruifeng.wang@arm.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).