From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8978A00C2 for ; Wed, 23 Nov 2022 19:04:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3D8442DA5; Wed, 23 Nov 2022 19:04:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EDBCE42DB0 for ; Wed, 23 Nov 2022 19:04:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pOle17IsoIqTP3FGIG0s/EegyiKNsVpConoLCR0YbDQ=; b=bVKRhB4y68LCdd0cQzjk1VjDeq7XtIcKnpDfnQ69zeHLm8g0DFXn8bngoq5f4pDjg09CeN 6s2JfNTmvukWBmqyNbgMFPmSK9tuj1PIhd6Dfs9wf/GM/YMzUC2rkko0DWcNXdTMTSEK7D S8+TC58i53DgEElz/SwPevbGWRZjI1c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-dBg1RtuaOUmwOttm1vh0dQ-1; Wed, 23 Nov 2022 13:04:32 -0500 X-MC-Unique: dBg1RtuaOUmwOttm1vh0dQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 03E83848549; Wed, 23 Nov 2022 18:04:32 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1560D492B07; Wed, 23 Nov 2022 18:04:30 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ruifeng Wang , dpdk stable Subject: patch 'app/testpmd: make quit flag volatile' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:17 +0000 Message-Id: <20221123180413.733554-4-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a0521c13c14063d9d8179935280ea789b85fa07b Thanks. Kevin --- >From a0521c13c14063d9d8179935280ea789b85fa07b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Nov 2022 10:07:43 -0800 Subject: [PATCH] app/testpmd: make quit flag volatile [ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] Since f_quit is set in a signal handler it needs to be marked volatile. Otherwise, compiler is allowed to optimize the loop because it can assume the value never changes. The flag can also be made local to the file it is used in. Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") Signed-off-by: Stephen Hemminger Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index b8b311f982..ce8fd3d7d3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -229,5 +229,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */ * option. Set flag to exit stats period loop after received SIGINT/SIGTERM. */ -uint8_t f_quit; +static volatile uint8_t f_quit; uint8_t cl_quit; /* Quit testpmd from cmdline. */ -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:57.221424573 +0000 +++ 0004-app-testpmd-make-quit-flag-volatile.patch 2022-11-23 09:55:57.009149156 +0000 @@ -1 +1 @@ -From 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 Mon Sep 17 00:00:00 2001 +From a0521c13c14063d9d8179935280ea789b85fa07b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7381dfd9e5..295856f1a8 100644 +index b8b311f982..ce8fd3d7d3 100644 @@ -24 +25 @@ -@@ -232,5 +232,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */ +@@ -229,5 +229,5 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */