From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11AF4A00C2 for ; Wed, 23 Nov 2022 19:05:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E3AD42DB2; Wed, 23 Nov 2022 19:05:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9979E40E5A for ; Wed, 23 Nov 2022 19:05:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669226712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i/zYARGCXt7ckKjPH+bmpUVAvLZ4bPyNFh++KCgfEzQ=; b=T7czM6ZdHJMeV0AGrLgHC8xEBcHEo1b+ORBHeIP07PR/stYCmRnYsK/eKKaYe8EDNNp8TP wQ1G2XmUFABgCKr7Gv0jjxW8lSpD0POMybyAI13ANPl8rM3QfoweT5v4WFLUPXI6OfeLBj QTPEDScYM8BhyW7WZpDpii4Qe+Rgqng= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-GFlCqsGiNYKVzw_LaMc3zA-1; Wed, 23 Nov 2022 13:05:08 -0500 X-MC-Unique: GFlCqsGiNYKVzw_LaMc3zA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7597C85A59D; Wed, 23 Nov 2022 18:05:08 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5FD8492B07; Wed, 23 Nov 2022 18:05:07 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'ring: remove leftover comment about watermark' has been queued to stable release 21.11.3 Date: Wed, 23 Nov 2022 18:03:53 +0000 Message-Id: <20221123180413.733554-40-ktraynor@redhat.com> In-Reply-To: <20221123180413.733554-1-ktraynor@redhat.com> References: <20221123180413.733554-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/29a2eb7cee5748722939a1bd3d2b26882e355c85 Thanks. Kevin --- >From 29a2eb7cee5748722939a1bd3d2b26882e355c85 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 May 2022 10:20:41 -0700 Subject: [PATCH] ring: remove leftover comment about watermark [ upstream commit 21dc24b746a7135dd799b462d9a6479dfd54a92f ] The watermark support was removed from rte_ring since version 17.02 but there is leftover in comments. Fixes: 77dd3064270c ("ring: remove watermark support") Signed-off-by: Stephen Hemminger --- lib/ring/rte_ring.h | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h index 937cfbb7a0..6f040dba55 100644 --- a/lib/ring/rte_ring.h +++ b/lib/ring/rte_ring.h @@ -67,8 +67,7 @@ ssize_t rte_ring_get_memsize(unsigned int count); * appropriate size. * - * The ring size is set to *count*, which must be a power of two. Water - * marking is disabled by default. The real usable ring size is - * *count-1* instead of *count* to differentiate a free ring from an - * empty ring. + * The ring size is set to *count*, which must be a power of two. + * The real usable ring size is *count-1* instead of *count* to + * differentiate a full ring from an empty ring. * * The ring is not added in RTE_TAILQ_RING global list. Indeed, the @@ -120,8 +119,7 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, * calls rte_ring_init() to initialize an empty ring. * - * The new ring size is set to *count*, which must be a power of - * two. Water marking is disabled by default. The real usable ring size - * is *count-1* instead of *count* to differentiate a free ring from an - * empty ring. + * The new ring size is set to *count*, which must be a power of two. + * The real usable ring size is *count-1* instead of *count* to + * differentiate a full ring from an empty ring. * * The ring is added in RTE_TAILQ_RING list. -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-23 09:55:58.018750954 +0000 +++ 0040-ring-remove-leftover-comment-about-watermark.patch 2022-11-23 09:55:57.091149362 +0000 @@ -1 +1 @@ -From 21dc24b746a7135dd799b462d9a6479dfd54a92f Mon Sep 17 00:00:00 2001 +From 29a2eb7cee5748722939a1bd3d2b26882e355c85 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21dc24b746a7135dd799b462d9a6479dfd54a92f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 7c48e35d27..7e4cd60650 100644 +index 937cfbb7a0..6f040dba55 100644 @@ -26 +27 @@ -- * *count-1* instead of *count* to differentiate a full ring from an +- * *count-1* instead of *count* to differentiate a free ring from an @@ -33 +34 @@ -@@ -128,8 +127,7 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, +@@ -120,8 +119,7 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count, @@ -38 +39 @@ -- * is *count-1* instead of *count* to differentiate a full ring from an +- * is *count-1* instead of *count* to differentiate a free ring from an