From: Hanumanth Pothula <hpothula@marvell.com>
To: <stable@dpdk.org>
Cc: <jerinj@marvell.com>, <ndabilpuram@marvell.com>,
Hanumanth Pothula <hpothula@marvell.com>
Subject: [PATCH 21.11] net/cnxk: fix configuring large Rx/Tx queues
Date: Tue, 29 Nov 2022 14:34:41 +0530 [thread overview]
Message-ID: <20221129090441.186744-1-hpothula@marvell.com> (raw)
[upstream commit 5a0f64d84bf939aba37527d511fde45e1a9f6f9e]
While configuring NIX, local variables 'nb_rxq' and 'nb_txq'
are declared as 8bit variables, leading to an integer overflow
when an application sends Rxq/Txq value greater than 255.
Hence, declare local variables, 'nb_rxq' and 'nb_txq' as 16bit
variable.
Fixes: b75e0aca84b0 ("net/cnxk: add device configuration operation")
Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>
---
drivers/net/cnxk/cnxk_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 8ba35ac36f..67a8dec75b 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -1034,7 +1034,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)
struct roc_nix_fc_cfg fc_cfg = {0};
struct roc_nix *nix = &dev->nix;
struct rte_ether_addr *ea;
- uint8_t nb_rxq, nb_txq;
+ uint16_t nb_rxq, nb_txq;
uint64_t rx_cfg;
void *qs;
int rc;
--
2.25.1
reply other threads:[~2022-11-29 9:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129090441.186744-1-hpothula@marvell.com \
--to=hpothula@marvell.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).