From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Shai Brandes <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
Stanislaw Kardach <kda@semihalf.com>,
Dawid Gorecki <dgr@semihalf.com>
Subject: [PATCH] net/ena: fix deadlock in RSS reta update
Date: Thu, 5 Jan 2023 14:57:33 +0100 [thread overview]
Message-ID: <20230105135733.4162954-1-david.marchand@redhat.com> (raw)
Add missing lock release in case of internal failure.
Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c
index b682d01c20..d0ba9d5c0a 100644
--- a/drivers/net/ena/ena_rss.c
+++ b/drivers/net/ena/ena_rss.c
@@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev,
if (unlikely(rc != 0)) {
PMD_DRV_LOG(ERR,
"Cannot fill indirection table\n");
+ rte_spinlock_unlock(&adapter->admin_lock);
return rc;
}
}
--
2.39.0
next reply other threads:[~2023-01-05 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 13:57 David Marchand [this message]
2023-01-05 14:05 ` Zhang, Fan
2023-01-06 20:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105135733.4162954-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dgr@semihalf.com \
--cc=evgenys@amazon.com \
--cc=igorch@amazon.com \
--cc=kda@semihalf.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).