From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8E354241A for ; Thu, 19 Jan 2023 18:28:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0E3941101; Thu, 19 Jan 2023 18:28:17 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id A76B740223 for ; Thu, 19 Jan 2023 18:28:15 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id s3so2016135pfd.12 for ; Thu, 19 Jan 2023 09:28:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zdShy8eslDhY8iXU2b7IKmJ/JYICZpOdBN7cM67AvlA=; b=U5DsHEThFmbM+AVVzmnlVApn5BUla28OyBEnrc8eX/kkbWH7Qy/ygHGtTN6uHv6ZAZ TzA1gjHiuXGTK6EcVYSzQ63AKqDktDsMnTQXyV4zn5WIUxNXRh8IrX61DaoZVxTXvHzi UH0o8LuiYfR/oo+0YTC3DBUEExqzu0mVk7F536FGvTkApLqucmdxjvvfHw87TXha/4XZ s6Z8a06ALdQCkODVKXkKEXVWBSkWsuShjoE56Ea1j6ZZiU0Gh2stYujdbTxN9tv5wQru yPbNUCsRyd2p0kXWWk+ECEiESJv5f4INIUnpzbpVHDwwidWP7ee0rIix/ktlBNCcp5eq BClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zdShy8eslDhY8iXU2b7IKmJ/JYICZpOdBN7cM67AvlA=; b=Qe/sCCawKssh29X3xUNoNkOenJKd/gyOGfOlTLvFHZ1a1SHALcb3f9l9fMs2NjSyKi lhFeZk34sft8JNz1UFtx5S0wosYNRrq9zm8BUho+AIURlKg6ibTBxeSuOGIBqooR4PDv blBwC8f5P5oJYQfUtAPpylvl8iMuXM5vw08ow/jWHvTeusybgIuwWBKeEbh5q451u0bp a6CotEw8KSAwoaLSBz29CILFjDA9yDJJJsRHgscOPDZh48EXM1i/otShKvxyN/AnvbZw nWY4KGceBI5grPHjMTn6zI0vWJ+0U1G3FCMkYaafvRsux6cZTNqA0OORPzKMShVo3U4v lIVQ== X-Gm-Message-State: AFqh2kq3ZevhtPAcIzSXyPY9vjTNkPKMbVNKPmkIulsp2ba5G5iQcC+n dl94v76KU4hHnzc2DwTGad10ww== X-Google-Smtp-Source: AMrXdXtHzErPv13rqNfbmc4y0s1B87fOVg05DNwnSHqNPsvTuv4LLK4UksfwFqxcYd+vph2v9sbkaQ== X-Received: by 2002:aa7:9586:0:b0:580:e549:559e with SMTP id z6-20020aa79586000000b00580e549559emr36261996pfj.17.1674149294206; Thu, 19 Jan 2023 09:28:14 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 189-20020a6204c6000000b00581e0b5ad8dsm24346066pfe.107.2023.01.19.09.28.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 09:28:14 -0800 (PST) Date: Thu, 19 Jan 2023 09:28:11 -0800 From: Stephen Hemminger To: Gregory Etelson Cc: , , Aman Singh , Yuying Zhang , Ferruh Yigit Subject: Re: [PATCH v3] app/testpmd: fix interactive mode with no ports Message-ID: <20230119092811.3826b869@hermes.local> In-Reply-To: <20230119172312.15418-1-getelson@nvidia.com> References: <20221109170918.2887-1-getelson@nvidia.com> <20230119172312.15418-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 19 Jan 2023 19:23:12 +0200 Gregory Etelson wrote: > + if (!no_device_start && start_port(RTE_PORT_ALL) != 0) { > + fprintf(stderr, "Start ports failed\n"); > + if (!interactive) { > + rte_eal_cleanup(); > + rte_exit(EXIT_FAILURE, "Start ports failed\n"); > + } > + } Ok, but you are printing message twice now.