From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA4A541C42 for ; Wed, 8 Feb 2023 19:08:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B327F4014F; Wed, 8 Feb 2023 19:08:12 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1808F40141; Wed, 8 Feb 2023 19:08:11 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5B13C20C7E26; Wed, 8 Feb 2023 10:08:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5B13C20C7E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1675879690; bh=y89yn+2/dx0RfkIFklMDS3OwjxEDy0qh9qHslt8S+VM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJYxwZRngYUGlj2R81YtT6pPow7Tq7c807HlFFQdHSP4tRcGo3X7ZKbcP0FEyEm7H uvn2T6Ce2QZJ4nDeFn+OQ1E6AwCUwHApyABuzjqOVigvuna0lchZ9vu99kIzxCf10z 6jZRLdFHYf8qQyHNO1OlbLvBM84w6hiD8Jh0UOD8= Date: Wed, 8 Feb 2023 10:08:10 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Keith Wiles Subject: Re: [PATCH] build: fix invalid characters in toolchain definitions Message-ID: <20230208180810.GA24727@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230207152200.122227-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230207152200.122227-1-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Feb 07, 2023 at 03:22:00PM +0000, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the > compiler warning: > > ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions] > > This can be fixed, and the macro generation made more robust generally, > by adding "underscorify()" on the string. This replaces the "-", and > any other invalid characters, with "_" [2]. > > [1] https://mesonbuild.com/Reference-tables.html#compiler-ids > [2] https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify > > Fixes: afd18fa21b5e ("build: set toolchain info during meson configure") > Cc: stable@dpdk.org > > Reported-by: Keith Wiles > Signed-off-by: Bruce Richardson Acked-by: Tyler Retzlaff