From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A13BE41D4F for ; Thu, 23 Feb 2023 10:38:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9647643150; Thu, 23 Feb 2023 10:38:28 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 1B74243196 for ; Thu, 23 Feb 2023 10:38:27 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id p16so5996922wmq.5 for ; Thu, 23 Feb 2023 01:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S3kO73xXQn6D5/dq+9agjMfbsu/xcRmv3KxmrQoyvFU=; b=lcWM/2H8JIwfN7g6GQSKhn5HRCbHfBDhVVhobLWG1CrkBqifGSvFsPxq9j+vb8Z2Ms 7Orfd3a3Dy9PRsAO4BGC0BGIHbzyzLG7r9AT+BwEMS7vVZJpLa14yNhAkKjKIwQwQovH +Slwvb3A6KAwAthvRiNCsrPsVu+hjI/QMEH7typzff+1U99dZnqbooLY6rLmyb65Pa7d sC7qUGet88sYCbNogYtMLfbrkFTpdrU45/rK/hmt/Dhc73igc4q+UgkSWb71lBmESoXJ KxDp53e/BLdfc4M65Lgpm+UbhgGy++sTIVOIsRtBwPQsXGPWXcrC5sA8F9xA5rckJlZC uJdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S3kO73xXQn6D5/dq+9agjMfbsu/xcRmv3KxmrQoyvFU=; b=LIfykhsKlU72/2MGPGA6uf6dGXeF0h2sFqTUx+bprJuCOLypsWHisGE8Z8KEXBgB16 TV3WncfDCi19jF0crzJD5/qKmyYJZFoW0YSpWgjtCpCUbF3x488LgVTbZGhEgyWKHFV7 NeZ3EfpcByfZCUT/hg5suAVv0wpObyUhqXpeBR2VR7nZTBgwFOy/anHHSHxN2b50CGv8 YyrrIPNyXoJeZxKm5I3khAbw7xXoFDsji+LCqxERijE21hD6aiNmnar2+QyVTHl9lC+Z x/44OeP2Mo5dni1hKpAJR9XG3C5X5s87ng3oN27oe3cVCzLRLWgjUGT53FXBooig446j kBow== X-Gm-Message-State: AO0yUKXfDnGerTqXQnYhO3XJBFD2ud+Ei7nXyoIrVUk4A6ZHhJPHB2Cf ROJYoPEkOFxCiGzUOs8OfCFwzXNEARY= X-Google-Smtp-Source: AK7set865DkxLirb4fKufWDV1PfZBsAMDE7TSJM3woWfvXicxd93WHG4dp9fCRykV0o2ISsq7Nh3Og== X-Received: by 2002:a05:600c:3d95:b0:3e8:35a2:6abf with SMTP id bi21-20020a05600c3d9500b003e835a26abfmr5924892wmb.23.1677145106739; Thu, 23 Feb 2023 01:38:26 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id o10-20020a1c750a000000b003e7c89b3514sm7519019wmc.23.2023.02.23.01.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:38:26 -0800 (PST) From: luca.boccassi@gmail.com To: Volodymyr Fialko Cc: Akhil Goyal , dpdk stable Subject: patch 'test/crypto: add missing MAC-I to PDCP vectors' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:25 +0000 Message-Id: <20230223093715.3926893-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9ce02a45cca8c63f4ba0f8d89bbcda6e79dbc3b1 Thanks. Luca Boccassi --- >From 9ce02a45cca8c63f4ba0f8d89bbcda6e79dbc3b1 Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Tue, 24 Jan 2023 17:39:24 +0100 Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors [ upstream commit 7b2ae9efa223b220f4699c1940a6ed530e063bf8 ] Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL integrity do not contain the MAC-I (32-bit of all zeros according to the specification). Vectors for other SN length (5, 18 bits) have the MAC-I set. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity cases") Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- app/test/test_cryptodev_security_pdcp_test_vectors.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev_security_pdcp_test_vectors.h b/app/test/test_cryptodev_security_pdcp_test_vectors.h index 3e8a8a243e..8e007f7802 100644 --- a/app/test/test_cryptodev_security_pdcp_test_vectors.h +++ b/app/test/test_cryptodev_security_pdcp_test_vectors.h @@ -5441,7 +5441,7 @@ static uint8_t *pdcp_test_data_out[] = { 0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70, 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* Control Plane w/NULL enc. + NULL int. DL LONG SN */ (uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, 0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71, @@ -5449,7 +5449,7 @@ static uint8_t *pdcp_test_data_out[] = { 0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70, 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* Control Plane w/NULL enc. + SNOW f9 int. UL LONG SN */ (uint8_t[]){0x00, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, 0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71, @@ -5835,7 +5835,7 @@ static uint8_t *pdcp_test_data_out[] = { 0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70, 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* User Plane w/NULL enc. + NULL int. DL for 12-bit SN */ (uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, 0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71, @@ -5843,7 +5843,7 @@ static uint8_t *pdcp_test_data_out[] = { 0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70, 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* User Plane w/NULL enc. + SNOW f9 int. UL for 12-bit SN */ (uint8_t[]){0x80, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, 0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71, -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:29.124940690 +0000 +++ 0021-test-crypto-add-missing-MAC-I-to-PDCP-vectors.patch 2023-02-23 09:36:28.214169719 +0000 @@ -1 +1 @@ -From 7b2ae9efa223b220f4699c1940a6ed530e063bf8 Mon Sep 17 00:00:00 2001 +From 9ce02a45cca8c63f4ba0f8d89bbcda6e79dbc3b1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7b2ae9efa223b220f4699c1940a6ed530e063bf8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 6fdc4cd9e3..56d4884529 100644 +index 3e8a8a243e..8e007f7802 100644 @@ -25 +26 @@ -@@ -5560,7 +5560,7 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5441,7 +5441,7 @@ static uint8_t *pdcp_test_data_out[] = { @@ -34 +35 @@ -@@ -5568,7 +5568,7 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5449,7 +5449,7 @@ static uint8_t *pdcp_test_data_out[] = { @@ -43 +44 @@ -@@ -5954,7 +5954,7 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5835,7 +5835,7 @@ static uint8_t *pdcp_test_data_out[] = { @@ -52 +53 @@ -@@ -5962,7 +5962,7 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5843,7 +5843,7 @@ static uint8_t *pdcp_test_data_out[] = {