From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC8A341D4F for ; Thu, 23 Feb 2023 10:38:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8924431A5; Thu, 23 Feb 2023 10:38:32 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 97C4A427E9 for ; Thu, 23 Feb 2023 10:38:31 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id l25so9735481wrb.3 for ; Thu, 23 Feb 2023 01:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gge8dHZMpXZzWGemgwmVxFzYw234HGwOCWZ2Xojt6cU=; b=DWHn64sJMh/8Cr0yTO51Vfy/9EYEuIBcUG2u+o5jTmDJrzijuICP4XMJzMyqm6HclL Zer3Uc3ZmLbuAoXTkv6WNgoVSxna8/S3RCQbQlJvXeBNMIB3wRODHsK0ve/wyxvPMtDr zqFZKfvIYBcV+b5UcZ7FV8WaMq+sVhegnbs3t4JVzKvo9jOoxEyMsdcr4ZNW43zPeiBm F/EG53uDz5Ee4sD2OMilrQRz1za16bpQLsQmN+jrs8yZ1WiGpLK4KoMBckr0XfgnRXnW 9Yq4ooLDUOcaYRnll/0H4ofZ+nKGm7Xrzc9pN6j6qfx4x9SK4cMRNrM1TUfSH4ninb+O hgtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gge8dHZMpXZzWGemgwmVxFzYw234HGwOCWZ2Xojt6cU=; b=UtJ39r7rI9wIkRIhU0DNonHGobFymVIzmqTi7pT5apw8YZMQ32ZBBEIh+EBVLmTJbM HOPcrm5r9XvrbDq2VlzgQXDxdsRzwr6TdW+V8UonAZbP7OjAZaeKB+gaFqTgZB9Z05Mz 0aKF0ItIlNBFNCwWfIt92xcUzs+/+mOwhA4c6zWCfcdufGq6fgsdHc572iX4kVpGoQ/G BfKOn/umVpKHWQHIdEYkPFaDiMN860UKaCtc6hyHgG8ElOnW1AQpjagzyM5jmqzdMp4A NdTw9inKgGVCdzWKUvSIca/SOJoTxwHH/UFF2LG9URuQG4gDy4UT42qZoNBZytiPTrOS j+Bw== X-Gm-Message-State: AO0yUKX1DpwFLhZZ7M/pDeIXgvCicKw7AHbcRVpEyqLXDIAB8qBNm+lK +SZRX4vTEgi2qoU/bEZR/cw73O4n8sA= X-Google-Smtp-Source: AK7set/gg6c0yuqqeHM6pTB3Qk1SPj2eVSGpqhNI3o4KHZNgxP4k9GOiW4DU3Py1EuK1zrvv8TRRQQ== X-Received: by 2002:a5d:408e:0:b0:2c7:deb:c61 with SMTP id o14-20020a5d408e000000b002c70deb0c61mr2941615wrp.39.1677145111330; Thu, 23 Feb 2023 01:38:31 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id n17-20020adff091000000b002c553509db7sm261528wro.52.2023.02.23.01.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:38:30 -0800 (PST) From: luca.boccassi@gmail.com To: Venkat Duvvuru Cc: Kalesh AP , Kishore Padmanabha , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix RSS hash in mbuf' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:29 +0000 Message-Id: <20230223093715.3926893-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d00a67ba5cc37b80374f9c2faa2ff4c38a3a361f Thanks. Luca Boccassi --- >From d00a67ba5cc37b80374f9c2faa2ff4c38a3a361f Mon Sep 17 00:00:00 2001 From: Venkat Duvvuru Date: Wed, 1 Feb 2023 09:50:14 +0530 Subject: [PATCH] net/bnxt: fix RSS hash in mbuf [ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ] By clearing mbuf->hash.fdir.id in the data path, the driver is corrupting the RSS hash value populated in the mbuf as they are defined as a union. This patch fixes the problem by removing the code that clears mbuf->hash.fdir.id. Fixes: 17b6c8386d73 ("net/bnxt: fix mark handling") Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index f923b35ce2..c31b034bb7 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -749,7 +749,6 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1, skip_mark: mbuf->hash.fdir.hi = 0; - mbuf->hash.fdir.id = 0; return 0; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:29.275556963 +0000 +++ 0025-net-bnxt-fix-RSS-hash-in-mbuf.patch 2023-02-23 09:36:28.218169792 +0000 @@ -1 +1 @@ -From 031102f531e87e25174d4744c4ced92e5b291891 Mon Sep 17 00:00:00 2001 +From d00a67ba5cc37b80374f9c2faa2ff4c38a3a361f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index daaf9ffc1e..0eebddb05d 100644 +index f923b35ce2..c31b034bb7 100644 @@ -28 +29 @@ -@@ -813,7 +813,6 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1, +@@ -749,7 +749,6 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1,