From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF36141D52 for ; Thu, 23 Feb 2023 16:07:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBF1043259; Thu, 23 Feb 2023 16:07:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 384FF4324B for ; Thu, 23 Feb 2023 16:07:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XuUOr8yM3cLPia6lvbhxCztUlpcQxmz5APD8NNQ00UA=; b=HWZjDamuv4OMuHaKfqXyFeYWhIuWrJmXO8/QsTXC3UTtb+jOMZgoEo8KfWbibMe9kbifJX HTbGiC6epQZgSPBPRhJpCy+bjYxuEaM8Z3m0KXXRmbVey/MKJdMeSgFHiMbzRg86XqYnbP gIXUnSM+ooUwKJE7Ep5ZiW4YYDO6HNg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-472-IfmNAc6VOSmMGLUT28HI2Q-1; Thu, 23 Feb 2023 10:07:30 -0500 X-MC-Unique: IfmNAc6VOSmMGLUT28HI2Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8DB681C05AF5; Thu, 23 Feb 2023 15:07:28 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id B22422166B29; Thu, 23 Feb 2023 15:07:27 +0000 (UTC) From: Kevin Traynor To: Volodymyr Fialko Cc: Akhil Goyal , dpdk stable Subject: patch 'test/crypto: add missing MAC-I to PDCP vectors' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:23 +0000 Message-Id: <20230223150631.723699-32-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/af78ee860e18accfeba4dfbad72c14d6a759e7cd Thanks. Kevin --- >From af78ee860e18accfeba4dfbad72c14d6a759e7cd Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Tue, 24 Jan 2023 17:39:24 +0100 Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors [ upstream commit 7b2ae9efa223b220f4699c1940a6ed530e063bf8 ] Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL integrity do not contain the MAC-I (32-bit of all zeros according to the specification). Vectors for other SN length (5, 18 bits) have the MAC-I set. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity cases") Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- app/test/test_cryptodev_security_pdcp_test_vectors.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev_security_pdcp_test_vectors.h b/app/test/test_cryptodev_security_pdcp_test_vectors.h index c82bc50631..54c7e2420a 100644 --- a/app/test/test_cryptodev_security_pdcp_test_vectors.h +++ b/app/test/test_cryptodev_security_pdcp_test_vectors.h @@ -5545,5 +5545,5 @@ static uint8_t *pdcp_test_data_out[] = { 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* Control Plane w/NULL enc. + NULL int. DL LONG SN */ (uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, @@ -5553,5 +5553,5 @@ static uint8_t *pdcp_test_data_out[] = { 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* Control Plane w/NULL enc. + SNOW f9 int. UL LONG SN */ (uint8_t[]){0x00, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, @@ -5939,5 +5939,5 @@ static uint8_t *pdcp_test_data_out[] = { 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* User Plane w/NULL enc. + NULL int. DL for 12-bit SN */ (uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, @@ -5947,5 +5947,5 @@ static uint8_t *pdcp_test_data_out[] = { 0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C, 0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46, - 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD}, + 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00}, /* User Plane w/NULL enc. + SNOW f9 int. UL for 12-bit SN */ (uint8_t[]){0x80, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82, -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.612444488 +0000 +++ 0032-test-crypto-add-missing-MAC-I-to-PDCP-vectors.patch 2023-02-23 14:46:23.752235903 +0000 @@ -1 +1 @@ -From 7b2ae9efa223b220f4699c1940a6ed530e063bf8 Mon Sep 17 00:00:00 2001 +From af78ee860e18accfeba4dfbad72c14d6a759e7cd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7b2ae9efa223b220f4699c1940a6ed530e063bf8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 6fdc4cd9e3..56d4884529 100644 +index c82bc50631..54c7e2420a 100644 @@ -25 +26 @@ -@@ -5561,5 +5561,5 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5545,5 +5545,5 @@ static uint8_t *pdcp_test_data_out[] = { @@ -32 +33 @@ -@@ -5569,5 +5569,5 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5553,5 +5553,5 @@ static uint8_t *pdcp_test_data_out[] = { @@ -39 +40 @@ -@@ -5955,5 +5955,5 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5939,5 +5939,5 @@ static uint8_t *pdcp_test_data_out[] = { @@ -46 +47 @@ -@@ -5963,5 +5963,5 @@ static uint8_t *pdcp_test_data_out[] = { +@@ -5947,5 +5947,5 @@ static uint8_t *pdcp_test_data_out[] = {