From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E81241D52 for ; Thu, 23 Feb 2023 16:07:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0C0643268; Thu, 23 Feb 2023 16:07:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D88143255 for ; Thu, 23 Feb 2023 16:07:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qjRVufmpRkeLWg9MfGEmUsKvZTefygUipkqYjiePtnk=; b=g5xE/Gbp0bCsTBfD7Og/Qq+NrLm6PSoXZ1L6kgg4qYQUOuJiMGqxjLtzZBoQhSF9/sd/A2 iYvAM/H91SCOqqXSocqyaEa4lI5lOSVWXnZEoFvLt+wFHaIVWVaO36KOf012W3nHlHnTjM NpMKhpvUwzP9aw/OBay1qC+X5AISOvo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-Jq1_HtsfOzqehSAvL8czOg-1; Thu, 23 Feb 2023 10:07:35 -0500 X-MC-Unique: Jq1_HtsfOzqehSAvL8czOg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B99418E0058; Thu, 23 Feb 2023 15:07:33 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78B042166B29; Thu, 23 Feb 2023 15:07:32 +0000 (UTC) From: Kevin Traynor To: Venkat Duvvuru Cc: Kalesh AP , Kishore Padmanabha , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix RSS hash in mbuf' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:27 +0000 Message-Id: <20230223150631.723699-36-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2b15b1cd4a3994d5a09aa31990d7075d4caf9057 Thanks. Kevin --- >From 2b15b1cd4a3994d5a09aa31990d7075d4caf9057 Mon Sep 17 00:00:00 2001 From: Venkat Duvvuru Date: Wed, 1 Feb 2023 09:50:14 +0530 Subject: [PATCH] net/bnxt: fix RSS hash in mbuf [ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ] By clearing mbuf->hash.fdir.id in the data path, the driver is corrupting the RSS hash value populated in the mbuf as they are defined as a union. This patch fixes the problem by removing the code that clears mbuf->hash.fdir.id. Fixes: 17b6c8386d73 ("net/bnxt: fix mark handling") Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index b60c2470f3..4e56c7c99f 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -814,5 +814,4 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1, skip_mark: mbuf->hash.fdir.hi = 0; - mbuf->hash.fdir.id = 0; return 0; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.704875077 +0000 +++ 0036-net-bnxt-fix-RSS-hash-in-mbuf.patch 2023-02-23 14:46:23.757235921 +0000 @@ -1 +1 @@ -From 031102f531e87e25174d4744c4ced92e5b291891 Mon Sep 17 00:00:00 2001 +From 2b15b1cd4a3994d5a09aa31990d7075d4caf9057 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index daaf9ffc1e..0eebddb05d 100644 +index b60c2470f3..4e56c7c99f 100644