From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A561341E9F for ; Wed, 15 Mar 2023 15:37:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC77942D1D; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7744E40EE4 for ; Wed, 15 Mar 2023 15:37:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h6voGaG8Rmqqfc7diZrJnHlG3aMUNpBUC+b56kFAW5E=; b=chshGnIZstrgaQqmxmMt9nfjPeXGBqaw8GtD03tXMw95wr0/nfZWS2PM1KoUQSX5Eex/9L +jy3YT+LNPByUcCAc2Kvo41nByV19V57yuIQNOY1s5+ovAPSpm/USU4PZQ4mcx4t6g2IzX CBZpJvUldSTYr4UZyWM7Bm9FobmA8Ao= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-TJm__RyRNhu-QTkrEPz8eA-1; Wed, 15 Mar 2023 10:37:11 -0400 X-MC-Unique: TJm__RyRNhu-QTkrEPz8eA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71CB13C66722; Wed, 15 Mar 2023 14:37:11 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD4BC40C6E67; Wed, 15 Mar 2023 14:37:10 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Olivier Matz , dpdk stable Subject: patch 'kvargs: add API documentation for process callback' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:17 +0000 Message-Id: <20230315143640.677317-24-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5d95507d27620c367e3e20dc0fe47dafd3ee1c36 Thanks. Kevin --- >From 5d95507d27620c367e3e20dc0fe47dafd3ee1c36 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:04 +0000 Subject: [PATCH] kvargs: add API documentation for process callback [ upstream commit 52ab17efdecf935792ee1d0cb749c0dbd536c083 ] The rte_kvargs_process() is used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function (which prototype is arg_handler_t) parameter 'value' is NULL when parsing 'only keys'. But there is no detailed definition of 'value' may be NULL, so this patch adds it. Signed-off-by: Chengwen Feng Acked-by: Olivier Matz --- lib/kvargs/rte_kvargs.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h index 359a9f5b09..4900b750bc 100644 --- a/lib/kvargs/rte_kvargs.h +++ b/lib/kvargs/rte_kvargs.h @@ -37,5 +37,17 @@ extern "C" { #define RTE_KVARGS_KV_DELIM "=" -/** Type of callback function used by rte_kvargs_process() */ +/** + * Callback prototype used by rte_kvargs_process(). + * + * @param key + * The key to consider, it will not be NULL. + * @param value + * The value corresponding to the key, it may be NULL (e.g. only with key) + * @param opaque + * An opaque pointer coming from the caller. + * @return + * - >=0 handle key success. + * - <0 on error. + */ typedef int (*arg_handler_t)(const char *key, const char *value, void *opaque); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.189670104 +0000 +++ 0024-kvargs-add-API-documentation-for-process-callback.patch 2023-03-15 14:30:20.585123700 +0000 @@ -1 +1 @@ -From 52ab17efdecf935792ee1d0cb749c0dbd536c083 Mon Sep 17 00:00:00 2001 +From 5d95507d27620c367e3e20dc0fe47dafd3ee1c36 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 52ab17efdecf935792ee1d0cb749c0dbd536c083 ] + @@ -13,2 +14,0 @@ - -Cc: stable@dpdk.org