From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 508BB41E9F for ; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A45642C54; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D32E642D12 for ; Wed, 15 Mar 2023 15:37:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D8v1T14VUBGmWlh16RjFclegXXkeXoL/yWM2b+TnU4c=; b=JYkg9+cnBO5yibXDetxmdxZv6q+FmC8WO0SFORer5sxalzMTqYMXeJKAjveaqei9dKGmTv onqTMqPh7K3grH47iAXuaNJgq1SxW8J2C+Ti6VpZvxf0WeaEkAJiYgS+VO/bJ6vJNgmP/I /sSLZpI/XzYwFHOQiJWL9d681RvyNaE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-41-HzA8zo7LOLaibt9uuFfqMQ-1; Wed, 15 Mar 2023 10:37:12 -0400 X-MC-Unique: HzA8zo7LOLaibt9uuFfqMQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EE3F884622; Wed, 15 Mar 2023 14:37:12 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1A8D40C6E67; Wed, 15 Mar 2023 14:37:11 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: dpdk stable Subject: patch 'compressdev: fix empty devargs parsing' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:18 +0000 Message-Id: <20230315143640.677317-25-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cb72e899065dbc853f94ff5a6aa198c467f10b24 Thanks. Kevin --- >From cb72e899065dbc853f94ff5a6aa198c467f10b24 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:05 +0000 Subject: [PATCH] compressdev: fix empty devargs parsing [ upstream commit bb27182482d61777de6a38b16a1d2c692c2c3f8b ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault in rte_compressdev_pmd_parse_uint_arg() when parse input args with 'only keys' (e.g. socket_id). For a similar reason, this patch fixes rte_compressdev_pmd_parse_name_arg(). Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Signed-off-by: Chengwen Feng --- lib/compressdev/rte_compressdev_pmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/compressdev/rte_compressdev_pmd.c b/lib/compressdev/rte_compressdev_pmd.c index 7f500d76d4..6a11a396b7 100644 --- a/lib/compressdev/rte_compressdev_pmd.c +++ b/lib/compressdev/rte_compressdev_pmd.c @@ -21,4 +21,7 @@ rte_compressdev_pmd_parse_name_arg(const char *key __rte_unused, int n; + if (value == NULL || extra_args == NULL) + return -EINVAL; + n = strlcpy(params->name, value, RTE_COMPRESSDEV_NAME_MAX_LEN); if (n >= RTE_COMPRESSDEV_NAME_MAX_LEN) @@ -38,4 +41,7 @@ rte_compressdev_pmd_parse_uint_arg(const char *key __rte_unused, char *end; + if (value == NULL || extra_args == NULL) + return -EINVAL; + errno = 0; i = strtol(value, &end, 10); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.212075397 +0000 +++ 0025-compressdev-fix-empty-devargs-parsing.patch 2023-03-15 14:30:20.587123706 +0000 @@ -1 +1 @@ -From bb27182482d61777de6a38b16a1d2c692c2c3f8b Mon Sep 17 00:00:00 2001 +From cb72e899065dbc853f94ff5a6aa198c467f10b24 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bb27182482d61777de6a38b16a1d2c692c2c3f8b ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index e139bc86e7..156bccd972 100644 +index 7f500d76d4..6a11a396b7 100644 @@ -28 +29 @@ -@@ -24,4 +24,7 @@ rte_compressdev_pmd_parse_name_arg(const char *key __rte_unused, +@@ -21,4 +21,7 @@ rte_compressdev_pmd_parse_name_arg(const char *key __rte_unused, @@ -36 +37 @@ -@@ -41,4 +44,7 @@ rte_compressdev_pmd_parse_uint_arg(const char *key __rte_unused, +@@ -38,4 +41,7 @@ rte_compressdev_pmd_parse_uint_arg(const char *key __rte_unused,