From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94928427EF for ; Wed, 22 Mar 2023 11:32:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 903B940E09; Wed, 22 Mar 2023 11:32:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BE63440A84 for ; Wed, 22 Mar 2023 11:32:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679481152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SFMIdVaGeNXBPVohVuuZDKywwEc22x6psNKkYjwT/kY=; b=VVAbKc/s5PXvN+0utSv+vpFJc2GeQyVE3qEwCmJfUDSqf5erI+mA+vtwsLd9Q8MNB6HELY 2JbSk3MyaykKFvrbq5BsbDc916E0uCZIOERQoMzyldveMy6SU4F7pSbBdtOKzWSxnH+YOb M67tePQkyJS9fZWPSGaOhjGk5O6BHDA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-PUxST0WwOjuU6uIkU6eR_w-1; Wed, 22 Mar 2023 06:32:29 -0400 X-MC-Unique: PUxST0WwOjuU6uIkU6eR_w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64B5E3C10682; Wed, 22 Mar 2023 10:32:29 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C798492C13; Wed, 22 Mar 2023 10:32:28 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'app/bbdev: check statistics failure' has been queued to stable release 21.11.4 Date: Wed, 22 Mar 2023 10:31:55 +0000 Message-Id: <20230322103209.456098-8-ktraynor@redhat.com> In-Reply-To: <20230322103209.456098-1-ktraynor@redhat.com> References: <20230322103209.456098-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/24/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b3225c22153b05121d19502f8333ff4579c0a876 Thanks. Kevin --- >From b3225c22153b05121d19502f8333ff4579c0a876 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Wed, 8 Mar 2023 19:36:24 -0800 Subject: [PATCH] app/bbdev: check statistics failure [ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index aab2c41ec1..3f2bac6136 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -4728,5 +4728,5 @@ offload_cost_test(struct active_device *ad, return TEST_SKIPPED; #else - int iter; + int iter, ret; uint16_t burst_sz = op_params->burst_sz; const uint16_t num_to_process = op_params->num_to_process; @@ -4819,5 +4819,8 @@ offload_cost_test(struct active_device *ad, struct rte_bbdev_stats stats = {0}; - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + TEST_ASSERT_SUCCESS(ret, + "Failed to get stats for queue (%u) of device (%u)", + queue_id, ad->dev_id); if (op_type != RTE_BBDEV_OP_LDPC_DEC) { TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process, -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-22 10:30:08.132506194 +0000 +++ 0008-app-bbdev-check-statistics-failure.patch 2023-03-22 10:30:07.909866558 +0000 @@ -1 +1 @@ -From ce1b62899167f6e2c49d8496afa43a9162167c6b Mon Sep 17 00:00:00 2001 +From b3225c22153b05121d19502f8333ff4579c0a876 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 15ebcdfc15..276bbf0a2e 100644 +index aab2c41ec1..3f2bac6136 100644 @@ -22,3 +23,3 @@ -@@ -5680,5 +5680,5 @@ offload_cost_test(struct active_device *ad, - struct test_op_params *op_params) - { +@@ -4728,5 +4728,5 @@ offload_cost_test(struct active_device *ad, + return TEST_SKIPPED; + #else @@ -29 +30 @@ -@@ -5775,5 +5775,8 @@ offload_cost_test(struct active_device *ad, +@@ -4819,5 +4819,8 @@ offload_cost_test(struct active_device *ad, @@ -37,2 +38,2 @@ - if (stats.enqueue_warn_count > 0) - printf("Warning reported on the queue : %10"PRIu64"\n", + if (op_type != RTE_BBDEV_OP_LDPC_DEC) { + TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process,